genegr commented on PR #13049: URL: https://github.com/apache/cloudstack/pull/13049#issuecomment-4335643542
Pushed `be8785a1de flasharray: clarify snapshot naming comment per Copilot review` to address the latest Copilot suggestion on the snapshot-skip-rename block. The comment now reads: > Snapshots live under /volume-snapshots and already use the array's reserved form `<volume>.<suffix>`, which legitimately contains ".". The stricter `[A-Za-z0-9_-]` naming rule applies to regular volume names and free-form rename targets, not to these reserved snapshot names. Since FlashArray snapshot names are system-defined rather than arbitrary rename targets, we skip the usual timestamped rename and only mark snapshots destroyed; the array's own ".N" suffix already disambiguates them in the recycle bin. Comment-only change — behaviour is unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
