Kunalbehbud commented on code in PR #13020:
URL: https://github.com/apache/cloudstack/pull/13020#discussion_r3143618719
##########
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/vmsnapshot/KvmFileBasedStorageVmSnapshotStrategy.java:
##########
@@ -176,6 +198,7 @@ public boolean revertVMSnapshot(VMSnapshot vmSnapshot) {
VMSnapshotVO vmSnapshotBeingReverted = (VMSnapshotVO) vmSnapshot;
Long hostId =
vmSnapshotHelper.pickRunningHost(vmSnapshotBeingReverted.getVmId());
+ validateHostSupportsUefiNvramAwareDiskOnlySnapshots(hostId, userVm,
"revert");
Review Comment:
Agreed. Host selection now looks for the required capabilities before
sending the command. One nuance is stopped UEFI snapshot creation does not fall
back away from the VM's last host, because the active NVRAM file is host-local.
Revert and sidecar cleanup can still use a capable fallback host.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
