Kunalbehbud commented on code in PR #13020:
URL: https://github.com/apache/cloudstack/pull/13020#discussion_r3143624307
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtReadyCommandWrapper.java:
##########
@@ -43,6 +43,7 @@ public final class LibvirtReadyCommandWrapper extends
CommandWrapper<ReadyComman
@Override
public Answer execute(final ReadyCommand command, final
LibvirtComputingResource libvirtComputingResource) {
Map<String, String> hostDetails = new HashMap<String, String>();
+ hostDetails.put(Host.HOST_KVM_DISK_ONLY_VM_SNAPSHOT_NVRAM,
Boolean.TRUE.toString());
Review Comment:
I kept this as an advertised agent capability rather than a config option.
It reflects whether the KVM agent version understands the NVRAM sidecar flow.
Making it configurable could let management send these commands to an agent
that does not actually support them, which is unsafe during rolling upgrades.
##########
PendingReleaseNotes:
##########
@@ -39,3 +39,17 @@ example.ver.1 > example.ver.2:
which can now be attached to Instances. This is to prevent the Secondary
Storage to grow to enormous sizes as Linux Distributions keep growing in
size while a stripped down Linux should fit on a 2.88MB floppy.
+
+4.22.0.0 > 4.22.0.1:
+ * Disk-only instance snapshots for KVM UEFI VMs now include a sidecar copy of
+ the active NVRAM state so revert operations restore both disk and firmware
+ boot state consistently.
+
+ * UEFI disk-only instance snapshots taken before this change do not contain
an
+ NVRAM sidecar and cannot be safely reverted. Take a new snapshot after
+ upgrading before relying on revert for UEFI VMs.
+
+ * Taking a disk-only instance snapshot for KVM UEFI VMs now briefly suspends
+ the guest while the NVRAM sidecar is copied, so that the captured firmware
+ state is consistent with the disk snapshot. Non-UEFI VMs are unaffected and
+ continue to snapshot live.
Review Comment:
added this to the createVMSnapshot API description and to the UI
confirmation message for the Instance Snapshot action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
