poddm commented on PR #11071:
URL: https://github.com/apache/cloudstack/pull/11071#issuecomment-4354450527
@rg9975 -
Should MultipathSCSIAdapterBase.java or FiberChannelAdapter.java implement
`AsyncPhysicalDiskConnectorDecorator`?
this check in KVMStoragePoolManagerwould would never be true:
```java
if (adaptor instanceof AsyncPhysicalDiskConnectorDecorator) {
```
Java requires the interface to be declared on the class (or a superclass)
for instanceof to match. Without it, the entire async disk connection path is
dead code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
