Kunalbehbud commented on code in PR #13020:
URL: https://github.com/apache/cloudstack/pull/13020#discussion_r3172806707
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtReadyCommandWrapper.java:
##########
@@ -43,6 +43,7 @@ public final class LibvirtReadyCommandWrapper extends
CommandWrapper<ReadyComman
@Override
public Answer execute(final ReadyCommand command, final
LibvirtComputingResource libvirtComputingResource) {
Map<String, String> hostDetails = new HashMap<String, String>();
+ hostDetails.put(Host.HOST_KVM_DISK_ONLY_VM_SNAPSHOT_NVRAM,
Boolean.TRUE.toString());
Review Comment:
Yes, mainly for rolling upgrade cases. Older KVM agents will not know how to
handle the NVRAM sidecar fields, so management should only use this flow on
hosts that explicitly advertise support for it. I did not make it configurable
because this is not really an operator choice that it reflects whether the
agent code on that host supports the flow. The reconnect handling also removes
the detail again if a host comes back without advertising it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
