jmsperu commented on PR #12843: URL: https://github.com/apache/cloudstack/pull/12843#issuecomment-4522876873
Belated reply @abh1sar — you were right, there's significant overlap with what's already landed on main. The quiesce support and EXIT_CLEANUP_FAILED handling from this PR have since been merged upstream (likely via the broader nasbackup.sh improvements in #12822 and others), so those bits are now redundant. What's still uniquely unaddressed by what landed: - **`BACKUP_TIMEOUT` env var** (default 21600s = 6h) wrapping the long-running `virsh backup-begin` poll loop so a stuck backup eventually fails rather than holding the agent forever - **`MIN_FREE_SPACE` check** against the mounted NAS before `qemu-img convert` runs, with a fast-fail when the NAS doesn't have enough free space — currently we discover this mid-write - **`trap cleanup EXIT`** so cleanup() runs even on SIGTERM / shell death (today cleanup() only runs on graceful exits) I'll rebase against main to drop the overlapping changes and keep only those three, then push again. If you'd rather close this and open a fresh narrower PR with just those bits, also happy to do that — your call. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
