weizhouapache commented on PR #13032: URL: https://github.com/apache/cloudstack/pull/13032#issuecomment-4629680427
> thanks a lot @vishesh92 for the review, very good comments > > I will look into the following > > * check if prepare and release nic can be improved > * check setExtraDhcpOptions if nic_id is needed > * check if nic_uuid can be replaced with nic_id (I guess no) > * take ipv6 address nto consideratoin > * pass some data in jsonobject, instead of building json string > * discard base64 encoding (for legacy CLI) and remove jsonEscape method > * check resolveExtensionForVpc in a zone with multiple physical networks I made some changes for above - add commands: prepare-nic and release-nic - remove all codes for `setExtraDhcpOptions` - Add some methods to add network, nic, public payload, so all payloads are consistent mostly - add ipv6 address in logs and payloads - remove base64 encoding and jsonEscape method, replace them with JSON objects/arrays in the payloads. - resolveExtensionForVpc considers the vpc tiers (vpc does not have associated physical network) I also made some changes on the network namespace implementation, all worked in my manual test. additionally , I made some changes to introduce an isolation method: NetworkExtension, I am testing it with an implementation, so it is not included yet. @vishesh92 could you please re-review it ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
