JoaoJandre commented on PR #12758: URL: https://github.com/apache/cloudstack/pull/12758#issuecomment-4802093164
@DaanHoogland This PR adds a hidden shared network for the validation process, it uses the `192.168.0.1/16` CIDR as the private IP range. The `test_public_ip_range` test was trying to add the `192.168.99.1/24` as a "public" IP range. But ACS does not allow a public IP range to overlap with a private IP range, thus an error was being thrown. I changed the test to add the `10.1.99.1/24` CIDR as its "public" range. Regarding `test_purge_expunged_vms`, I added a "ON DELETE CASCADE" to the `internal_backup_service_job` table so that the jobs are expunged alongside the `backups` (which are deleted on cascade from the `vm_instance` table expunge) Lets see if the tests run now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
