Copilot commented on code in PR #13632: URL: https://github.com/apache/cloudstack/pull/13632#discussion_r3620625930
########## ui/node-options-wrapper.sh: ########## @@ -0,0 +1,27 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Webpack 4 hashes with MD4, which OpenSSL 3 (Node 17+) no longer provides +# by default, causing ERR_OSSL_EVP_UNSUPPORTED. --openssl-legacy-provider +# restores it, but the flag doesn't exist before Node 17 and node refuses to +# even start with it set in NODE_OPTIONS, so only add it when needed. +NODE_MAJOR=$(node -p "process.versions.node.split('.')[0]") +if [ "$NODE_MAJOR" -ge 17 ]; then + export NODE_OPTIONS="--openssl-legacy-provider ${NODE_OPTIONS}" +fi Review Comment: In `export NODE_OPTIONS="--openssl-legacy-provider ${NODE_OPTIONS}"`, when `NODE_OPTIONS` is empty this leaves a trailing space, and it always prepends the flag even if it’s already present. Using bash parameter expansion avoids extra whitespace and makes the intent clearer. ########## ui/package.json: ########## @@ -25,77 +25,77 @@ }, "scripts": { "prebuild": "./prebuild.sh", - "start": "vue-cli-service lint --no-fix && vue-cli-service serve", - "serve": "vue-cli-service lint --no-fix && vue-cli-service serve", - "build": "vue-cli-service build", + "start": "./node-options-wrapper.sh vue-cli-service lint --no-fix && ./node-options-wrapper.sh vue-cli-service serve", + "serve": "./node-options-wrapper.sh vue-cli-service lint --no-fix && ./node-options-wrapper.sh vue-cli-service serve", + "build": "NODE_OPTIONS='--max-old-space-size=4096' ./node-options-wrapper.sh vue-cli-service build", Review Comment: The build script sets `NODE_OPTIONS` via a leading env assignment, which overrides any `NODE_OPTIONS` the user already has (e.g. extra debug flags, custom loaders). Consider appending instead so existing options are preserved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
