DaanHoogland commented on code in PR #13650:
URL: https://github.com/apache/cloudstack/pull/13650#discussion_r3628666900
##########
plugins/integrations/prometheus/src/main/java/org/apache/cloudstack/metrics/PrometheusExporterImpl.java:
##########
@@ -494,10 +491,17 @@ private void addVMsBySizeMetrics(final List<Item>
metricsList, final long dcId,
public void updateMetrics() {
final List<Item> latestMetricsItems = new ArrayList<Item>();
try {
+ // NOTE: capacity data is refreshed independently by
AlertManagerImpl's own
Review Comment:
ok, makes sense. I’ll move this to the javadoc in the interface/declaration
of `updateMetrics()` (and edit it.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
