sureshanaparti commented on code in PR #13877:
URL: https://github.com/apache/cloudstack/pull/13877#discussion_r3980711029
##########
plugins/backup/nas/src/main/java/org/apache/cloudstack/backup/NASBackupProvider.java:
##########
@@ -78,13 +84,38 @@
public class NASBackupProvider extends AdapterBase implements BackupProvider,
Configurable {
private static final Logger LOG =
LogManager.getLogger(NASBackupProvider.class);
+ private static final int CHAIN_LOCK_TIMEOUT_SECONDS = 300;
+
ConfigKey<Integer> NASBackupRestoreMountTimeout = new
ConfigKey<>("Advanced", Integer.class,
"nas.backup.restore.mount.timeout",
"30",
"Timeout in seconds after which backup repository mount for
restore fails.",
true,
BackupFrameworkEnabled.key());
+ ConfigKey<Integer> NASBackupFullEvery = new ConfigKey<>("Advanced",
Integer.class,
+ "nas.backup.full.every",
+ "10",
+ "Take a full NAS backup every Nth backup; remaining backups in
between are incremental. " +
+ "Counts backups, not days, so it works for hourly, daily,
and ad-hoc schedules. " +
+ "Set to 1 to disable incrementals (every backup is full).",
+ true,
+ ConfigKey.Scope.Zone,
+ BackupFrameworkEnabled.key());
Review Comment:
```suggestion
NASBackupIncrementalEnabled.key());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
