chrislusf commented on PR #14160: URL: https://github.com/apache/cloudstack/pull/14160#issuecomment-5683499726
Addressed Copilot review `5206611018`. - Credential detail writes: fixed in `932cc3c`; the access/secret pair now rolls back together and cleans up the newly-created IAM key on persistence failure. - Delete accounting idempotency: fixed in `932cc3c`; bucket count, `object_storage`, allocated size, and row removal are handled together after the driver delete path returns. - Quota update accounting and `BucketVO` persistence: fixed in `932cc3c`; `updateAllocatedSize` is checked, resource counts are compensated on failure, remote quota is restored, and quota persistence happens inside the quota helper. - Missing SeaweedFS quota extension: fixed in the branch by allowing missing extension only before the bucket has allocated state, not during update/rollback paths. - Bucket URL / storage URL trailing slash normalization: fixed in `e76aef2`. - Store-wide bucket-name locking for create/delete: fixed in `c9eaf62`. Validated with: - `mvn -pl plugins/storage/object/seaweedfs -Dtest=SeaweedFSObjectStoreDriverImplTest -Dnet.bytebuddy.experimental=true test` - `mvn -pl server -Dtest=BucketApiServiceImplTest -Dnet.bytebuddy.experimental=true test` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
