Copilot commented on code in PR #14160:
URL: https://github.com/apache/cloudstack/pull/14160#discussion_r4012630288
##########
server/src/main/java/com/cloud/storage/StorageManagerImpl.java:
##########
@@ -4812,6 +4813,30 @@ public ObjectStore updateObjectStore(Long id,
UpdateObjectStoragePoolCmd cmd) {
return objectStoreVO;
}
+ /**
+ * Rewrite the stored bucketURL of every bucket on an object store after
the
+ * store URL changes.
+ *
+ * BucketVO.bucketURL is written only at bucket creation. BucketResponse
+ * exposes it and the object-store browser builds its S3 client from it, so
+ * without this the browser keeps targeting the old endpoint after a URL
+ * change while the management server uses the new one.
+ */
+ private void updateBucketUrls(Long storeId, String oldUrl, String newUrl) {
+ if (oldUrl == null || oldUrl.equals(newUrl)) {
+ return;
+ }
+ for (BucketVO bucket : _bucketDao.listByObjectStoreId(storeId)) {
+ String bucketUrl = bucket.getBucketURL();
+ if (bucketUrl == null || !bucketUrl.startsWith(oldUrl)) {
Review Comment:
`startsWith(oldUrl)` also matches unrelated explicit endpoints whose text
merely begins with the old URL. For example, with a store URL of `http://host`
and an explicit SeaweedFS S3 endpoint of `http://host:8333`, changing the store
URL rewrites that override and corrupts the bucket URL. Require an endpoint
boundary (normalized `oldUrl + "/"`) before replacing.
##########
plugins/storage/object/seaweedfs/src/main/java/org/apache/cloudstack/storage/datastore/driver/SeaweedFSObjectStoreDriverImpl.java:
##########
@@ -0,0 +1,931 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+// SPDX-License-Identifier: Apache-2.0
+package org.apache.cloudstack.storage.datastore.driver;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+import javax.inject.Inject;
+
+import org.apache.cloudstack.engine.subsystem.api.storage.DataStore;
+import org.apache.cloudstack.storage.datastore.db.ObjectStoreDao;
+import org.apache.cloudstack.storage.datastore.db.ObjectStoreDetailsDao;
+import org.apache.cloudstack.storage.datastore.db.ObjectStoreVO;
+import org.apache.cloudstack.storage.datastore.util.SeaweedFSObjectStoreUtil;
+import org.apache.cloudstack.storage.object.BaseObjectStoreDriverImpl;
+import org.apache.cloudstack.storage.object.Bucket;
+import org.apache.cloudstack.storage.object.BucketObject;
+
+import com.amazonaws.AmazonClientException;
+import com.amazonaws.services.identitymanagement.AmazonIdentityManagement;
+import com.amazonaws.services.identitymanagement.model.AccessKey;
+import com.amazonaws.services.identitymanagement.model.AccessKeyMetadata;
+import com.amazonaws.services.identitymanagement.model.CreateAccessKeyRequest;
+import com.amazonaws.services.identitymanagement.model.CreateAccessKeyResult;
+import com.amazonaws.services.identitymanagement.model.CreateUserRequest;
+import com.amazonaws.services.identitymanagement.model.DeleteAccessKeyRequest;
+import
com.amazonaws.services.identitymanagement.model.EntityAlreadyExistsException;
+import com.amazonaws.services.identitymanagement.model.ListAccessKeysRequest;
+import com.amazonaws.services.identitymanagement.model.PutUserPolicyRequest;
+import com.amazonaws.services.s3.AmazonS3;
+import com.amazonaws.services.s3.model.AccessControlList;
+import com.amazonaws.services.s3.model.BucketPolicy;
+import com.amazonaws.services.s3.model.BucketVersioningConfiguration;
+import com.amazonaws.services.s3.model.CreateBucketRequest;
+import com.amazonaws.services.s3.model.DeleteBucketPolicyRequest;
+import com.amazonaws.services.s3.model.BucketCrossOriginConfiguration;
+import com.amazonaws.services.s3.model.CORSRule;
+import com.amazonaws.services.s3.model.GetBucketPolicyRequest;
+import com.amazonaws.services.s3.model.SSEAlgorithm;
+import com.amazonaws.services.s3.model.ServerSideEncryptionByDefault;
+import com.amazonaws.services.s3.model.ServerSideEncryptionConfiguration;
+import com.amazonaws.services.s3.model.ServerSideEncryptionRule;
+import
com.amazonaws.services.s3.model.SetBucketCrossOriginConfigurationRequest;
+import com.amazonaws.services.s3.model.SetBucketEncryptionRequest;
+import com.amazonaws.services.s3.model.SetBucketVersioningConfigurationRequest;
+import com.cloud.agent.api.to.BucketTO;
+import com.cloud.agent.api.to.DataStoreTO;
+import com.cloud.storage.BucketVO;
+import com.cloud.storage.dao.BucketDao;
+import com.cloud.user.Account;
+import com.cloud.user.AccountDetailsDao;
+import com.cloud.user.dao.AccountDao;
+import com.cloud.utils.db.GlobalLock;
+import com.cloud.utils.exception.CloudRuntimeException;
+
+/**
+ * SeaweedFS object store driver.
+ *
+ * Bucket operations use the AWS S3 SDK v1 (path-style access,
endpoint-pinned).
+ * User/credential management uses the AWS IAM SDK v1, since SeaweedFS exposes
a
+ * standard AWS IAM-compatible API. No proprietary admin client is needed.
+ *
+ * Modeled on CloudianHyperStoreObjectStoreDriverImpl, which uses the same
+ * S3 + IAM SDK pair.
+ */
+public class SeaweedFSObjectStoreDriverImpl extends BaseObjectStoreDriverImpl {
+
+ @Inject
+ AccountDao _accountDao;
+
+ @Inject
+ AccountDetailsDao _accountDetailsDao;
+
+ @Inject
+ ObjectStoreDao _storeDao;
+
+ @Inject
+ BucketDao _bucketDao;
+
+ @Inject
+ ObjectStoreDetailsDao _storeDetailsDao;
+
+ private static final String ACS_PREFIX = "acs";
+
+ /**
+ * DB-backed global lock name prefix for serializing IAM provisioning and
+ * policy refreshes per store+account. Uses {@link GlobalLock} so the
+ * critical section is serialized across management servers in a
+ * clustered deployment, not just within a single JVM.
+ */
+ private static final String IAM_LOCK_PREFIX = "seaweedfs.iam.";
+
+ private static String getIamLockName(long storeId, long accountId) {
+ return IAM_LOCK_PREFIX + storeId + "." + accountId;
+ }
+
+ /**
+ * Acquire a DB-backed global lock for IAM operations on the given
+ * store+account. Returns a {@link GlobalLock} that the caller must
+ * {@link GlobalLock#unlock()} in a {@code finally} block, or {@code null}
+ * if the lock could not be acquired within the timeout.
+ *
+ * <p>Protected so tests can override with a no-op lock (the DB-backed
+ * {@link GlobalLock} requires a real transaction context).
+ */
+ protected GlobalLock acquireIamLock(long storeId, long accountId) {
+ GlobalLock lock = GlobalLock.getInternLock(getIamLockName(storeId,
accountId));
+ if (!lock.lock(300)) {
+ logger.warn("Failed to acquire IAM lock for store {} account {}",
storeId, accountId);
+ lock.releaseRef();
+ return null;
+ }
+ return lock;
+ }
+
+ @Override
+ public DataStoreTO getStoreTO(DataStore store) {
+ return null;
+ }
+
+ /**
+ * Get the SeaweedFS IAM user name for the given CloudStack account and
+ * store. The store ID is included so that two CloudStack pools pointing
+ * at the same SeaweedFS IAM service do not collide on the same
+ * {@code acs-<uuid>} user and overwrite each other's policy and access
+ * keys.
+ */
+ protected String getUserNameForAccount(Account account, long storeId) {
+ return String.format("%s-%d-%s", ACS_PREFIX, storeId,
account.getUuid());
+ }
+
+ /**
+ * Create the IAM user for the CloudStack account if it doesn't exist,
+ * attach the restricted S3 policy, and ensure the account has a usable
+ * IAM access key persisted in its account details.
+ *
+ * <p>If a previously stored access key is still present in IAM, it is
+ * reused rather than rotated. A new key is only created when no stored
+ * key exists or the stored key is no longer found in IAM; in the latter
+ * case any unmanaged (leftover) keys for the user are deleted first to
+ * avoid hitting IAM access-key limits. This keeps bucket records that
+ * reference the stored credentials valid across repeated calls.
+ *
+ * @return true if the user exists or was created, false on failure.
+ */
+ @Override
+ public boolean createUser(long accountId, long storeId) {
+ Account account = _accountDao.findById(accountId);
+ if (account == null) {
+ logger.error("Account {} not found", accountId);
+ return false;
+ }
+ String userName = getUserNameForAccount(account, storeId);
+ AmazonIdentityManagement iamClient = getIAMClient(storeId);
+
+ // Serialize per store+account across management servers so two
+ // concurrent bucket requests do not both rotate credentials and leave
+ // bucket rows with mismatched key pairs.
+ GlobalLock lock = acquireIamLock(storeId, accountId);
+ if (lock == null) {
+ return false;
+ }
+ try {
+
+ // Create the IAM user if it doesn't already exist
+ try {
+ iamClient.createUser(new CreateUserRequest(userName));
+ logger.info("Created IAM user {} for account {}", userName,
account.getAccountName());
+ } catch (EntityAlreadyExistsException e) {
+ logger.debug("IAM user {} already exists", userName);
+ }
+
+ // Attach a scoped IAM policy that allows access only to this
+ // account's own buckets (the tenant boundary). Refreshed whenever
+ // buckets are created or deleted. Use the lock-free variant since
+ // createUser already holds the IAM lock.
+ updateAccountIAMPolicyLocked(iamClient, storeId, accountId, null);
+
+ // Reuse the stored access key only if both the access key id and the
+ // secret key are present and the key is still Active in IAM; otherwise
+ // create a replacement.
+ Map<String, String> details =
_accountDetailsDao.findDetails(accountId);
+ String accessKeyDetailKey =
SeaweedFSObjectStoreUtil.keyAccessKey(storeId);
+ String secretKeyDetailKey =
SeaweedFSObjectStoreUtil.keySecretKey(storeId);
+ String storedAccessKeyId = details.get(accessKeyDetailKey);
+ String storedSecretKey = details.get(secretKeyDetailKey);
+ if (storedAccessKeyId != null && storedSecretKey != null
+ && iamAccessKeyExists(iamClient, userName, storedAccessKeyId))
{
+ logger.debug("Reusing existing IAM access key {} for user {}",
storedAccessKeyId, userName);
+ return true;
+ }
+
+ // The stored key is missing, inactive, or no longer in IAM. Clean up
+ // ALL keys (including the inactive stored one) before creating a
+ // replacement so we do not accumulate keys and hit IAM limits.
+ deleteUnmanagedAccessKeys(iamClient, userName, null);
+
+ CreateAccessKeyResult result = iamClient.createAccessKey(
+ new CreateAccessKeyRequest().withUserName(userName));
+ AccessKey key = result.getAccessKey();
+
+ // Update existing bucket records for this account/store with the new
+ // credentials BEFORE persisting the new key in account details. If a
+ // bucket update fails, the stored key remains the old one and a retry
+ // will re-enter the replacement path; if we persisted first, a retry
+ // would see the new stored key and return without repairing the
+ // remaining buckets.
+ updateAccountBucketCredentials(storeId, accountId, key);
+
+ // Persist the credentials in the account details (namespaced by
storeId)
+ details.put(accessKeyDetailKey, key.getAccessKeyId());
+ details.put(secretKeyDetailKey, key.getSecretAccessKey());
+ _accountDetailsDao.persist(accountId, details);
+
+ logger.info("Created IAM credentials {} for user {}",
key.getAccessKeyId(), userName);
+ return true;
+ } finally {
+ lock.unlock();
+ lock.releaseRef();
+ }
+ }
+
+ /**
+ * Update the IAM credentials on all BucketVO rows for this store/account
+ * so previously created buckets reflect the new (rotated) key pair.
+ * Mirrors
CloudianHyperStoreObjectStoreDriverImpl.updateAccountBucketCredentials.
+ */
+ private void updateAccountBucketCredentials(long storeId, long accountId,
AccessKey iamCredential) {
+ List<BucketVO> bucketList =
_bucketDao.listByObjectStoreIdAndAccountId(storeId, accountId);
+ for (BucketVO bucketVO : bucketList) {
+ logger.info("Updating accountId={} bucket {} with new IAM
credentials", accountId, bucketVO.getName());
+ bucketVO.setAccessKey(iamCredential.getAccessKeyId());
+ bucketVO.setSecretKey(iamCredential.getSecretAccessKey());
+ _bucketDao.update(bucketVO.getId(), bucketVO);
+ }
+ }
+
+ /**
+ * Refresh the per-account IAM user policy so it grants S3 access only to
+ * the account's current buckets (optionally excluding one, e.g. a bucket
+ * being deleted). This is the tenant boundary: each account's IAM
+ * credentials can only operate on that account's own buckets.
+ *
+ * Acquires the per-store/account IAM lock. Callers that already hold the
+ * lock (e.g. createUser, createBucket post-create) should call
+ * {@link #updateAccountIAMPolicyLocked} instead to avoid re-entrant lock
+ * acquisition warnings from GlobalLock.
+ *
+ * @param iamClient the IAM client
+ * @param storeId the object store
+ * @param accountId the CloudStack account
+ * @param excludeBucket a bucket name to omit (e.g. a bucket being
deleted),
+ * or null to include all of the account's buckets
+ */
+ protected void updateAccountIAMPolicy(AmazonIdentityManagement iamClient,
long storeId, long accountId, String excludeBucket) {
+ GlobalLock lock = acquireIamLock(storeId, accountId);
+ if (lock == null) {
+ throw new CloudRuntimeException("Failed to acquire IAM lock for
store " + storeId + " account " + accountId);
+ }
+ try {
+ updateAccountIAMPolicyLocked(iamClient, storeId, accountId,
excludeBucket);
+ } finally {
+ lock.unlock();
+ lock.releaseRef();
+ }
+ }
+
+ /**
+ * Lock-free variant of {@link #updateAccountIAMPolicy} for callers that
+ * already hold the per-store/account IAM lock. Performs the policy refresh
+ * without reacquiring the lock, avoiding the GlobalLock re-entrant
+ * acquisition warning.
+ */
+ protected void updateAccountIAMPolicyLocked(AmazonIdentityManagement
iamClient, long storeId, long accountId, String excludeBucket) {
+ Account account = _accountDao.findById(accountId);
+ if (account == null) {
+ return;
+ }
+ String userName = getUserNameForAccount(account, storeId);
+ List<BucketVO> buckets =
_bucketDao.listByObjectStoreIdAndAccountId(storeId, accountId);
+ List<String> bucketNames = new ArrayList<>();
+ for (BucketVO bvo : buckets) {
+ if (excludeBucket != null && excludeBucket.equals(bvo.getName())) {
+ continue;
+ }
+ // Skip buckets whose remote counterpart has been deleted but whose
+ // row is still present for resource accounting. Including them
+ // would re-grant a bucket name that is now free for another
account
+ // to claim.
+ if (Bucket.State.Destroyed.equals(bvo.getState())) {
+ continue;
+ }
+ bucketNames.add(bvo.getName());
+ }
+ String policy =
SeaweedFSObjectStoreUtil.buildAccountIAMPolicy(bucketNames);
+ iamClient.putUserPolicy(new PutUserPolicyRequest(userName,
+ SeaweedFSObjectStoreUtil.IAM_USER_POLICY_NAME, policy));
+ }
+
+ /**
+ * Check whether the given access key id is still listed and Active in IAM
+ * for the user. Listing failures are propagated rather than swallowed so
+ * a transient IAM outage does not send createUser into the replacement
+ * path (which would overwrite stored credentials and invalidate bucket
+ * records).
+ */
+ private boolean iamAccessKeyExists(AmazonIdentityManagement iamClient,
String userName, String accessKeyId) {
+ for (AccessKeyMetadata metadata :
+ iamClient.listAccessKeys(new ListAccessKeysRequest()
+ .withUserName(userName)).getAccessKeyMetadata()) {
+ if (accessKeyId.equals(metadata.getAccessKeyId())) {
+ return "Active".equalsIgnoreCase(metadata.getStatus());
+ }
+ }
+ return false;
+ }
+
+ /**
+ * Delete access keys for the user other than the (optionally) preserved
+ * key id. Used to clean up unmanaged leftover keys before creating a
+ * replacement so repeated calls do not hit IAM access-key limits.
+ */
+ private void deleteUnmanagedAccessKeys(AmazonIdentityManagement iamClient,
String userName, String preserveAccessKeyId) {
+ try {
+ for (AccessKeyMetadata metadata :
+ iamClient.listAccessKeys(new ListAccessKeysRequest()
+ .withUserName(userName)).getAccessKeyMetadata()) {
+ String keyId = metadata.getAccessKeyId();
+ if (preserveAccessKeyId != null &&
preserveAccessKeyId.equals(keyId)) {
+ continue;
+ }
+ DeleteAccessKeyRequest deleteReq =
+ new DeleteAccessKeyRequest()
+ .withUserName(userName)
+ .withAccessKeyId(keyId);
+ logger.info("Deleting un-managed IAM access key {} for user
{}", keyId, userName);
+ iamClient.deleteAccessKey(deleteReq);
+ }
+ } catch (AmazonClientException e) {
+ // Propagate so the caller does not proceed to create a replacement
+ // key while stale unmanaged keys remain (which could hit IAM key
+ // limits or leave orphaned credentials).
+ throw new CloudRuntimeException("Failed to clean up IAM access
keys for user " + userName, e);
+ }
+ }
+
+ @Override
+ public Bucket createBucket(Bucket bucket, boolean objectLock) {
+ String bucketName = bucket.getName();
+ long storeId = bucket.getObjectStoreId();
+ long accountId = bucket.getAccountId();
+
+ // Use the store's admin credentials to create the bucket
+ AmazonS3 s3client = getS3ClientByStoreId(storeId);
+
+ // Check if the bucket already exists
+ try {
+ if (s3client.doesBucketExistV2(bucketName)) {
+ throw new CloudRuntimeException("Bucket already exists with
name " + bucketName);
+ }
+ } catch (AmazonClientException e) {
+ throw new CloudRuntimeException(e);
+ }
+
+ // Create the bucket
+ try {
+ CreateBucketRequest request = new CreateBucketRequest(bucketName);
+ if (objectLock) {
+ request.setObjectLockEnabledForBucket(true);
+ }
+ s3client.createBucket(request);
+ } catch (AmazonClientException e) {
+ logger.error("Create bucket failed", e);
+ throw new CloudRuntimeException(e);
+ }
+
+ // Step 2: update the bucket record with the account's IAM credentials,
+ // configure CORS, and refresh the IAM policy. If any of these fail,
+ // clean up the remote bucket so a retry does not find it already
+ // existing — mirroring the Cloudian createBucket pattern.
+ //
+ // Hold the IAM lock for the account so a concurrent createUser key
+ // rotation does not change the account credentials between reading
+ // them and writing the BucketVO, which would leave the bucket with
+ // a stale key pair.
+ GlobalLock iamLock = acquireIamLock(storeId, accountId);
+ if (iamLock == null) {
+ // The S3 bucket has already been created. Clean it up so a
+ // retry does not find it already existing, then throw.
+ try {
+ s3client.deleteBucket(bucketName);
+ } catch (AmazonClientException cleanupEx) {
+ logger.error("Failed to clean up bucket {} after IAM lock
timeout", bucketName, cleanupEx);
+ }
+ throw new CloudRuntimeException("Failed to acquire IAM lock for
store " + storeId + " account " + accountId);
+ }
+ try {
+ // Configure permissive CORS so the CloudStack S3 bucket browser
+ // (which performs list/upload/delete from the browser) can
function.
+ // SeaweedFS supports the standard PutBucketCors operation.
+ configureBucketCORS(s3client, bucketName);
+
+ Map<String, String> accountDetails =
_accountDetailsDao.findDetails(accountId);
+ String accessKey =
accountDetails.get(SeaweedFSObjectStoreUtil.keyAccessKey(storeId));
+ String secretKey =
accountDetails.get(SeaweedFSObjectStoreUtil.keySecretKey(storeId));
+ if (accessKey == null || secretKey == null) {
+ throw new CloudRuntimeException("No IAM credentials found for
account " + accountId
+ + " on store " + storeId + ". Run createUser before
creating a bucket.");
+ }
+
+ String s3Url = getS3Url(storeId);
+ BucketVO bucketVO = _bucketDao.findById(bucket.getId());
+ bucketVO.setAccessKey(accessKey);
+ bucketVO.setSecretKey(secretKey);
+ bucketVO.setBucketURL(s3Url + "/" + bucketName);
+ _bucketDao.update(bucket.getId(), bucketVO);
+
+ // Refresh the account's IAM policy to include the new bucket.
+ // Use the lock-free variant since createBucket already holds the
+ // IAM lock for the post-create section.
+ AmazonIdentityManagement iamClient = getIAMClient(storeId);
+ updateAccountIAMPolicyLocked(iamClient, storeId, accountId, null);
+
+ // Return the updated BucketVO (not the stale input bucket) so
+ // BucketApiServiceImpl.createBucket does not overwrite the
+ // persisted credentials with the stale values.
+ return bucketVO;
+ } catch (Exception e) {
+ logger.error("Post-create bucket record update failed for {};
cleaning up remote bucket", bucketName, e);
+ CloudRuntimeException primary = new CloudRuntimeException(e);
+ try {
+ s3client.deleteBucket(bucketName);
+ logger.info("Cleanup of bucket {} succeeded", bucketName);
+ } catch (AmazonClientException cleanupEx) {
+ logger.error("Cleanup of bucket {} also failed", bucketName,
cleanupEx);
+ primary.addSuppressed(cleanupEx);
+ }
+ // Revoke the IAM policy grant for the new bucket so the account's
+ // credentials cannot access a bucket that no longer exists. If the
+ // policy PUT succeeded before the DB update failed, the grant
+ // would otherwise persist and could be reused if another account
+ // later creates the same bucket name. Use the lock-free variant
+ // since createBucket already holds the IAM lock. Propagate
+ // failures as suppressed exceptions so they are not silently lost.
+ try {
+ AmazonIdentityManagement iamClient = getIAMClient(storeId);
+ updateAccountIAMPolicyLocked(iamClient, storeId, accountId,
bucketName);
+ } catch (Exception policyEx) {
+ logger.warn("Failed to revoke IAM policy for bucket {} after
cleanup: {}", bucketName, policyEx.getMessage());
+ primary.addSuppressed(policyEx);
+ }
+ throw primary;
+ } finally {
+ iamLock.unlock();
+ iamLock.releaseRef();
+ }
+ }
+
+ /**
+ * Configure a permissive CORS policy on the bucket so the CloudStack
+ * S3 bucket browser (which performs list/upload/delete from the
+ * browser) can function. Mirrors the Cloudian configureBucketCORS.
+ */
+ private void configureBucketCORS(AmazonS3 s3client, String bucketName) {
+ logger.debug("Configuring CORS for bucket {}", bucketName);
+ List<CORSRule> corsRules = new ArrayList<>();
+ CORSRule allowAnyRule = new CORSRule().withId("AllowAny");
+ allowAnyRule.setAllowedOrigins("*");
+ allowAnyRule.setAllowedHeaders("*");
+ allowAnyRule.setAllowedMethods(
+ CORSRule.AllowedMethods.HEAD,
+ CORSRule.AllowedMethods.GET,
+ CORSRule.AllowedMethods.PUT,
+ CORSRule.AllowedMethods.POST,
+ CORSRule.AllowedMethods.DELETE);
+ corsRules.add(allowAnyRule);
+ BucketCrossOriginConfiguration corsConfig = new
BucketCrossOriginConfiguration();
+ corsConfig.setRules(corsRules);
+ SetBucketCrossOriginConfigurationRequest corsRequest = new
SetBucketCrossOriginConfigurationRequest(bucketName, corsConfig);
+ s3client.setBucketCrossOriginConfiguration(corsRequest);
+ logger.info("Successfully configured CORS for bucket {}", bucketName);
+ }
+
+ @Override
+ public List<Bucket> listBuckets(long storeId) {
+ AmazonS3 s3client = getS3ClientByStoreId(storeId);
+ List<Bucket> bucketsList = new ArrayList<>();
+ try {
+ List<com.amazonaws.services.s3.model.Bucket> s3Buckets =
s3client.listBuckets();
+ for (com.amazonaws.services.s3.model.Bucket s3Bucket : s3Buckets) {
+ Bucket bucket = new BucketObject();
+ bucket.setName(s3Bucket.getName());
+ bucketsList.add(bucket);
+ }
+ } catch (AmazonClientException e) {
+ throw new CloudRuntimeException(e);
+ }
+ return bucketsList;
+ }
+
+ @Override
+ public boolean deleteBucket(BucketTO bucket, long storeId) {
+ String bucketName = bucket.getName();
+ long accountId = bucket.getAccountId();
+ AmazonS3 s3client = getS3ClientByStoreId(storeId);
+
+ // Acquire the per-store/account IAM lock so the S3 delete and the
+ // subsequent policy refresh are atomic with respect to concurrent
+ // createUser/createBucket operations. Without the lock, a concurrent
+ // policy rebuild could re-add the deleted bucket ARN between the
+ // excludeBucket refresh and BucketApiServiceImpl's row removal.
Review Comment:
Using a lock keyed by `(storeId, accountId)` does not make this sequence
atomic with another account. After this code deletes the globally named S3
bucket, account B can pass `doesBucketExistV2` and create the same name while
account A's policy still contains that ARN; until the later policy refresh
completes, A's credentials can access B's bucket. Serialize bucket-name reuse
and policy refresh with a store-wide (or bucket-name) lock, including the
create path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
