Damans227 commented on code in PR #14132:
URL: https://github.com/apache/cloudstack/pull/14132#discussion_r4168153052
##########
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java:
##########
@@ -450,6 +450,7 @@ public AsyncCallFuture<VolumeApiResult>
expungeVolumeAsync(VolumeInfo volume) {
future.complete(result);
return future;
}
+ deletePrimaryOnlySnapshotsBeforeRbdVolumeDelete(vol);
Review Comment:
what happens if the volume delete fails after this? looks like the snapshots
are already gone by then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
