Damans227 commented on code in PR #14282:
URL: https://github.com/apache/cloudstack/pull/14282#discussion_r4205514303
##########
server/src/main/java/com/cloud/network/NetworkModelImpl.java:
##########
@@ -2743,7 +2743,8 @@ public ConfigKey<?>[] getConfigKeys() {
@Override
public String getValidNetworkCidr(Network guestNetwork) {
String networkCidr = guestNetwork.getNetworkCidr();
- return networkCidr == null ? guestNetwork.getCidr() : networkCidr;
+ String cidr = networkCidr == null ? guestNetwork.getCidr() :
networkCidr;
+ return
com.cloud.utils.StringUtils.getFirstValueFromCommaSeparatedString(cidr);
Review Comment:
makes sense, the router only got the first range before 4.22 too. can we
test a vm on the second range after a network restart with cleanup, to check it
still gets its ip?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
