Damans227 commented on code in PR #14262:
URL: https://github.com/apache/cloudstack/pull/14262#discussion_r4259262701


##########
ui/src/views/storage/ResizeVolume.vue:
##########
@@ -105,14 +103,23 @@ export default {
     },
     fetchData () {
       this.loading = true
+      if (this.resource.size != null) {
+        this.form.size = this.resource.size / (1024 * 1024 * 1024)

Review Comment:
   what happens when the volume isnt a whole number of gb, like a root disk 
from a 2.2 gb template? resize only takes whole numbers so hitting ok without 
touching the size looks like it fails



##########
ui/src/views/storage/ResizeVolume.vue:
##########
@@ -105,14 +103,23 @@ export default {
     },
     fetchData () {
       this.loading = true
+      if (this.resource.size != null) {
+        this.form.size = this.resource.size / (1024 * 1024 * 1024)
+      }
+      if (!this.resource.diskofferingid) {
+        this.loading = false
+        return
+      }
       getAPI('listDiskOfferings', {

Review Comment:
   does this find the offering for a root disk? listing disk offerings skips 
the ones that belong to a compute offering, so the iops fields wont show there



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to