rajiv-jain-netapp commented on code in PR #14262:
URL: https://github.com/apache/cloudstack/pull/14262#discussion_r4322093274
##########
ui/src/views/storage/ResizeVolume.vue:
##########
@@ -105,14 +103,23 @@ export default {
},
fetchData () {
this.loading = true
+ if (this.resource.size != null) {
+ this.form.size = this.resource.size / (1024 * 1024 * 1024)
Review Comment:
@Damans227 This is a very good observation for this particular use case. Had
we represented the size fields consistently in bytes instead of displaying GB
values in some places, it would have made it much easier to identify and
address the issue effectively.
The current fix helps streamline the behaviour for the remaining scenarios
where the size values are whole numbers rather than fractional values. However,
the behaviour is still not fully correct even today. For example, if a user
navigates to this screen and attempts to modify only the IOPS without providing
a size value, the operation can still fail or behave unexpectedly.
What would you recommend as a more holistic solution to address this
behaviour and ensure consistent handling across all size-related scenarios?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
