suryag1201 commented on code in PR #14262:
URL: https://github.com/apache/cloudstack/pull/14262#discussion_r4425702024


##########
ui/src/views/storage/ResizeVolume.vue:
##########
@@ -105,14 +103,23 @@ export default {
     },
     fetchData () {
       this.loading = true
+      if (this.resource.size != null) {
+        this.form.size = this.resource.size / (1024 * 1024 * 1024)
+      }
+      if (!this.resource.diskofferingid) {
+        this.loading = false
+        return
+      }
       getAPI('listDiskOfferings', {

Review Comment:
   Good catch, @Damans227 . I have made the code changes.
   A root volume created from a compute offering also comes back with 
serviceofferingid instead of diskofferingid. The resize form used to stop when 
diskofferingid was missing, so the Min and Max IOPS fields were never shown for 
that root disk.
   The resize form no longer calls listDiskOfferings. The volume response now 
includes iscustomizediops from the volume's disk offering, including a 
compute-only offering. When that flag is true, the form shows the Min and Max 
IOPS fields and prefills them from the volume.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to