mike-tutkowski commented on a change in pull request #2298: CLOUDSTACK-9620:
Enhancements for managed storage
URL: https://github.com/apache/cloudstack/pull/2298#discussion_r159561817
##########
File path:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##########
@@ -226,10 +310,12 @@ public void copyAsync(DataObject srcData, DataObject
destData, Host destHost, As
if (canHandleSrc) {
String errMsg = "This operation is not supported
(DataStoreCapabilities.STORAGE_SYSTEM_SNAPSHOT " +
- "not supported by source storage plug-in). " +
getSrcDataStoreMsg(srcData);
+ "not supported by source storage plug-in). " +
getDestDataStoreMsg(destData);
Review comment:
I can add a comment. Basically, there are three if statements in a row. The
first one covers 'if (canHandleSrc && canHandleDest)'. The second one covers
'if (canHandleDest)' (so, at this point, you know that both canHandleSrc &&
canHandleDest can't resolve to true). The final one is 'if (canHandleSrc)' (so,
we are saying that our storage plug-in can handle the source side, but not the
destination side, which is a problem).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
