mike-tutkowski commented on a change in pull request #2298: CLOUDSTACK-9620:
Enhancements for managed storage
URL: https://github.com/apache/cloudstack/pull/2298#discussion_r159563869
##########
File path: core/src/com/cloud/agent/api/StartAnswer.java
##########
@@ -24,9 +24,12 @@
import com.cloud.agent.api.to.VirtualMachineTO;
public class StartAnswer extends Answer {
+ public static final String PATH = "path";
+ public static final String IMAGE_FORMAT = "imageFormat";
+
VirtualMachineTO vm;
String hostGuid;
- Map<String, String> _iqnToPath;
+ private Map<String, Map<String, String>> _iqnToData;
Review comment:
With regards to multiple PRs: Originally I had it that way (VMware in one
PR, KVM in another, and XenServer in a third). Unfortunately, since 4.10 took a
very long to to come out, it became a big pain to constantly rebase and
maintain all of those PRs. As such, I merged the code into this one to simplify
PR maintenance and to minimize the chances of making mistakes with rebasing due
to having to perform that action so many times (and having to make so many
manual merge fixes along the way). At this point, I think it's safest to stay
with this one, large PR.
Feel free to provide your code style and maintainability suggestions. I'm
happy to hear what you have to say.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
