mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355686048 As an example: boolean canHandleSrc = canHandle(srcSnapshotInfo); if (canHandleSrc) { if (srcSnapshotInfo.getDataStore().getId() == destVolumeInfo.getDataStore().getId()) { handleCreateVolumeFromSnapshotBothOnStorageSystem(srcSnapshotInfo, destVolumeInfo, callback); } else { String errMsg = "To perform this operation, the source and destination primary storages must be the same."; handleError(errMsg, callback); } In this case, canHandle returns true because srcSnapshotInfo's storage driver does support certain features for snapshots. However, the canHandle method doesn't know if the destination volume (that we want to copy our snapshot to) is in the same primary storage or not. As it turns out, right now we only support this operation if the two objects (the snapshot and volume) are in the same storage pool. It might come down to the naming of canHandle is a bit vague.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
