rafaelweingartner commented on a change in pull request #3133: feature: add
libvirt / qemu io bursting
URL: https://github.com/apache/cloudstack/pull/3133#discussion_r248617924
##########
File path:
api/src/main/java/org/apache/cloudstack/api/response/DiskOfferingResponse.java
##########
@@ -253,15 +285,31 @@ public void setBytesReadRate(Long bytesReadRate) {
this.bytesReadRate = bytesReadRate;
}
+ public void setBytesReadRateMax(Long bytesReadRateMax) {
this.bytesReadRateMax = bytesReadRateMax; }
+
+ public void setBytesReadRateMaxLength(Long bytesReadRateMaxLength) {
this.bytesReadRateMaxLength = bytesReadRateMaxLength; }
+
public void setBytesWriteRate(Long bytesWriteRate) {
this.bytesWriteRate = bytesWriteRate;
}
+ public void setBytesWriteRateMax(Long bytesWriteRateMax) {
this.bytesWriteRateMax = bytesWriteRateMax; }
+
+ public void setBytesWriteRateMaxLength(Long bytesWriteRateMaxLength) {
this.bytesWriteRateMaxLength = bytesWriteRateMaxLength; }
+
public void setIopsReadRate(Long iopsReadRate) {
this.iopsReadRate = iopsReadRate;
}
+ public void setIopsReadRateMax(Long iopsReadRateMax) {
this.iopsReadRateMax = iopsReadRateMax; }
Review comment:
Have you seen this [1]?
And these are the style for code formatter for Eclipse [2], and Intellij [3].
[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions
[2]
https://cwiki.apache.org/confluence/download/attachments/29687985/ApacheCloudStack.xml?version=1&modificationDate=1382960469000&api=v2
[3] Use the Eclipse Code Formatter plugin and the setting from the above
eclipse xml file ApacheCloudStack.xml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
