rafaelweingartner commented on a change in pull request #3133: feature: add
libvirt / qemu io bursting
URL: https://github.com/apache/cloudstack/pull/3133#discussion_r248898572
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -2390,15 +2390,40 @@ public int compare(final DiskTO arg0, final DiskTO
arg1) {
if (volumeObjectTO.getBytesReadRate() != null &&
volumeObjectTO.getBytesReadRate() > 0) {
Review comment:
> why?
In addition to what @GabrielBrascher said, I have probably replied to people
demonstrating technical arguments of shorter, well documented, and unit tested
methods; and that we need to start this movement, otherwise things get worse,
and worse... We have classes with thousands of lines, and that is very
unhealthy in the long run.
I am starting to think that I might be the mistaken one. So, I think it is
time for me to do the opposite then, I might learn something. Why replicate
code around our code base? I mean, what are the technical benefits of
replicating code, and not unit testing and documenting them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
