DaanHoogland commented on a change in pull request #3186: Add possibility to 
set KVM MTU size for NIC
URL: https://github.com/apache/cloudstack/pull/3186#discussion_r270344571
 
 

 ##########
 File path: 
api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateVmNicIpMtuCmd.java
 ##########
 @@ -101,11 +105,18 @@ public Long getNicId() {
     }
 
     public String getIpaddress () {
-        if (ipAddr != null) {
-            return ipAddr;
-        } else {
+        if (Strings.isNullOrEmpty(ipAddr)) {
             return null;
         }
+        return ipAddr;
+    }
+
+    public int getMtu () {
 
 Review comment:
   just retrun mtu will do, unless you are meaning to check for mtu <= 0 or 
something else.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to