DaanHoogland commented on a change in pull request #3186: Add possibility to
set KVM MTU size for NIC
URL: https://github.com/apache/cloudstack/pull/3186#discussion_r270344217
##########
File path:
api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateVmNicIpMtuCmd.java
##########
@@ -46,9 +28,27 @@
import com.cloud.uservm.UserVm;
import com.cloud.utils.net.NetUtils;
import com.cloud.vm.Nic;
+import com.google.common.base.Strings;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiArgValidator;
+import org.apache.cloudstack.api.ApiCommandJobType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiConstants.VMDetails;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.NicResponse;
+import org.apache.cloudstack.api.response.UserVmResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.log4j.Logger;
-@APICommand(name = "updateVmNicIp", description = "Update the default Ip of a
VM Nic", responseObject = UserVmResponse.class)
-public class UpdateVmNicIpCmd extends BaseAsyncCmd {
+import java.util.ArrayList;
+import java.util.EnumSet;
+
+@APICommand(name = "updateVmNicIpMtu", description = "Update the default Ip
and MTU of a VM Nic", responseObject = UserVmResponse.class)
Review comment:
rename of a public API is a big no-no. it breaks backwards compatibility. if
the extra parameter is optional, you can just add it, else create an extra API,
please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
