syed commented on a change in pull request #3346: Fix template size for managed
storage / refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3346#discussion_r286607621
##########
File path: scripts/storage/secondary/cloud-install-sys-tmplt
##########
@@ -20,19 +19,30 @@
usage() {
- printf "Usage: %s: -m <secondary storage mount point> -f <system vm template
file> [-h <hypervisor name: kvm|vmware|xenserver|hyperv|ovm3> ] [ -s <mgmt
server secret key, if you specified any when running cloudstack-setup-database,
default is password>][-u <Url to system vm template>] [-F <clean up system
templates of specified hypervisor>] [-e <Template suffix, e.g vhd, ova, qcow2>]
[-o <Database server hostname or ip, e.g localhost>] [-r <Database user name,
e.g root>] [-p <mysql database port>] [-d <Database password. Fllowed by
nothing if the password is empty>]\n" $(basename $0) >&2
- printf "or\n" >&2
- printf "%s: -m <secondary storage mount point> -u <http url for system vm
template> [-h <hypervisor name: kvm|vmware|xenserver|hyperv|ovm3> ] [ -s <mgmt
server secret key>]\n" $(basename $0) >&2
+ printf "\nUsage: %s:\n\t-m secondary storage mount point\n\t-f system vm
template file\n\t-h hypervisor name: kvm|vmware|xenserver|hyperv|ovm3\n\t-s
mgmt server secret key, if you specified any when running
cloudstack-setup-database, default is password\n\t-u Url to system vm
template\n\t-F clean up system templates of specified hypervisor\n\t-e Template
suffix, e.g vhd, ova, qcow2\n\t-o Database server hostname or ip, e.g
localhost\n\t-r Database user name, e.g root\n\t-p mysql database port\n\t-d
Database password. Followed by nothing if the password is empty\n\t-H with
hvm\n\n" $(basename $0) >&2
+ printf "\tor\n"
+ printf "\nUsage: %s:\n\t-m secondary storage mount point\n\t-u http url for
system vm template\n\t-h hypervisor name:
kvm|vmware|xenserver|hyperv|ovm3\n\t-s mgmt server secret key\n\n" $(basename
$0) >&2
}
failed() {
- echo "Installation failed"
- exit $1
+ if [[ -z $2 ]]; then
+ :
+ else
+ echo -e $2
Review comment:
Could you explain the logic here? Perhaps adding a comment will help, or
renaming `$2` to a more descriptive variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
