GabrielBrascher commented on a change in pull request #3186: Add possibility to
set KVM MTU size for all NIC
URL: https://github.com/apache/cloudstack/pull/3186#discussion_r346624532
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -1054,7 +1061,7 @@ public void validateCustomParameters(ServiceOfferingVO
serviceOffering, Map<Stri
if (serviceOffering.getSpeed() == null) {
String cpuSpeed =
customParameters.get(UsageEventVO.DynamicParameters.cpuSpeed.name());
- if ((cpuSpeed == null) || (NumbersUtil.parseInt(cpuSpeed, -1)
<= 0)) {
+ if ((cpuSpeed == null) || (parseInt(cpuSpeed, -1) <= 0)) {
Review comment:
Could you please update the `cpuSpeed == null` check to
`StringUtils.isNotBlank(cpuSpeed)`?
The `lang3.StringUtils.isNotBlank(CharSequence cs)` checks if a CharSequence
is not empty (""), not null and not whitespace only.
```
StringUtils.isNotBlank(null) = false
StringUtils.isNotBlank("") = false
StringUtils.isNotBlank(" ") = false
StringUtils.isNotBlank("bob") = true
StringUtils.isNotBlank(" bob ") = true
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
