GabrielBrascher commented on a change in pull request #3186: Add possibility to 
set KVM MTU size for all NIC
URL: https://github.com/apache/cloudstack/pull/3186#discussion_r346625196
 
 

 ##########
 File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
 ##########
 @@ -2083,31 +2090,41 @@ public boolean configure(String name, Map<String, 
Object> params) throws Configu
 
         Map<String, String> configs = 
_configDao.getConfiguration("AgentManager", params);
 
-        _kvmMtuSize = NumbersUtil.parseInt(_configDao.getValue(KVM_MTU_KEY), 
0);
+        final List<ClusterVO> clusterVOs = 
_clusterDao.listByHypervisorAndCluster(HypervisorType.KVM, 
Cluster.ClusterType.CloudManaged);
+
+        if ((clusterVOs != null) && !clusterVOs.isEmpty()) {
 
 Review comment:
   CollectionUtils.isEmpty(clusterVOs) would be nice here 
:slightly_smiling_face:  :+1: 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to