andrijapanicsb commented on issue #3721: network: cleanup dhcp/dns entries while remove a nic from vm URL: https://github.com/apache/cloudstack/pull/3721#issuecomment-569210824 > Simple change regarding moving code from `cleanupNics` to `removeNic`; I don't see any potential issue with that. > > Based on code review, LGTM. @weizhouapache this should not affect the previos fix you did, cleaning dhcp/dns when VM is expunged, right? About to test this one, thanks.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
