rhtyd commented on a change in pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#discussion_r422977886
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
##########
@@ -144,6 +148,14 @@ Use VIR_DOMAIN_XML_SECURE (value = 1) prior to v1.0.0.
// delete the metadata of vm snapshots before migration
vmsnapshots = libvirtComputingResource.cleanVMSnapshotMetadata(dm);
+ // Verify Format of backing file
+ for (DiskDef disk : disks) {
+ if (disk.getDeviceType() == DiskDef.DeviceType.DISK
Review comment:
Could this break on older CentOS/Ubuntu KVM hosts where the backfile is
not supported?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
