rhtyd commented on a change in pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#discussion_r422978904
##########
File path:
plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java
##########
@@ -149,6 +149,8 @@ public void create(final QemuImgFile file, final
QemuImgFile backingFile, final
*/
s.add("-f");
if (backingFile != null) {
+ s.add(backingFile.getFormat().toString());
+ s.add("-F");
Review comment:
@weizhouapache I checked libvirtd release notes, libvirt doesn't fail VM
for version 5.x or below; only libvirt starting version 6.x fails VM deployment
if backing file format is not provided. Should we add a check, as the `-F`
option is not available for qemu-img on older distros, say CentOS7, or Ubuntu
16.04 (I didn't check 18.04). Unless we want to discuss and deprecate Ubuntu
16.04 support? cc @wido @GabrielBrascher @shwstppr @davidjumani
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
