ustcweizhou opened a new pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020


   ## Description
   <!--- Describe your changes in detail -->
   
   While remove secondary nic from a Running vm, if update the default nic to 
the secondary nic before the nic is removed, the vm will not have default nic 
(and cannot be started) when both operations are completed.
   
   It is because UpdateDefaultNic api is not handled as a vm work job 
(AddNicToVMCmd and RemoveNicFromVMCmd are), it is processed before nic is 
removed. The result is that secondary nic becomes default nic and got removed.
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to 
reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be 
closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the 
boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to 
-->
   <!-- see how your change affects other areas of the code, etc. -->
   
   1. remove secondary nic from a Running vm
   2. update default nic to the secondary nic before step 1 is finished.
   3. got an exception  as below.
   
   
![image](https://user-images.githubusercontent.com/3204966/78604196-b5753000-7859-11ea-9758-644fffc20a9b.png)
   
   <!-- Please read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to