DaanHoogland commented on a change in pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#discussion_r463546704
##########
File path: utils/src/test/java/com/cloud/utils/HumanReadableJsonTest.java
##########
@@ -50,4 +51,14 @@ public void parseMatchJsonTest() {
assertEquals("[{\"size\":\"(0 bytes) 0\"}]",
getHumanReadableBytesJson("[{\"size\": \"0\"}]"));
assertEquals("[{\"size\":\"(0 bytes) 0\",\"bytesSent\":\"(0 bytes)
0\"}]", getHumanReadableBytesJson("[{\"size\": \"0\", \"bytesSent\": \"0\"}]"));
}
+
+ @Test
+ public void localeTest() {
+ Locale.setDefault(Locale.UK); // UK test
Review comment:
I think "C" is the default locale. maybe this or some other more worldly
locale is a good idea?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]