Spaceman1984 commented on a change in pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#discussion_r464909158
##########
File path: utils/src/test/java/com/cloud/utils/HumanReadableJsonTest.java
##########
@@ -50,4 +51,14 @@ public void parseMatchJsonTest() {
assertEquals("[{\"size\":\"(0 bytes) 0\"}]",
getHumanReadableBytesJson("[{\"size\": \"0\"}]"));
assertEquals("[{\"size\":\"(0 bytes) 0\",\"bytesSent\":\"(0 bytes)
0\"}]", getHumanReadableBytesJson("[{\"size\": \"0\", \"bytesSent\": \"0\"}]"));
}
+
+ @Test
+ public void localeTest() {
+ Locale.setDefault(Locale.UK); // UK test
Review comment:
@DaanHoogland I searched the code base, Cloudstack doesn't set a default
locale, it will be picked up from the environment, which I believe is the
correct behaviour.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
