This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git


The following commit(s) were added to refs/heads/master by this push:
     new 8b982a6c Throw a RuntimeException subclass instead of RuntimeException
8b982a6c is described below

commit 8b982a6ca59562a3ba5e480d07cf20f1d6835195
Author: Gary David Gregory (Code signing key) <ggreg...@apache.org>
AuthorDate: Thu Jul 6 17:01:34 2023 -0400

    Throw a RuntimeException subclass instead of RuntimeException
    
    Throw UnsupportedOperationException instead of Error when clone() is not
    supported
---
 src/main/java/org/apache/bcel/classfile/Attribute.java         | 2 +-
 src/main/java/org/apache/bcel/classfile/Constant.java          | 2 +-
 src/main/java/org/apache/bcel/classfile/FieldOrMethod.java     | 2 +-
 src/main/java/org/apache/bcel/classfile/StackMapEntry.java     | 2 +-
 src/main/java/org/apache/bcel/generic/ClassGen.java            | 2 +-
 src/main/java/org/apache/bcel/generic/CodeExceptionGen.java    | 2 +-
 src/main/java/org/apache/bcel/generic/FieldGenOrMethodGen.java | 2 +-
 src/main/java/org/apache/bcel/generic/LineNumberGen.java       | 2 +-
 src/main/java/org/apache/bcel/generic/LocalVariableGen.java    | 2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/main/java/org/apache/bcel/classfile/Attribute.java 
b/src/main/java/org/apache/bcel/classfile/Attribute.java
index 69168e2a..42510a9a 100644
--- a/src/main/java/org/apache/bcel/classfile/Attribute.java
+++ b/src/main/java/org/apache/bcel/classfile/Attribute.java
@@ -289,7 +289,7 @@ public abstract class Attribute implements Cloneable, Node {
         try {
             attr = (Attribute) super.clone();
         } catch (final CloneNotSupportedException e) {
-            throw new Error("Clone Not Supported"); // never happens
+            throw new UnsupportedOperationException("Clone Not Supported", e); 
// never happens
         }
         return attr;
     }
diff --git a/src/main/java/org/apache/bcel/classfile/Constant.java 
b/src/main/java/org/apache/bcel/classfile/Constant.java
index c1bcbcc0..a70400cd 100644
--- a/src/main/java/org/apache/bcel/classfile/Constant.java
+++ b/src/main/java/org/apache/bcel/classfile/Constant.java
@@ -142,7 +142,7 @@ public abstract class Constant implements Cloneable, Node {
         try {
             return super.clone();
         } catch (final CloneNotSupportedException e) {
-            throw new Error("Clone Not Supported"); // never happens
+            throw new UnsupportedOperationException("Clone Not Supported", e); 
// never happens
         }
     }
 
diff --git a/src/main/java/org/apache/bcel/classfile/FieldOrMethod.java 
b/src/main/java/org/apache/bcel/classfile/FieldOrMethod.java
index f148cb46..5f43536f 100644
--- a/src/main/java/org/apache/bcel/classfile/FieldOrMethod.java
+++ b/src/main/java/org/apache/bcel/classfile/FieldOrMethod.java
@@ -132,7 +132,7 @@ public abstract class FieldOrMethod extends AccessFlags 
implements Cloneable, No
             Arrays.setAll(c.attributes, i -> attributes[i].copy(constantPool));
             return c;
         } catch (final CloneNotSupportedException e) {
-            throw new IllegalStateException(e);
+            throw new UnsupportedOperationException(e);
         }
     }
 
diff --git a/src/main/java/org/apache/bcel/classfile/StackMapEntry.java 
b/src/main/java/org/apache/bcel/classfile/StackMapEntry.java
index 0eed5838..8b78543e 100644
--- a/src/main/java/org/apache/bcel/classfile/StackMapEntry.java
+++ b/src/main/java/org/apache/bcel/classfile/StackMapEntry.java
@@ -163,7 +163,7 @@ public final class StackMapEntry implements Node, Cloneable 
{
         try {
             e = (StackMapEntry) clone();
         } catch (final CloneNotSupportedException ex) {
-            throw new Error("Clone Not Supported");
+            throw new UnsupportedOperationException("Clone Not Supported", ex);
         }
 
         e.typesOfLocals = new StackMapType[typesOfLocals.length];
diff --git a/src/main/java/org/apache/bcel/generic/ClassGen.java 
b/src/main/java/org/apache/bcel/generic/ClassGen.java
index 47530c40..dbc61d18 100644
--- a/src/main/java/org/apache/bcel/generic/ClassGen.java
+++ b/src/main/java/org/apache/bcel/generic/ClassGen.java
@@ -239,7 +239,7 @@ public class ClassGen extends AccessFlags implements 
Cloneable {
         try {
             return super.clone();
         } catch (final CloneNotSupportedException e) {
-            throw new Error("Clone Not Supported"); // never happens
+            throw new UnsupportedOperationException("Clone Not Supported", e); 
// never happens
         }
     }
 
diff --git a/src/main/java/org/apache/bcel/generic/CodeExceptionGen.java 
b/src/main/java/org/apache/bcel/generic/CodeExceptionGen.java
index 6d22a907..1320622f 100644
--- a/src/main/java/org/apache/bcel/generic/CodeExceptionGen.java
+++ b/src/main/java/org/apache/bcel/generic/CodeExceptionGen.java
@@ -59,7 +59,7 @@ public final class CodeExceptionGen implements 
InstructionTargeter, Cloneable {
         try {
             return super.clone();
         } catch (final CloneNotSupportedException e) {
-            throw new Error("Clone Not Supported"); // never happens
+            throw new UnsupportedOperationException("Clone Not Supported", e); 
// never happens
         }
     }
 
diff --git a/src/main/java/org/apache/bcel/generic/FieldGenOrMethodGen.java 
b/src/main/java/org/apache/bcel/generic/FieldGenOrMethodGen.java
index 4c53e14a..9f6c5b2d 100644
--- a/src/main/java/org/apache/bcel/generic/FieldGenOrMethodGen.java
+++ b/src/main/java/org/apache/bcel/generic/FieldGenOrMethodGen.java
@@ -88,7 +88,7 @@ public abstract class FieldGenOrMethodGen extends AccessFlags 
implements NamedAn
         try {
             return super.clone();
         } catch (final CloneNotSupportedException e) {
-            throw new Error("Clone Not Supported"); // never happens
+            throw new UnsupportedOperationException("Clone Not Supported", e); 
// never happens
         }
     }
 
diff --git a/src/main/java/org/apache/bcel/generic/LineNumberGen.java 
b/src/main/java/org/apache/bcel/generic/LineNumberGen.java
index f9758cbd..d267f115 100644
--- a/src/main/java/org/apache/bcel/generic/LineNumberGen.java
+++ b/src/main/java/org/apache/bcel/generic/LineNumberGen.java
@@ -49,7 +49,7 @@ public class LineNumberGen implements InstructionTargeter, 
Cloneable {
         try {
             return super.clone();
         } catch (final CloneNotSupportedException e) {
-            throw new Error("Clone Not Supported"); // never happens
+            throw new UnsupportedOperationException("Clone Not Supported", e); 
// never happens
         }
     }
 
diff --git a/src/main/java/org/apache/bcel/generic/LocalVariableGen.java 
b/src/main/java/org/apache/bcel/generic/LocalVariableGen.java
index e42b96ef..45418d23 100644
--- a/src/main/java/org/apache/bcel/generic/LocalVariableGen.java
+++ b/src/main/java/org/apache/bcel/generic/LocalVariableGen.java
@@ -81,7 +81,7 @@ public class LocalVariableGen implements InstructionTargeter, 
NamedAndTyped, Clo
         try {
             return super.clone();
         } catch (final CloneNotSupportedException e) {
-            throw new Error("Clone Not Supported"); // never happens
+            throw new UnsupportedOperationException("Clone Not Supported", e); 
// never happens
         }
     }
 

Reply via email to