This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git


The following commit(s) were added to refs/heads/master by this push:
     new c1381bb7 Bulletproof tests
c1381bb7 is described below

commit c1381bb759f694294ed3bbdbeec8c95b9cdad8f2
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Wed Jul 19 12:09:57 2023 -0400

    Bulletproof tests
---
 .../java/org/apache/commons/net/tftp/TFTPServerPathTest.java   | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/test/java/org/apache/commons/net/tftp/TFTPServerPathTest.java 
b/src/test/java/org/apache/commons/net/tftp/TFTPServerPathTest.java
index 7d92f168..cd39fd5b 100644
--- a/src/test/java/org/apache/commons/net/tftp/TFTPServerPathTest.java
+++ b/src/test/java/org/apache/commons/net/tftp/TFTPServerPathTest.java
@@ -77,9 +77,8 @@ public class TFTPServerPathTest {
                 tftp.setSoTimeout(2000);
 
                 try {
-                    // cleanup old failed runs
-                    final boolean deleted = out.delete();
-                    assertFalse(out.exists(), () -> "Couldn't clear output 
location, deleted=" + deleted);
+                    // check old failed runs
+                    assertFalse(out.exists(), () -> "Couldn't clear output 
location, deleted=");
 
                     try (final FileOutputStream output = new 
FileOutputStream(out)) {
                         tftp.receiveFile(file.getName(), TFTP.BINARY_MODE, 
output, "localhost", SERVER_PORT);
@@ -114,9 +113,8 @@ public class TFTPServerPathTest {
                 tftp.setSoTimeout(2000);
 
                 try {
-                    // cleanup old failed runs
-                    final boolean deleted = out.delete();
-                    assertFalse(out.exists(), () -> "Couldn't clear output 
location, deleted=" + deleted);
+                    // check old failed runs
+                    assertFalse(out.exists(), () -> "Couldn't clear output 
location, deleted=");
 
                     try (final FileOutputStream output = new 
FileOutputStream(out)) {
                         tftp.receiveFile(file.getName(), TFTP.BINARY_MODE, 
output, "localhost", SERVER_PORT);

Reply via email to