This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-net.git
The following commit(s) were added to refs/heads/master by this push: new c1e77b1b Normalize internal names c1e77b1b is described below commit c1e77b1b3812d72d7bbb9d6a5382ce57b6c816f4 Author: Gary Gregory <garydgreg...@gmail.com> AuthorDate: Wed Jul 19 16:09:22 2023 -0400 Normalize internal names --- .../java/org/apache/commons/net/imap/AuthenticatingIMAPClient.java | 6 +++--- src/main/java/org/apache/commons/net/pop3/ExtendedPOP3Client.java | 6 +++--- .../java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/main/java/org/apache/commons/net/imap/AuthenticatingIMAPClient.java b/src/main/java/org/apache/commons/net/imap/AuthenticatingIMAPClient.java index 20d54208..cf384b1b 100644 --- a/src/main/java/org/apache/commons/net/imap/AuthenticatingIMAPClient.java +++ b/src/main/java/org/apache/commons/net/imap/AuthenticatingIMAPClient.java @@ -161,10 +161,10 @@ public class AuthenticatingIMAPClient extends IMAPSClient { // get the CRAM challenge (after "+ ") final byte[] serverChallenge = Base64.decodeBase64(getReplyString().substring(2).trim()); // get the Mac instance - final Mac hmac_md5 = Mac.getInstance("HmacMD5"); - hmac_md5.init(new SecretKeySpec(password.getBytes(getCharset()), "HmacMD5")); + final Mac hmacMd5 = Mac.getInstance("HmacMD5"); + hmacMd5.init(new SecretKeySpec(password.getBytes(getCharset()), "HmacMD5")); // compute the result: - final byte[] hmacResult = convertToHexString(hmac_md5.doFinal(serverChallenge)).getBytes(getCharset()); + final byte[] hmacResult = convertToHexString(hmacMd5.doFinal(serverChallenge)).getBytes(getCharset()); // join the byte arrays to form the reply final byte[] usernameBytes = username.getBytes(getCharset()); final byte[] toEncode = new byte[usernameBytes.length + 1 /* the space */ + hmacResult.length]; diff --git a/src/main/java/org/apache/commons/net/pop3/ExtendedPOP3Client.java b/src/main/java/org/apache/commons/net/pop3/ExtendedPOP3Client.java index 79600dff..94632ee2 100644 --- a/src/main/java/org/apache/commons/net/pop3/ExtendedPOP3Client.java +++ b/src/main/java/org/apache/commons/net/pop3/ExtendedPOP3Client.java @@ -95,10 +95,10 @@ public class ExtendedPOP3Client extends POP3SClient { // get the CRAM challenge final byte[] serverChallenge = Base64.decodeBase64(getReplyString().substring(2).trim()); // get the Mac instance - final Mac hmac_md5 = Mac.getInstance("HmacMD5"); - hmac_md5.init(new SecretKeySpec(password.getBytes(getCharset()), "HmacMD5")); + final Mac hmacMd5 = Mac.getInstance("HmacMD5"); + hmacMd5.init(new SecretKeySpec(password.getBytes(getCharset()), "HmacMD5")); // compute the result: - final byte[] hmacResult = convertToHexString(hmac_md5.doFinal(serverChallenge)).getBytes(getCharset()); + final byte[] hmacResult = convertToHexString(hmacMd5.doFinal(serverChallenge)).getBytes(getCharset()); // join the byte arrays to form the reply final byte[] usernameBytes = username.getBytes(getCharset()); final byte[] toEncode = new byte[usernameBytes.length + 1 /* the space */ + hmacResult.length]; diff --git a/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java b/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java index 73c34d3c..9148cc69 100644 --- a/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java +++ b/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java @@ -170,10 +170,10 @@ public class AuthenticatingSMTPClient extends SMTPSClient { // get the CRAM challenge final byte[] serverChallenge = Base64.decodeBase64(getReplyString().substring(4).trim()); // get the Mac instance - final Mac hmac_md5 = Mac.getInstance("HmacMD5"); - hmac_md5.init(new SecretKeySpec(password.getBytes(getCharset()), "HmacMD5")); + final Mac hmacMd5 = Mac.getInstance("HmacMD5"); + hmacMd5.init(new SecretKeySpec(password.getBytes(getCharset()), "HmacMD5")); // compute the result: - final byte[] hmacResult = convertToHexString(hmac_md5.doFinal(serverChallenge)).getBytes(getCharset()); + final byte[] hmacResult = convertToHexString(hmacMd5.doFinal(serverChallenge)).getBytes(getCharset()); // join the byte arrays to form the reply final byte[] usernameBytes = username.getBytes(getCharset()); final byte[] toEncode = new byte[usernameBytes.length + 1 /* the space */ + hmacResult.length];