[commons-exec] branch master updated: Better JUnit API usage

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-exec.git


The following commit(s) were added to refs/heads/master by this push:
     new 7303673  Better JUnit API usage
7303673 is described below

commit 7303673b065892b792876e92171f890cabf37462
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Aug 5 16:02:45 2023 -0400

    Better JUnit API usage
---
 src/test/java/org/apache/commons/exec/DefaultExecutorTest.java |  8 ++++----
 src/test/java/org/apache/commons/exec/util/MapUtilTest.java    | 10 +++++-----
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/test/java/org/apache/commons/exec/DefaultExecutorTest.java 
b/src/test/java/org/apache/commons/exec/DefaultExecutorTest.java
index b17e810..ff1b286 100644
--- a/src/test/java/org/apache/commons/exec/DefaultExecutorTest.java
+++ b/src/test/java/org/apache/commons/exec/DefaultExecutorTest.java
@@ -491,14 +491,14 @@ public class DefaultExecutorTest {
       exec.setProcessDestroyer(processDestroyer);
 
       assertTrue(processDestroyer.isEmpty());
-      assertTrue(processDestroyer.isAddedAsShutdownHook() == false);
+      assertFalse(processDestroyer.isAddedAsShutdownHook());
 
       final int exitValue = exec.execute(cl);
 
       assertEquals("FOO..", baos.toString().trim());
       assertFalse(exec.isFailure(exitValue));
       assertTrue(processDestroyer.isEmpty());
-      assertTrue(processDestroyer.isAddedAsShutdownHook() == false);
+      assertFalse(processDestroyer.isAddedAsShutdownHook());
     }
 
     /**
@@ -516,9 +516,9 @@ public class DefaultExecutorTest {
       final ShutdownHookProcessDestroyer processDestroyer = new 
ShutdownHookProcessDestroyer();
       final ExecuteWatchdog watchdog = new ExecuteWatchdog(Integer.MAX_VALUE);
 
-      assertTrue(exec.getProcessDestroyer() == null);
+      assertNull(exec.getProcessDestroyer());
       assertTrue(processDestroyer.isEmpty());
-      assertTrue(processDestroyer.isAddedAsShutdownHook() == false);
+      assertFalse(processDestroyer.isAddedAsShutdownHook());
 
       exec.setWatchdog(watchdog);
       exec.setProcessDestroyer(processDestroyer);
diff --git a/src/test/java/org/apache/commons/exec/util/MapUtilTest.java 
b/src/test/java/org/apache/commons/exec/util/MapUtilTest.java
index bc5b9c5..e79f304 100644
--- a/src/test/java/org/apache/commons/exec/util/MapUtilTest.java
+++ b/src/test/java/org/apache/commons/exec/util/MapUtilTest.java
@@ -39,13 +39,13 @@ public class MapUtilTest {
         procEnvironment.put("JAVA_HOME", "/usr/opt/java");
 
         final Map<String, String> result = MapUtils.copy(procEnvironment);
-        assertTrue(result.size() == 1);
-        assertTrue(procEnvironment.size() == 1);
+        assertEquals(1, result.size());
+        assertEquals(1, procEnvironment.size());
         assertEquals("/usr/opt/java", result.get("JAVA_HOME"));
 
         result.remove("JAVA_HOME");
         assertTrue(result.isEmpty());
-        assertTrue(procEnvironment.size() == 1);
+        assertEquals(1, procEnvironment.size());
     }
 
     /**
@@ -59,7 +59,7 @@ public class MapUtilTest {
 
         applicationEnvironment.put("appMainClass", "foo.bar.Main");
         final Map<String, String> result = MapUtils.merge(procEnvironment, 
applicationEnvironment);
-        assertTrue(procEnvironment.size() + applicationEnvironment.size() == 
result.size());
+        assertEquals(procEnvironment.size() + applicationEnvironment.size(), 
result.size());
         assertEquals("foo.bar.Main", result.get("appMainClass"));
     }
 
@@ -74,7 +74,7 @@ public class MapUtilTest {
 
         final Map<String, String> result =
           MapUtils.prefix(procEnvironment, "env");
-        assertTrue(procEnvironment.size() == result.size());
+        assertEquals(procEnvironment.size(), result.size());
         assertEquals("/usr/opt/java", result.get("env.JAVA_HOME"));
     }
 }
\ No newline at end of file