This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git
The following commit(s) were added to refs/heads/master by this push:
new 6505ee9b Better JUnit API usage
6505ee9b is described below
commit 6505ee9b9972519920ab8dd3a33c94688b816e48
Author: Gary Gregory <[email protected]>
AuthorDate: Sat Aug 5 16:12:21 2023 -0400
Better JUnit API usage
---
src/test/java/org/apache/commons/validator/ExtensionTest.java | 4 ++--
.../java/org/apache/commons/validator/GenericTypeValidatorTest.java | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/java/org/apache/commons/validator/ExtensionTest.java
b/src/test/java/org/apache/commons/validator/ExtensionTest.java
index 5b71ed43..b1acc197 100644
--- a/src/test/java/org/apache/commons/validator/ExtensionTest.java
+++ b/src/test/java/org/apache/commons/validator/ExtensionTest.java
@@ -319,10 +319,10 @@ public class ExtensionTest extends TestCase {
final Form form2 = resources.getForm(ValidatorResources.defaultLocale,
FORM_KEY2);
assertNotNull(FORM_KEY + " is null.", form);
- assertTrue("There should only be 2 fields in " + FORM_KEY,
form.getFields().size() == 2);
+ assertEquals("There should only be 2 fields in " + FORM_KEY, 2,
form.getFields().size());
assertNotNull(FORM_KEY2 + " is null.", form2);
- assertTrue("There should only be 2 fields in " + FORM_KEY2,
form2.getFields().size() == 2);
+ assertEquals("There should only be 2 fields in " + FORM_KEY2, 2,
form2.getFields().size());
//get the first field
Field fieldFirstName = form.getFields().get(0);
diff --git
a/src/test/java/org/apache/commons/validator/GenericTypeValidatorTest.java
b/src/test/java/org/apache/commons/validator/GenericTypeValidatorTest.java
index b3e77743..ad1e908e 100644
--- a/src/test/java/org/apache/commons/validator/GenericTypeValidatorTest.java
+++ b/src/test/java/org/apache/commons/validator/GenericTypeValidatorTest.java
@@ -139,8 +139,8 @@ protected void tearDown() {
info.setDouble("129,1551511111");
info.setDate("21/12/2010");
final Map<String, ?> map = localeTest(info, Locale.FRENCH);
- assertTrue("float value not correct",
((Float)map.get("float")).intValue() == 12);
- assertTrue("double value not correct",
((Double)map.get("double")).intValue() == 129);
+ assertEquals("float value not correct", 12,
((Float)map.get("float")).intValue());
+ assertEquals("double value not correct", 129,
((Double)map.get("double")).intValue());
}
/**