This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git
The following commit(s) were added to refs/heads/master by this push:
new ebeca98e Make private static classes final
ebeca98e is described below
commit ebeca98ea313cd510059f68ef90a20e739237ad7
Author: Gary Gregory <[email protected]>
AuthorDate: Tue Oct 10 16:03:33 2023 -0400
Make private static classes final
---
.../java/org/apache/commons/beanutils2/BaseDynaBeanMapDecorator.java | 2 +-
src/main/java/org/apache/commons/beanutils2/BeanComparator.java | 2 +-
.../java/org/apache/commons/beanutils2/MappedPropertyDescriptor.java | 2 +-
src/main/java/org/apache/commons/beanutils2/MethodUtils.java | 2 +-
src/main/java/org/apache/commons/beanutils2/WrapDynaClass.java | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git
a/src/main/java/org/apache/commons/beanutils2/BaseDynaBeanMapDecorator.java
b/src/main/java/org/apache/commons/beanutils2/BaseDynaBeanMapDecorator.java
index 69e9f548..613261c0 100644
--- a/src/main/java/org/apache/commons/beanutils2/BaseDynaBeanMapDecorator.java
+++ b/src/main/java/org/apache/commons/beanutils2/BaseDynaBeanMapDecorator.java
@@ -52,7 +52,7 @@ public abstract class BaseDynaBeanMapDecorator<K> implements
Map<K, Object> {
/**
* Map.Entry implementation.
*/
- private static class MapEntry<K> implements Map.Entry<K, Object> {
+ private static final class MapEntry<K> implements Map.Entry<K, Object> {
private final K key;
private final Object value;
diff --git a/src/main/java/org/apache/commons/beanutils2/BeanComparator.java
b/src/main/java/org/apache/commons/beanutils2/BeanComparator.java
index ce628f98..2c114cbe 100644
--- a/src/main/java/org/apache/commons/beanutils2/BeanComparator.java
+++ b/src/main/java/org/apache/commons/beanutils2/BeanComparator.java
@@ -53,7 +53,7 @@ public class BeanComparator<T, V> implements Comparator<T>,
Serializable {
* @param <E> the type of objects compared by this comparator
* @see java.util.Collections#reverseOrder()
*/
- private static class NaturalOrderComparator<E extends Comparable<? super
E>>
+ private static final class NaturalOrderComparator<E extends Comparable<?
super E>>
implements Comparator<E>, Serializable {
/** Serialization version. */
diff --git
a/src/main/java/org/apache/commons/beanutils2/MappedPropertyDescriptor.java
b/src/main/java/org/apache/commons/beanutils2/MappedPropertyDescriptor.java
index 8da407ad..c907cc45 100644
--- a/src/main/java/org/apache/commons/beanutils2/MappedPropertyDescriptor.java
+++ b/src/main/java/org/apache/commons/beanutils2/MappedPropertyDescriptor.java
@@ -51,7 +51,7 @@ public class MappedPropertyDescriptor extends
PropertyDescriptor {
*
* See https://issues.apache.org/jira/browse/BEANUTILS-291
*/
- private static class MappedMethodReference {
+ private static final class MappedMethodReference {
private String className;
private String methodName;
private Reference<Method> methodRef;
diff --git a/src/main/java/org/apache/commons/beanutils2/MethodUtils.java
b/src/main/java/org/apache/commons/beanutils2/MethodUtils.java
index 03f84b4b..ec3b435f 100644
--- a/src/main/java/org/apache/commons/beanutils2/MethodUtils.java
+++ b/src/main/java/org/apache/commons/beanutils2/MethodUtils.java
@@ -49,7 +49,7 @@ public class MethodUtils {
/**
* Represents the key to looking up a Method by reflection.
*/
- private static class MethodDescriptor {
+ private static final class MethodDescriptor {
private final Class<?> cls;
private final String methodName;
private final Class<?>[] paramTypes;
diff --git a/src/main/java/org/apache/commons/beanutils2/WrapDynaClass.java
b/src/main/java/org/apache/commons/beanutils2/WrapDynaClass.java
index 6e3c0b66..08dd7fae 100644
--- a/src/main/java/org/apache/commons/beanutils2/WrapDynaClass.java
+++ b/src/main/java/org/apache/commons/beanutils2/WrapDynaClass.java
@@ -48,7 +48,7 @@ public class WrapDynaClass implements DynaClass {
* instances. A single key consists of a bean class and an instance of
* {@code PropertyUtilsBean}. Instances are immutable.
*/
- private static class CacheKey {
+ private static final class CacheKey {
/** The bean class. */
private final Class<?> beanClass;