This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-math.git
commit cfd7a363137e94d97770db91f3d925c2b2141870
Author: Alex Herbert <aherb...@apache.org>
AuthorDate: Tue Nov 21 18:33:47 2023 +0000
Checkstyle: private final class should be final
---
.../commons/math4/core/jdkmath/AccurateMath.java | 6 ++--
.../interpolation/InterpolatingMicrosphere.java | 4 +--
.../analysis/polynomials/PolynomialsUtils.java | 2 +-
.../legacy/analysis/solvers/LaguerreSolver.java | 2 +-
.../legacy/distribution/EmpiricalDistribution.java | 2 +-
.../MixtureMultivariateRealDistribution.java | 2 +-
...ariateNormalMixtureExpectationMaximization.java | 2 +-
.../fitting/leastsquares/LeastSquaresFactory.java | 4 +--
.../leastsquares/LevenbergMarquardtOptimizer.java | 2 +-
.../commons/math4/legacy/linear/BigRealField.java | 2 +-
.../math4/legacy/linear/SchurTransformer.java | 2 +-
.../apache/commons/math4/legacy/linear/SymmLQ.java | 2 +-
.../math4/legacy/ode/ExpandableStatefulODE.java | 2 +-
.../commons/math4/legacy/ode/JacobianMatrices.java | 4 +--
.../math4/legacy/ode/MultistepFieldIntegrator.java | 4 +--
.../math4/legacy/ode/MultistepIntegrator.java | 4 +--
.../math4/legacy/ode/events/EventState.java | 2 +-
.../ode/nonstiff/AdamsMoultonFieldIntegrator.java | 2 +-
.../ode/nonstiff/AdamsMoultonIntegrator.java | 2 +-
.../legacy/ode/sampling/DummyStepHandler.java | 2 +-
.../legacy/optim/AbstractOptimizationProblem.java | 4 +--
.../commons/math4/legacy/optim/BaseOptimizer.java | 4 +--
.../scalar/MultivariateFunctionMappingAdapter.java | 8 ++---
.../nonlinear/scalar/noderiv/BOBYQAOptimizer.java | 2 +-
.../nonlinear/scalar/noderiv/CMAESOptimizer.java | 6 ++--
.../legacy/optim/univariate/BracketFinder.java | 2 +-
.../commons/math4/legacy/stat/Frequency.java | 2 +-
.../descriptive/AggregateSummaryStatistics.java | 2 +-
.../stat/descriptive/rank/PSquarePercentile.java | 2 +-
.../math4/legacy/stat/ranking/NaturalRanking.java | 2 +-
.../differentiation/GradientFunctionTest.java | 2 +-
.../differentiation/JacobianFunctionTest.java | 2 +-
.../legacy/fitting/leastsquares/MinpackTest.java | 36 +++++++++++-----------
.../genetics/ElitisticListPopulationTest.java | 2 +-
.../math4/legacy/genetics/FitnessCachingTest.java | 2 +-
.../genetics/GeneticAlgorithmTestBinary.java | 2 +-
.../genetics/GeneticAlgorithmTestPermutations.java | 2 +-
.../legacy/genetics/TournamentSelectionTest.java | 2 +-
.../legacy/linear/Array2DRowRealMatrixTest.java | 4 +--
.../math4/legacy/linear/BlockFieldMatrixTest.java | 4 +--
.../math4/legacy/linear/BlockRealMatrixTest.java | 4 +--
.../math4/legacy/linear/FieldMatrixImplTest.java | 4 +--
.../ml/clustering/KMeansPlusPlusClustererTest.java | 2 +-
.../math4/legacy/ode/FirstOrderConverterTest.java | 2 +-
.../math4/legacy/ode/JacobianMatricesTest.java | 8 ++---
.../math4/legacy/ode/TestFieldProblem4.java | 4 +--
.../commons/math4/legacy/ode/TestProblem4.java | 4 +--
.../math4/legacy/ode/events/CloseEventsTest.java | 2 +-
.../math4/legacy/ode/events/EventFilterTest.java | 2 +-
.../math4/legacy/ode/events/EventStateTest.java | 6 ++--
.../legacy/ode/events/OverlappingEventsTest.java | 2 +-
.../legacy/ode/events/ReappearingEventTest.java | 2 +-
...tractEmbeddedRungeKuttaFieldIntegratorTest.java | 4 +--
.../AbstractRungeKuttaFieldIntegratorTest.java | 4 +--
.../ode/nonstiff/AdamsBashforthIntegratorTest.java | 4 +--
.../nonstiff/AdamsFieldIntegratorAbstractTest.java | 4 +--
.../ode/nonstiff/AdamsMoultonIntegratorTest.java | 4 +--
.../ClassicalRungeKuttaIntegratorTest.java | 2 +-
.../nonstiff/DormandPrince54IntegratorTest.java | 6 ++--
.../nonstiff/DormandPrince853IntegratorTest.java | 6 ++--
...eddedRungeKuttaFieldIntegratorAbstractTest.java | 4 +--
.../ode/nonstiff/EulerStepInterpolatorTest.java | 2 +-
.../legacy/ode/nonstiff/GillIntegratorTest.java | 2 +-
.../nonstiff/GraggBulirschStoerIntegratorTest.java | 2 +-
.../ode/nonstiff/HighamHall54IntegratorTest.java | 2 +-
.../legacy/ode/nonstiff/LutherIntegratorTest.java | 2 +-
.../RungeKuttaFieldIntegratorAbstractTest.java | 4 +--
...ungeKuttaFieldStepInterpolatorAbstractTest.java | 2 +-
.../ode/nonstiff/ThreeEighthesIntegratorTest.java | 2 +-
.../ode/sampling/DummyStepInterpolatorTest.java | 4 +--
.../MultiStartMultivariateOptimizerTest.java | 2 +-
.../MultivariateFunctionMappingAdapterTest.java | 2 +-
.../MultivariateFunctionPenaltyAdapterTest.java | 2 +-
.../NonLinearConjugateGradientOptimizerTest.java | 2 +-
.../nonlinear/scalar/noderiv/OptimTestUtils.java | 2 +-
.../SimplexOptimizerMultiDirectionalTest.java | 2 +-
.../MultiStartUnivariateOptimizerTest.java | 2 +-
77 files changed, 131 insertions(+), 131 deletions(-)
diff --git
a/commons-math-core/src/main/java/org/apache/commons/math4/core/jdkmath/AccurateMath.java
b/commons-math-core/src/main/java/org/apache/commons/math4/core/jdkmath/AccurateMath.java
index 96562866b..67c0726e7 100644
---
a/commons-math-core/src/main/java/org/apache/commons/math4/core/jdkmath/AccurateMath.java
+++
b/commons-math-core/src/main/java/org/apache/commons/math4/core/jdkmath/AccurateMath.java
@@ -4082,7 +4082,7 @@ public final class AccurateMath {
}
/** Enclose large data table in nested static class so it's only loaded on
first access. */
- private static class ExpIntTable {
+ private static final class ExpIntTable {
/** Exponential evaluated at integer values,
* exp(x) = expIntTableA[x + EXP_INT_TABLE_MAX_INDEX] +
expIntTableB[x+EXP_INT_TABLE_MAX_INDEX].
*/
@@ -4121,7 +4121,7 @@ public final class AccurateMath {
}
/** Enclose large data table in nested static class so it's only loaded on
first access. */
- private static class ExpFracTable {
+ private static final class ExpFracTable {
/** Exponential over the range of 0 - 1 in increments of 2^-10
* exp(x/1024) = expFracTableA[x] + expFracTableB[x].
* 1024 = 2^10
@@ -4154,7 +4154,7 @@ public final class AccurateMath {
}
/** Enclose large data table in nested static class so it's only loaded on
first access. */
- private static class lnMant {
+ private static final class lnMant {
/** Extended precision logarithm table over the range 1 - 2 in
increments of 2^-10. */
private static final double[][] LN_MANT;
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/interpolation/InterpolatingMicrosphere.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/interpolation/InterpolatingMicrosphere.java
index d4d4cd466..67dccff8d 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/interpolation/InterpolatingMicrosphere.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/interpolation/InterpolatingMicrosphere.java
@@ -328,7 +328,7 @@ public class InterpolatingMicrosphere {
/**
* Microsphere "facet" (surface element).
*/
- private static class Facet {
+ private static final class Facet {
/** Normal vector characterizing a surface element. */
private final double[] normal;
@@ -353,7 +353,7 @@ public class InterpolatingMicrosphere {
/**
* Data associated with each {@link Facet}.
*/
- private static class FacetData {
+ private static final class FacetData {
/** Illumination received from the sample. */
private final double illumination;
/** Data value of the sample. */
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/polynomials/PolynomialsUtils.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/polynomials/PolynomialsUtils.java
index b8c422ff3..71752436d 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/polynomials/PolynomialsUtils.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/polynomials/PolynomialsUtils.java
@@ -264,7 +264,7 @@ public final class PolynomialsUtils {
}
/** Inner class for Jacobi polynomials keys. */
- private static class JacobiKey {
+ private static final class JacobiKey {
/** First exponent. */
private final int v;
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/solvers/LaguerreSolver.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/solvers/LaguerreSolver.java
index 193427414..e009473ce 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/solvers/LaguerreSolver.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/solvers/LaguerreSolver.java
@@ -229,7 +229,7 @@ public class LaguerreSolver extends
AbstractPolynomialSolver {
/**
* Class for searching all (complex) roots.
*/
- private class ComplexSolver {
+ private final class ComplexSolver {
/**
* Check whether the given complex root is actually a real zero
* in the given interval, within the solver tolerance level.
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/distribution/EmpiricalDistribution.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/distribution/EmpiricalDistribution.java
index 414249b62..983d22afd 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/distribution/EmpiricalDistribution.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/distribution/EmpiricalDistribution.java
@@ -551,7 +551,7 @@ public final class EmpiricalDistribution extends
AbstractRealDistribution
/**
* Constant distribution.
*/
- private static class ConstantContinuousDistribution implements
ContinuousDistribution {
+ private static final class ConstantContinuousDistribution implements
ContinuousDistribution {
/** Constant value of the distribution. */
private final double value;
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/distribution/MixtureMultivariateRealDistribution.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/distribution/MixtureMultivariateRealDistribution.java
index 67395e77d..b8d8929b9 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/distribution/MixtureMultivariateRealDistribution.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/distribution/MixtureMultivariateRealDistribution.java
@@ -116,7 +116,7 @@ public class MixtureMultivariateRealDistribution<T extends
MultivariateRealDistr
/**
* Sampler.
*/
- private class MixtureSampler implements
MultivariateRealDistribution.Sampler {
+ private final class MixtureSampler implements
MultivariateRealDistribution.Sampler {
/** RNG. */
private final UniformRandomProvider rng;
/** Sampler for each of the distribution in the mixture. */
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/distribution/fitting/MultivariateNormalMixtureExpectationMaximization.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/distribution/fitting/MultivariateNormalMixtureExpectationMaximization.java
index ad20ad5b7..ee5993039 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/distribution/fitting/MultivariateNormalMixtureExpectationMaximization.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/distribution/fitting/MultivariateNormalMixtureExpectationMaximization.java
@@ -391,7 +391,7 @@ public class
MultivariateNormalMixtureExpectationMaximization {
/**
* Class used for sorting user-supplied data.
*/
- private static class DataRow implements Comparable<DataRow> {
+ private static final class DataRow implements Comparable<DataRow> {
/** One data row. */
private final double[] row;
/** Mean of the data row. */
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/fitting/leastsquares/LeastSquaresFactory.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/fitting/leastsquares/LeastSquaresFactory.java
index 415a7536e..69cd27268 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/fitting/leastsquares/LeastSquaresFactory.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/fitting/leastsquares/LeastSquaresFactory.java
@@ -304,7 +304,7 @@ public final class LeastSquaresFactory {
* Combine a {@link MultivariateVectorFunction} with a {@link
* MultivariateMatrixFunction} to produce a {@link
MultivariateJacobianFunction}.
*/
- private static class LocalValueAndJacobianFunction
+ private static final class LocalValueAndJacobianFunction
implements ValueAndJacobianFunction {
/** Model. */
private final MultivariateVectorFunction value;
@@ -350,7 +350,7 @@ public final class LeastSquaresFactory {
* LeastSquaresProblem}.
* @since 3.3
*/
- private static class LocalLeastSquaresProblem
+ private static final class LocalLeastSquaresProblem
extends AbstractOptimizationProblem<Evaluation>
implements LeastSquaresProblem {
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/fitting/leastsquares/LevenbergMarquardtOptimizer.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/fitting/leastsquares/LevenbergMarquardtOptimizer.java
index 9fdbaf954..c7ffea1ab 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/fitting/leastsquares/LevenbergMarquardtOptimizer.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/fitting/leastsquares/LevenbergMarquardtOptimizer.java
@@ -552,7 +552,7 @@ public class LevenbergMarquardtOptimizer implements
LeastSquaresOptimizer {
* Code should be further refactored in order to not pass around arguments
* that will modified in-place (cf. "work" arrays).
*/
- private static class InternalData {
+ private static final class InternalData {
/** Weighted Jacobian. */
private final double[][] weightedJacobian;
/** Columns permutation array. */
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/linear/BigRealField.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/linear/BigRealField.java
index 5db77293f..63cab60a0 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/linear/BigRealField.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/linear/BigRealField.java
@@ -69,7 +69,7 @@ public final class BigRealField implements Field<BigReal>,
Serializable {
/** Holder for the instance.
* <p>We use here the Initialization On Demand Holder Idiom.</p>
*/
- private static class LazyHolder {
+ private static final class LazyHolder {
/** Cached field instance. */
private static final BigRealField INSTANCE = new BigRealField();
}
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/linear/SchurTransformer.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/linear/SchurTransformer.java
index ed97c6e91..7edc27fd4 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/linear/SchurTransformer.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/linear/SchurTransformer.java
@@ -436,7 +436,7 @@ class SchurTransformer {
* Internal data structure holding the current shift information.
* Contains variable names as present in the original JAMA code.
*/
- private static class ShiftInfo {
+ private static final class ShiftInfo {
// CHECKSTYLE: stop all
/** x shift info. */
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/linear/SymmLQ.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/linear/SymmLQ.java
index dab79aff5..f02fb84f6 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/linear/SymmLQ.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/linear/SymmLQ.java
@@ -236,7 +236,7 @@ public class SymmLQ
* the current number of evaluations of matrix-vector products.
* </p>
*/
- private static class State {
+ private static final class State {
/** The cubic root of {@link #MACH_PREC}. */
static final double CBRT_MACH_PREC;
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/ExpandableStatefulODE.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/ExpandableStatefulODE.java
index 4a3c8b487..e1b137ce5 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/ExpandableStatefulODE.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/ExpandableStatefulODE.java
@@ -293,7 +293,7 @@ public class ExpandableStatefulODE {
}
/** Components of the compound stateful ODE. */
- private static class SecondaryComponent {
+ private static final class SecondaryComponent {
/** Secondary differential equation. */
private final SecondaryEquations equation;
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/JacobianMatrices.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/JacobianMatrices.java
index 8116840e4..9fd86870e 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/JacobianMatrices.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/JacobianMatrices.java
@@ -332,7 +332,7 @@ public class JacobianMatrices {
* by forcing the use of {@link
JacobianMatrices#registerVariationalEquations(ExpandableStatefulODE)}.
* </p>
*/
- private class JacobiansSecondaryEquations implements SecondaryEquations {
+ private final class JacobiansSecondaryEquations implements
SecondaryEquations {
/** {@inheritDoc} */
@Override
@@ -410,7 +410,7 @@ public class JacobianMatrices {
/** Wrapper class to compute jacobian matrices by finite differences for
ODE
* which do not compute them by themselves.
*/
- private static class MainStateJacobianWrapper implements
MainStateJacobianProvider {
+ private static final class MainStateJacobianWrapper implements
MainStateJacobianProvider {
/** Raw ODE without jacobians computation skill to be wrapped into a
MainStateJacobianProvider. */
private final FirstOrderDifferentialEquations ode;
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/MultistepFieldIntegrator.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/MultistepFieldIntegrator.java
index 81837ef61..04f3e9f8b 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/MultistepFieldIntegrator.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/MultistepFieldIntegrator.java
@@ -348,7 +348,7 @@ public abstract class MultistepFieldIntegrator<T extends
RealFieldElement<T>>
/** Specialized step handler storing the first step.
*/
- private class FieldNordsieckInitializer implements FieldStepHandler<T> {
+ private final class FieldNordsieckInitializer implements
FieldStepHandler<T> {
/** Equation mapper. */
private final FieldEquationsMapper<T> mapper;
@@ -430,7 +430,7 @@ public abstract class MultistepFieldIntegrator<T extends
RealFieldElement<T>>
}
/** Marker exception used ONLY to stop the starter integrator after first
step. */
- private static class InitializationCompletedMarkerException
+ private static final class InitializationCompletedMarkerException
extends RuntimeException {
/** Serializable version identifier. */
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/MultistepIntegrator.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/MultistepIntegrator.java
index 6f3d356f0..27caaefbc 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/MultistepIntegrator.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/MultistepIntegrator.java
@@ -347,7 +347,7 @@ public abstract class MultistepIntegrator extends
AdaptiveStepsizeIntegrator {
}
/** Specialized step handler storing the first step. */
- private class NordsieckInitializer implements StepHandler {
+ private final class NordsieckInitializer implements StepHandler {
/** Steps counter. */
private int count;
@@ -440,7 +440,7 @@ public abstract class MultistepIntegrator extends
AdaptiveStepsizeIntegrator {
}
/** Marker exception used ONLY to stop the starter integrator after first
step. */
- private static class InitializationCompletedMarkerException
+ private static final class InitializationCompletedMarkerException
extends RuntimeException {
/** Serializable version identifier. */
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/events/EventState.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/events/EventState.java
index c505c90b7..6bf05560d 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/events/EventState.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/events/EventState.java
@@ -397,7 +397,7 @@ public class EventState {
}
/** Local wrapper to propagate exceptions. */
- private static class LocalMaxCountExceededException extends
RuntimeException {
+ private static final class LocalMaxCountExceededException extends
RuntimeException {
/** Serializable UID. */
private static final long serialVersionUID = 20120901L;
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/nonstiff/AdamsMoultonFieldIntegrator.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/nonstiff/AdamsMoultonFieldIntegrator.java
index 491b88824..b88ce2880 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/nonstiff/AdamsMoultonFieldIntegrator.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/nonstiff/AdamsMoultonFieldIntegrator.java
@@ -338,7 +338,7 @@ public class AdamsMoultonFieldIntegrator<T extends
RealFieldElement<T>> extends
* </pre>
* </p>
*/
- private class Corrector implements FieldMatrixPreservingVisitor<T> {
+ private final class Corrector implements FieldMatrixPreservingVisitor<T> {
/** Previous state. */
private final T[] previous;
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/nonstiff/AdamsMoultonIntegrator.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/nonstiff/AdamsMoultonIntegrator.java
index 83e30a708..1967e86bc 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/nonstiff/AdamsMoultonIntegrator.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/nonstiff/AdamsMoultonIntegrator.java
@@ -344,7 +344,7 @@ public class AdamsMoultonIntegrator extends AdamsIntegrator
{
* </pre>
* </p>
*/
- private class Corrector implements RealMatrixPreservingVisitor {
+ private final class Corrector implements RealMatrixPreservingVisitor {
/** Previous state. */
private final double[] previous;
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/sampling/DummyStepHandler.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/sampling/DummyStepHandler.java
index 6133bf283..b879ea40d 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/sampling/DummyStepHandler.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/sampling/DummyStepHandler.java
@@ -74,7 +74,7 @@ public final class DummyStepHandler implements StepHandler {
/** Holder for the instance.
* <p>We use here the Initialization On Demand Holder Idiom.</p>
*/
- private static class LazyHolder {
+ private static final class LazyHolder {
/** Cached field instance. */
private static final DummyStepHandler INSTANCE = new
DummyStepHandler();
}
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/AbstractOptimizationProblem.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/AbstractOptimizationProblem.java
index 21b4bfaa3..c4d7a77cd 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/AbstractOptimizationProblem.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/AbstractOptimizationProblem.java
@@ -81,7 +81,7 @@ public abstract class AbstractOptimizationProblem<PAIR>
}
/** Defines the action to perform when reaching the maximum number of
evaluations. */
- private static class MaxEvalCallback
+ private static final class MaxEvalCallback
implements IntegerSequence.Incrementor.MaxCountExceededCallback {
/**
* {@inheritDoc}
@@ -95,7 +95,7 @@ public abstract class AbstractOptimizationProblem<PAIR>
}
/** Defines the action to perform when reaching the maximum number of
evaluations. */
- private static class MaxIterCallback
+ private static final class MaxIterCallback
implements IntegerSequence.Incrementor.MaxCountExceededCallback {
/**
* {@inheritDoc}
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/BaseOptimizer.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/BaseOptimizer.java
index 3e16d7b28..06b8acaee 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/BaseOptimizer.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/BaseOptimizer.java
@@ -247,7 +247,7 @@ public abstract class BaseOptimizer<PAIR> {
* Defines the action to perform when reaching the maximum number
* of evaluations.
*/
- private static class MaxEvalCallback
+ private static final class MaxEvalCallback
implements IntegerSequence.Incrementor.MaxCountExceededCallback {
/**
* {@inheritDoc}
@@ -263,7 +263,7 @@ public abstract class BaseOptimizer<PAIR> {
* Defines the action to perform when reaching the maximum number
* of evaluations.
*/
- private static class MaxIterCallback
+ private static final class MaxIterCallback
implements IntegerSequence.Incrementor.MaxCountExceededCallback {
/**
* {@inheritDoc}
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/MultivariateFunctionMappingAdapter.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/MultivariateFunctionMappingAdapter.java
index efc33ca6b..50cfaa2d8 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/MultivariateFunctionMappingAdapter.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/MultivariateFunctionMappingAdapter.java
@@ -201,7 +201,7 @@ public class MultivariateFunctionMappingAdapter
}
/** Local class for no bounds mapping. */
- private static class NoBoundsMapper implements Mapper {
+ private static final class NoBoundsMapper implements Mapper {
/** {@inheritDoc} */
@Override
public double unboundedToBounded(final double y) {
@@ -216,7 +216,7 @@ public class MultivariateFunctionMappingAdapter
}
/** Local class for lower bounds mapping. */
- private static class LowerBoundMapper implements Mapper {
+ private static final class LowerBoundMapper implements Mapper {
/** Low bound. */
private final double lower;
@@ -243,7 +243,7 @@ public class MultivariateFunctionMappingAdapter
}
/** Local class for upper bounds mapping. */
- private static class UpperBoundMapper implements Mapper {
+ private static final class UpperBoundMapper implements Mapper {
/** Upper bound. */
private final double upper;
@@ -269,7 +269,7 @@ public class MultivariateFunctionMappingAdapter
}
/** Local class for lower and bounds mapping. */
- private static class LowerUpperBoundMapper implements Mapper {
+ private static final class LowerUpperBoundMapper implements Mapper {
/** Function from unbounded to bounded. */
private final UnivariateFunction boundingFunction;
/** Function from bounded to unbounded. */
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/noderiv/BOBYQAOptimizer.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/noderiv/BOBYQAOptimizer.java
index 593f0f663..5842dfceb 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/noderiv/BOBYQAOptimizer.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/noderiv/BOBYQAOptimizer.java
@@ -2453,7 +2453,7 @@ public class BOBYQAOptimizer
* Marker for code paths that are not explored with the current unit tests.
* If the path becomes explored, it should just be removed from the code.
*/
- private static class PathIsExploredException extends RuntimeException {
+ private static final class PathIsExploredException extends
RuntimeException {
/** Serializable UID. */
private static final long serialVersionUID = 745350979634801853L;
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/noderiv/CMAESOptimizer.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/noderiv/CMAESOptimizer.java
index 76cf5cf05..65e962c0a 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/noderiv/CMAESOptimizer.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/noderiv/CMAESOptimizer.java
@@ -801,7 +801,7 @@ public class CMAESOptimizer
* Used to sort fitness values. Sorting is always in lower value first
* order.
*/
- private static class DoubleIndex implements Comparable<DoubleIndex> {
+ private static final class DoubleIndex implements Comparable<DoubleIndex> {
/** Value to compare. */
private final double value;
/** Index into sorted array. */
@@ -847,7 +847,7 @@ public class CMAESOptimizer
/**
* Stores the value and penalty (for repair of out of bounds point).
*/
- private static class ValuePenaltyPair {
+ private static final class ValuePenaltyPair {
/** Objective function value. */
private double value;
/** Penalty value for repair of out out of bounds points. */
@@ -868,7 +868,7 @@ public class CMAESOptimizer
* Normalizes fitness values to the range [0,1]. Adds a penalty to the
* fitness value if out of range.
*/
- private class FitnessFunction {
+ private final class FitnessFunction {
/**
* Flag indicating whether the objective variables are forced into
their
* bounds if defined.
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/univariate/BracketFinder.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/univariate/BracketFinder.java
index a0ecd50f3..42c520a0e 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/univariate/BracketFinder.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/univariate/BracketFinder.java
@@ -279,7 +279,7 @@ public class BracketFinder {
/**
* Utility for incrementing a counter at each function evaluation.
*/
- private class FunctionEvaluator {
+ private final class FunctionEvaluator {
/** Function. */
private final UnivariateFunction func;
/** Counter. */
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/stat/Frequency.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/stat/Frequency.java
index c6da2a7e9..038f1287c 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/stat/Frequency.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/stat/Frequency.java
@@ -330,7 +330,7 @@ public class Frequency<T extends Comparable<T>> {
*
* @param <U> the type of the objects compared
*/
- private static class NaturalComparator<U extends Comparable<U>> implements
Comparator<U> {
+ private static final class NaturalComparator<U extends Comparable<U>>
implements Comparator<U> {
/**
* Compare the two {@link Comparable Comparable} arguments.
* This method is equivalent to:
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/stat/descriptive/AggregateSummaryStatistics.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/stat/descriptive/AggregateSummaryStatistics.java
index 7604bb02c..1807e5c97 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/stat/descriptive/AggregateSummaryStatistics.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/stat/descriptive/AggregateSummaryStatistics.java
@@ -352,7 +352,7 @@ public class AggregateSummaryStatistics implements
StatisticalSummary {
*
* @since 2.0
*/
- private static class AggregatingSummaryStatistics extends
SummaryStatistics {
+ private static final class AggregatingSummaryStatistics extends
SummaryStatistics {
/**
* The serialization version of this class.
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/stat/descriptive/rank/PSquarePercentile.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/stat/descriptive/rank/PSquarePercentile.java
index aecf306f7..8184fb71d 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/stat/descriptive/rank/PSquarePercentile.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/stat/descriptive/rank/PSquarePercentile.java
@@ -824,7 +824,7 @@ public class PSquarePercentile extends
AbstractStorelessUnivariateStatistic
*
* @param <E> type for fixed capacity list
*/
- private static class FixedCapacityList<E> extends ArrayList<E> {
+ private static final class FixedCapacityList<E> extends ArrayList<E> {
/**
* Capacity of the list.
*/
diff --git
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/stat/ranking/NaturalRanking.java
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/stat/ranking/NaturalRanking.java
index b37c6b63f..978c9e134 100644
---
a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/stat/ranking/NaturalRanking.java
+++
b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/stat/ranking/NaturalRanking.java
@@ -427,7 +427,7 @@ public class NaturalRanking implements RankingAlgorithm {
* to sort an array of IntDoublePairs by value. Note that the
* implicitly defined natural ordering is NOT consistent with equals.
*/
- private static class IntDoublePair implements Comparable<IntDoublePair> {
+ private static final class IntDoublePair implements
Comparable<IntDoublePair> {
/** Value of the pair. */
private final double value;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/analysis/differentiation/GradientFunctionTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/analysis/differentiation/GradientFunctionTest.java
index ff06e0f53..aa0a270c5 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/analysis/differentiation/GradientFunctionTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/analysis/differentiation/GradientFunctionTest.java
@@ -55,7 +55,7 @@ public class GradientFunctionTest {
}
}
- private static class EuclideanDistance implements
MultivariateDifferentiableFunction {
+ private static final class EuclideanDistance implements
MultivariateDifferentiableFunction {
@Override
public double value(double[] point) {
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/analysis/differentiation/JacobianFunctionTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/analysis/differentiation/JacobianFunctionTest.java
index 428d184d9..3fef1d51c 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/analysis/differentiation/JacobianFunctionTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/analysis/differentiation/JacobianFunctionTest.java
@@ -46,7 +46,7 @@ public class JacobianFunctionTest {
}
/* Maps (latitude, longitude) to (x, y, z) */
- private static class SphereMapping implements
MultivariateDifferentiableVectorFunction {
+ private static final class SphereMapping implements
MultivariateDifferentiableVectorFunction {
private final double radius;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/fitting/leastsquares/MinpackTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/fitting/leastsquares/MinpackTest.java
index 035d61b13..e56368a45 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/fitting/leastsquares/MinpackTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/fitting/leastsquares/MinpackTest.java
@@ -612,7 +612,7 @@ public class MinpackTest {
public abstract double[] computeValue(double[] variables);
}
- private static class LinearFullRankFunction extends MinpackFunction {
+ private static final class LinearFullRankFunction extends MinpackFunction {
LinearFullRankFunction(int m, int n, double x0,
double theoreticalStartCost,
@@ -650,7 +650,7 @@ public class MinpackTest {
}
}
- private static class LinearRank1Function extends MinpackFunction {
+ private static final class LinearRank1Function extends MinpackFunction {
LinearRank1Function(int m, int n, double x0,
double theoreticalStartCost,
@@ -684,7 +684,7 @@ public class MinpackTest {
}
}
- private static class LinearRank1ZeroColsAndRowsFunction extends
MinpackFunction {
+ private static final class LinearRank1ZeroColsAndRowsFunction extends
MinpackFunction {
LinearRank1ZeroColsAndRowsFunction(int m, int n, double x0) {
super(m, buildArray(n, x0),
@@ -727,7 +727,7 @@ public class MinpackTest {
}
}
- private static class RosenbrockFunction extends MinpackFunction {
+ private static final class RosenbrockFunction extends MinpackFunction {
RosenbrockFunction(double[] startParams, double theoreticalStartCost) {
super(2, startParams, 0.0, buildArray(2, 1.0));
}
@@ -746,7 +746,7 @@ public class MinpackTest {
}
}
- private static class HelicalValleyFunction extends MinpackFunction {
+ private static final class HelicalValleyFunction extends MinpackFunction {
HelicalValleyFunction(double[] startParams,
double theoreticalStartCost) {
super(3, startParams, 0.0, new double[] { 1.0, 0.0, 0.0 });
@@ -791,7 +791,7 @@ public class MinpackTest {
private static final double twoPi = 2.0 * JdkMath.PI;
}
- private static class PowellSingularFunction extends MinpackFunction {
+ private static final class PowellSingularFunction extends MinpackFunction {
PowellSingularFunction(double[] startParams,
double theoreticalStartCost) {
@@ -830,7 +830,7 @@ public class MinpackTest {
private static final double sqrt10 = JdkMath.sqrt(10.0);
}
- private static class FreudensteinRothFunction extends MinpackFunction {
+ private static final class FreudensteinRothFunction extends
MinpackFunction {
FreudensteinRothFunction(double[] startParams,
double theoreticalStartCost,
@@ -860,7 +860,7 @@ public class MinpackTest {
}
}
- private static class BardFunction extends MinpackFunction {
+ private static final class BardFunction extends MinpackFunction {
BardFunction(double x0,
double theoreticalStartCost,
@@ -908,7 +908,7 @@ public class MinpackTest {
};
}
- private static class KowalikOsborneFunction extends MinpackFunction {
+ private static final class KowalikOsborneFunction extends MinpackFunction {
KowalikOsborneFunction(double[] startParams,
double theoreticalStartCost,
@@ -963,7 +963,7 @@ public class MinpackTest {
};
}
- private static class MeyerFunction extends MinpackFunction {
+ private static final class MeyerFunction extends MinpackFunction {
MeyerFunction(double[] startParams,
double theoreticalStartCost,
@@ -1013,7 +1013,7 @@ public class MinpackTest {
};
}
- private static class WatsonFunction extends MinpackFunction {
+ private static final class WatsonFunction extends MinpackFunction {
WatsonFunction(int n, double x0,
double theoreticalStartCost,
@@ -1083,7 +1083,7 @@ public class MinpackTest {
}
}
- private static class Box3DimensionalFunction extends MinpackFunction {
+ private static final class Box3DimensionalFunction extends MinpackFunction
{
Box3DimensionalFunction(int m, double[] startParams,
double theoreticalStartCost) {
@@ -1122,7 +1122,7 @@ public class MinpackTest {
}
}
- private static class JennrichSampsonFunction extends MinpackFunction {
+ private static final class JennrichSampsonFunction extends MinpackFunction
{
JennrichSampsonFunction(int m, double[] startParams,
double theoreticalStartCost,
@@ -1157,7 +1157,7 @@ public class MinpackTest {
}
}
- private static class BrownDennisFunction extends MinpackFunction {
+ private static final class BrownDennisFunction extends MinpackFunction {
BrownDennisFunction(int m, double[] startParams,
double theoreticalStartCost,
@@ -1204,7 +1204,7 @@ public class MinpackTest {
}
}
- private static class ChebyquadFunction extends MinpackFunction {
+ private static final class ChebyquadFunction extends MinpackFunction {
private static double[] buildChebyquadArray(int n, double factor) {
double[] array = new double[n];
@@ -1281,7 +1281,7 @@ public class MinpackTest {
}
}
- private static class BrownAlmostLinearFunction extends MinpackFunction {
+ private static final class BrownAlmostLinearFunction extends
MinpackFunction {
BrownAlmostLinearFunction(int m, double factor,
double theoreticalStartCost,
@@ -1341,7 +1341,7 @@ public class MinpackTest {
}
}
- private static class Osborne1Function extends MinpackFunction {
+ private static final class Osborne1Function extends MinpackFunction {
Osborne1Function(double[] startParams,
double theoreticalStartCost,
@@ -1393,7 +1393,7 @@ public class MinpackTest {
};
}
- private static class Osborne2Function extends MinpackFunction {
+ private static final class Osborne2Function extends MinpackFunction {
Osborne2Function(double[] startParams,
double theoreticalStartCost,
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/genetics/ElitisticListPopulationTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/genetics/ElitisticListPopulationTest.java
index c5c3503bc..d40ec61ab 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/genetics/ElitisticListPopulationTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/genetics/ElitisticListPopulationTest.java
@@ -89,7 +89,7 @@ public class ElitisticListPopulationTest {
new ElitisticListPopulation(chromosomes, 100, rate);
}
- private static class DummyChromosome extends Chromosome {
+ private static final class DummyChromosome extends Chromosome {
private final int fitness;
DummyChromosome() {
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/genetics/FitnessCachingTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/genetics/FitnessCachingTest.java
index 69df3ca97..0bacd2348 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/genetics/FitnessCachingTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/genetics/FitnessCachingTest.java
@@ -80,7 +80,7 @@ public class FitnessCachingTest {
return new ElitisticListPopulation(popList, popList.size(),
ELITISM_RATE);
}
- private static class DummyCountingBinaryChromosome extends
DummyBinaryChromosome {
+ private static final class DummyCountingBinaryChromosome extends
DummyBinaryChromosome {
DummyCountingBinaryChromosome(List<Integer> representation) {
super(representation);
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/genetics/GeneticAlgorithmTestBinary.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/genetics/GeneticAlgorithmTestBinary.java
index 63e93f7d3..5ac596f05 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/genetics/GeneticAlgorithmTestBinary.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/genetics/GeneticAlgorithmTestBinary.java
@@ -94,7 +94,7 @@ public class GeneticAlgorithmTestBinary {
*
* The goal is to set all bits (genes) to 1.
*/
- private static class FindOnes extends BinaryChromosome {
+ private static final class FindOnes extends BinaryChromosome {
FindOnes(List<Integer> representation) {
super(representation);
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/genetics/GeneticAlgorithmTestPermutations.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/genetics/GeneticAlgorithmTestPermutations.java
index eef810139..400526309 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/genetics/GeneticAlgorithmTestPermutations.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/genetics/GeneticAlgorithmTestPermutations.java
@@ -103,7 +103,7 @@ public class GeneticAlgorithmTestPermutations {
*
* The goal is to sort the sequence.
*/
- private static class MinPermutations extends RandomKey<Integer> {
+ private static final class MinPermutations extends RandomKey<Integer> {
MinPermutations(List<Double> representation) {
super(representation);
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/genetics/TournamentSelectionTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/genetics/TournamentSelectionTest.java
index 126b556a8..67ac41521 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/genetics/TournamentSelectionTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/genetics/TournamentSelectionTest.java
@@ -40,7 +40,7 @@ public class TournamentSelectionTest {
}
}
- private static class DummyChromosome extends Chromosome {
+ private static final class DummyChromosome extends Chromosome {
private final int fitness;
DummyChromosome() {
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/linear/Array2DRowRealMatrixTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/linear/Array2DRowRealMatrixTest.java
index 5a7f971b6..725fb988c 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/linear/Array2DRowRealMatrixTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/linear/Array2DRowRealMatrixTest.java
@@ -1080,14 +1080,14 @@ public final class Array2DRowRealMatrixTest {
}
- private static class SetVisitor extends DefaultRealMatrixChangingVisitor {
+ private static final class SetVisitor extends
DefaultRealMatrixChangingVisitor {
@Override
public double visit(int i, int j, double value) {
return i + j / 1024.0;
}
}
- private static class GetVisitor extends DefaultRealMatrixPreservingVisitor
{
+ private static final class GetVisitor extends
DefaultRealMatrixPreservingVisitor {
private int count = 0;
@Override
public void visit(int i, int j, double value) {
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/linear/BlockFieldMatrixTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/linear/BlockFieldMatrixTest.java
index ecba48e83..626b38944 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/linear/BlockFieldMatrixTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/linear/BlockFieldMatrixTest.java
@@ -1335,7 +1335,7 @@ public final class BlockFieldMatrixTest {
Assert.assertEquals(m,TestUtils.serializeAndRecover(m));
}
- private static class SetVisitor extends
DefaultFieldMatrixChangingVisitor<Dfp> {
+ private static final class SetVisitor extends
DefaultFieldMatrixChangingVisitor<Dfp> {
SetVisitor() {
super(Dfp25.ZERO);
}
@@ -1345,7 +1345,7 @@ public final class BlockFieldMatrixTest {
}
}
- private static class GetVisitor extends
DefaultFieldMatrixPreservingVisitor<Dfp> {
+ private static final class GetVisitor extends
DefaultFieldMatrixPreservingVisitor<Dfp> {
private int count;
GetVisitor() {
super(Dfp25.ZERO);
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/linear/BlockRealMatrixTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/linear/BlockRealMatrixTest.java
index 942567721..81213d860 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/linear/BlockRealMatrixTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/linear/BlockRealMatrixTest.java
@@ -1227,14 +1227,14 @@ public final class BlockRealMatrixTest {
Assert.assertEquals(m,TestUtils.serializeAndRecover(m));
}
- private static class SetVisitor extends DefaultRealMatrixChangingVisitor {
+ private static final class SetVisitor extends
DefaultRealMatrixChangingVisitor {
@Override
public double visit(int i, int j, double value) {
return i + j / 1024.0;
}
}
- private static class GetVisitor extends DefaultRealMatrixPreservingVisitor
{
+ private static final class GetVisitor extends
DefaultRealMatrixPreservingVisitor {
private int count = 0;
@Override
public void visit(int i, int j, double value) {
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/linear/FieldMatrixImplTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/linear/FieldMatrixImplTest.java
index fe5f4c94f..0a37deaf1 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/linear/FieldMatrixImplTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/linear/FieldMatrixImplTest.java
@@ -1068,7 +1068,7 @@ public final class FieldMatrixImplTest {
Assert.assertEquals(m,TestUtils.serializeAndRecover(m));
}
- private static class SetVisitor extends
DefaultFieldMatrixChangingVisitor<Dfp> {
+ private static final class SetVisitor extends
DefaultFieldMatrixChangingVisitor<Dfp> {
SetVisitor() {
super(Dfp25.ZERO);
}
@@ -1078,7 +1078,7 @@ public final class FieldMatrixImplTest {
}
}
- private static class GetVisitor extends
DefaultFieldMatrixPreservingVisitor<Dfp> {
+ private static final class GetVisitor extends
DefaultFieldMatrixPreservingVisitor<Dfp> {
private int count;
GetVisitor() {
super(Dfp25.ZERO);
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ml/clustering/KMeansPlusPlusClustererTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ml/clustering/KMeansPlusPlusClustererTest.java
index 78582a4b4..e1fe18eca 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ml/clustering/KMeansPlusPlusClustererTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ml/clustering/KMeansPlusPlusClustererTest.java
@@ -115,7 +115,7 @@ public class KMeansPlusPlusClustererTest {
* A helper class for testSmallDistances(). This class is similar to
DoublePoint, but
* it defines a different distanceFrom() method that tends to return
distances less than 1.
*/
- private class CloseDistance extends EuclideanDistance {
+ private static final class CloseDistance extends EuclideanDistance {
private static final long serialVersionUID = 1L;
@Override
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/FirstOrderConverterTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/FirstOrderConverterTest.java
index 248ab6601..9212aaa37 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/FirstOrderConverterTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/FirstOrderConverterTest.java
@@ -71,7 +71,7 @@ public class FirstOrderConverterTest {
Assert.assertTrue(JdkMath.abs(error) > 0.1);
}
- private static class Equations
+ private static final class Equations
implements SecondOrderDifferentialEquations {
private int n;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/JacobianMatricesTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/JacobianMatricesTest.java
index 09ebd40ff..782b58c98 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/JacobianMatricesTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/JacobianMatricesTest.java
@@ -307,7 +307,7 @@ public class JacobianMatricesTest {
}
}
- private static class Brusselator extends AbstractParameterizable
+ private static final class Brusselator extends AbstractParameterizable
implements MainStateJacobianProvider, ParameterJacobianProvider {
public static final String B = "b";
@@ -363,7 +363,7 @@ public class JacobianMatricesTest {
}
}
- private static class ParamBrusselator extends AbstractParameterizable
+ private static final class ParamBrusselator extends AbstractParameterizable
implements FirstOrderDifferentialEquations, ParameterizedODE {
public static final String B = "b";
@@ -413,7 +413,7 @@ public class JacobianMatricesTest {
}
/** ODE representing a point moving on a circle with provided center and
angular rate. */
- private static class Circle extends AbstractParameterizable
+ private static final class Circle extends AbstractParameterizable
implements MainStateJacobianProvider, ParameterJacobianProvider {
public static final String CX = "cx";
@@ -512,7 +512,7 @@ public class JacobianMatricesTest {
}
/** ODE representing a point moving on a circle with provided center and
angular rate. */
- private static class ParameterizedCircle extends AbstractParameterizable
+ private static final class ParameterizedCircle extends
AbstractParameterizable
implements FirstOrderDifferentialEquations, ParameterizedODE {
public static final String CX = "cx";
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/TestFieldProblem4.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/TestFieldProblem4.java
index ba5908168..7d8e44a64 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/TestFieldProblem4.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/TestFieldProblem4.java
@@ -105,7 +105,7 @@ public class TestFieldProblem4<T extends
RealFieldElement<T>>
return y;
}
- private static class Bounce<T extends RealFieldElement<T>> implements
FieldEventHandler<T> {
+ private static final class Bounce<T extends RealFieldElement<T>>
implements FieldEventHandler<T> {
private int sign;
@@ -138,7 +138,7 @@ public class TestFieldProblem4<T extends
RealFieldElement<T>>
}
}
- private static class Stop<T extends RealFieldElement<T>> implements
FieldEventHandler<T> {
+ private static final class Stop<T extends RealFieldElement<T>> implements
FieldEventHandler<T> {
Stop() {
}
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/TestProblem4.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/TestProblem4.java
index 418d2ea5f..02e2ed971 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/TestProblem4.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/TestProblem4.java
@@ -91,7 +91,7 @@ public class TestProblem4
return y;
}
- private static class Bounce implements EventHandler {
+ private static final class Bounce implements EventHandler {
private int sign;
@@ -122,7 +122,7 @@ public class TestProblem4
}
}
- private static class Stop implements EventHandler {
+ private static final class Stop implements EventHandler {
Stop() {
}
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/events/CloseEventsTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/events/CloseEventsTest.java
index d35c79a87..cb1bc65f6 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/events/CloseEventsTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/events/CloseEventsTest.java
@@ -71,7 +71,7 @@ public class CloseEventsTest {
/** Trigger an event at a particular time. */
- private static class TimeDetector implements EventHandler {
+ private static final class TimeDetector implements EventHandler {
/** time of the event to trigger. */
private final double eventT;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/events/EventFilterTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/events/EventFilterTest.java
index 0f94f21da..20d69d0e9 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/events/EventFilterTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/events/EventFilterTest.java
@@ -208,7 +208,7 @@ public class EventFilterTest {
Assert.assertEquals(3, onlyDecreasing.getEventCount());
}
- private static class SineCosine implements FirstOrderDifferentialEquations
{
+ private static final class SineCosine implements
FirstOrderDifferentialEquations {
@Override
public int getDimension() {
return 2;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/events/EventStateTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/events/EventStateTest.java
index 7151e43ff..68df42cd1 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/events/EventStateTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/events/EventStateTest.java
@@ -111,7 +111,7 @@ public class EventStateTest {
Assert.assertEquals(32.0, y[0], 1.0e-10);
}
- private static class ResettingEvent implements EventHandler {
+ private static final class ResettingEvent implements EventHandler {
private static double lastTriggerTime = Double.NEGATIVE_INFINITY;
private final double tEvent;
@@ -195,7 +195,7 @@ public class EventStateTest {
Assert.assertEquals(-3.0, equation.getSecondaryState(0)[0], 1.0e-10);
}
- private static class SecondaryStateEvent implements EventHandler {
+ private static final class SecondaryStateEvent implements EventHandler {
private int index;
private final double target;
@@ -252,7 +252,7 @@ public class EventStateTest {
Assert.assertEquals( 9.0 + 1.0 / 128, tEnd, 1.0 / 32.0);
}
- private class CloseEventsGenerator implements EventHandler {
+ private static final class CloseEventsGenerator implements EventHandler {
private final double r1;
private final double r2;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/events/OverlappingEventsTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/events/OverlappingEventsTest.java
index 1d1a40527..3b76d8f14 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/events/OverlappingEventsTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/events/OverlappingEventsTest.java
@@ -131,7 +131,7 @@ public class OverlappingEventsTest implements
FirstOrderDifferentialEquations {
}
/** State events for this unit test. */
- private class Event implements EventHandler {
+ private static final class Event implements EventHandler {
/** The index of the continuous variable to use. */
private final int idx;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/events/ReappearingEventTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/events/ReappearingEventTest.java
index 80b3f241f..af05ff43f 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/events/ReappearingEventTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/events/ReappearingEventTest.java
@@ -64,7 +64,7 @@ public class ReappearingEventTest {
return integrator.integrate(new Ode(), t0, y, tEnd, y);
}
- private static class Ode implements FirstOrderDifferentialEquations {
+ private static final class Ode implements FirstOrderDifferentialEquations {
@Override
public int getDimension() {
return 7;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/AbstractEmbeddedRungeKuttaFieldIntegratorTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/AbstractEmbeddedRungeKuttaFieldIntegratorTest.java
index 3598a2b4c..e59b98828 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/AbstractEmbeddedRungeKuttaFieldIntegratorTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/AbstractEmbeddedRungeKuttaFieldIntegratorTest.java
@@ -431,7 +431,7 @@ public abstract class
AbstractEmbeddedRungeKuttaFieldIntegratorTest {
integ.integrate(new FieldExpandableODE<>(pb), pb.getInitialState(),
pb.getFinalTime());
}
- private static class KeplerHandler<T extends RealFieldElement<T>>
implements FieldStepHandler<T> {
+ private static final class KeplerHandler<T extends RealFieldElement<T>>
implements FieldStepHandler<T> {
private T maxError;
private final TestFieldProblem3<T> pb;
private final double epsilon;
@@ -515,7 +515,7 @@ public abstract class
AbstractEmbeddedRungeKuttaFieldIntegratorTest {
return y.getPartialDerivative(orders);
}
- private static class SinCos implements
FirstOrderFieldDifferentialEquations<DerivativeStructure> {
+ private static final class SinCos implements
FirstOrderFieldDifferentialEquations<DerivativeStructure> {
private final DerivativeStructure omega;
private DerivativeStructure r;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/AbstractRungeKuttaFieldIntegratorTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/AbstractRungeKuttaFieldIntegratorTest.java
index 986682bb9..ecbad0e7c 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/AbstractRungeKuttaFieldIntegratorTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/AbstractRungeKuttaFieldIntegratorTest.java
@@ -374,7 +374,7 @@ public abstract class AbstractRungeKuttaFieldIntegratorTest
{
integ.integrate(new FieldExpandableODE<>(pb), pb.getInitialState(),
pb.getFinalTime());
}
- private static class KeplerHandler<T extends RealFieldElement<T>>
implements FieldStepHandler<T> {
+ private static final class KeplerHandler<T extends RealFieldElement<T>>
implements FieldStepHandler<T> {
private T maxError;
private final TestFieldProblem3<T> pb;
private final double expectedMaxError;
@@ -580,7 +580,7 @@ public abstract class AbstractRungeKuttaFieldIntegratorTest
{
return y.getPartialDerivative(orders);
}
- private static class SinCos implements
FirstOrderFieldDifferentialEquations<DerivativeStructure> {
+ private static final class SinCos implements
FirstOrderFieldDifferentialEquations<DerivativeStructure> {
private final DerivativeStructure omega;
private DerivativeStructure r;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/AdamsBashforthIntegratorTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/AdamsBashforthIntegratorTest.java
index 927328f55..109bb0095 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/AdamsBashforthIntegratorTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/AdamsBashforthIntegratorTest.java
@@ -182,7 +182,7 @@ public class AdamsBashforthIntegratorTest {
pb.getFinalTime(), new double[pb.getDimension()]);
}
- private static class PerfectStarter extends AbstractIntegrator {
+ private static final class PerfectStarter extends AbstractIntegrator {
private final PerfectInterpolator interpolator;
private final int nbSteps;
@@ -208,7 +208,7 @@ public class AdamsBashforthIntegratorTest {
}
}
- private static class PerfectInterpolator implements StepInterpolator {
+ private static final class PerfectInterpolator implements StepInterpolator
{
private final TestProblemAbstract problem;
private double previousTime;
private double currentTime;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/AdamsFieldIntegratorAbstractTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/AdamsFieldIntegratorAbstractTest.java
index 38efcde60..33e8f692a 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/AdamsFieldIntegratorAbstractTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/AdamsFieldIntegratorAbstractTest.java
@@ -181,7 +181,7 @@ public abstract class AdamsFieldIntegratorAbstractTest {
integ.integrate(new FieldExpandableODE<>(pb), pb.getInitialState(),
pb.getFinalTime());
}
- private static class PerfectStarter<T extends RealFieldElement<T>> extends
AbstractFieldIntegrator<T> {
+ private static final class PerfectStarter<T extends RealFieldElement<T>>
extends AbstractFieldIntegrator<T> {
private final PerfectInterpolator<T> interpolator;
private final int nbSteps;
@@ -210,7 +210,7 @@ public abstract class AdamsFieldIntegratorAbstractTest {
}
}
- private static class PerfectInterpolator<T extends RealFieldElement<T>>
implements FieldStepInterpolator<T> {
+ private static final class PerfectInterpolator<T extends
RealFieldElement<T>> implements FieldStepInterpolator<T> {
private final TestFieldProblemAbstract<T> problem;
private T previousTime;
private T currentTime;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/AdamsMoultonIntegratorTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/AdamsMoultonIntegratorTest.java
index 43985c87f..2dae66929 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/AdamsMoultonIntegratorTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/AdamsMoultonIntegratorTest.java
@@ -170,7 +170,7 @@ public class AdamsMoultonIntegratorTest {
}
}
- private static class PerfectStarter extends AbstractIntegrator {
+ private static final class PerfectStarter extends AbstractIntegrator {
private final PerfectInterpolator interpolator;
private final int nbSteps;
@@ -196,7 +196,7 @@ public class AdamsMoultonIntegratorTest {
}
}
- private static class PerfectInterpolator implements StepInterpolator {
+ private static final class PerfectInterpolator implements StepInterpolator
{
private final TestProblemAbstract problem;
private double previousTime;
private double currentTime;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/ClassicalRungeKuttaIntegratorTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/ClassicalRungeKuttaIntegratorTest.java
index 61a93db19..332e0cc23 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/ClassicalRungeKuttaIntegratorTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/ClassicalRungeKuttaIntegratorTest.java
@@ -258,7 +258,7 @@ public class ClassicalRungeKuttaIntegratorTest {
pb.getFinalTime(), new double[pb.getDimension()]);
}
- private static class KeplerHandler implements StepHandler {
+ private static final class KeplerHandler implements StepHandler {
KeplerHandler(TestProblem3 pb) {
this.pb = pb;
maxError = 0;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/DormandPrince54IntegratorTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/DormandPrince54IntegratorTest.java
index 0e3e072ba..36dabf869 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/DormandPrince54IntegratorTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/DormandPrince54IntegratorTest.java
@@ -123,7 +123,7 @@ public class DormandPrince54IntegratorTest {
Assert.assertEquals("Dormand-Prince 5(4)", integ.getName());
}
- private static class DP54SmallLastHandler implements StepHandler {
+ private static final class DP54SmallLastHandler implements StepHandler {
DP54SmallLastHandler(double minStep) {
lastSeen = false;
@@ -269,7 +269,7 @@ public class DormandPrince54IntegratorTest {
Assert.assertEquals(pb.getFinalTime(), stopTime, 1.0e-10);
}
- private static class KeplerHandler implements StepHandler {
+ private static final class KeplerHandler implements StepHandler {
KeplerHandler(TestProblem3 pb) {
this.pb = pb;
}
@@ -309,7 +309,7 @@ public class DormandPrince54IntegratorTest {
private TestProblem3 pb;
}
- private static class VariableHandler implements StepHandler {
+ private static final class VariableHandler implements StepHandler {
VariableHandler() {
firstTime = true;
minStep = 0;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/DormandPrince853IntegratorTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/DormandPrince853IntegratorTest.java
index 14e9394d7..ea5083f31 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/DormandPrince853IntegratorTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/DormandPrince853IntegratorTest.java
@@ -366,7 +366,7 @@ public class DormandPrince853IntegratorTest {
integ.integrate(sincos, t0, y0, t, y);
}
- private static class SchedulingChecker implements StepHandler, EventHandler {
+ private static final class SchedulingChecker implements StepHandler,
EventHandler {
private int index;
private double tMin;
@@ -404,7 +404,7 @@ public class DormandPrince853IntegratorTest {
}
}
- private static class KeplerHandler implements StepHandler {
+ private static final class KeplerHandler implements StepHandler {
KeplerHandler(TestProblem3 pb) {
this.pb = pb;
}
@@ -444,7 +444,7 @@ public class DormandPrince853IntegratorTest {
private TestProblem3 pb;
}
- private static class VariableHandler implements StepHandler {
+ private static final class VariableHandler implements StepHandler {
VariableHandler() {
firstTime = true;
minStep = 0;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/EmbeddedRungeKuttaFieldIntegratorAbstractTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/EmbeddedRungeKuttaFieldIntegratorAbstractTest.java
index 141a89364..5abaee5b4 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/EmbeddedRungeKuttaFieldIntegratorAbstractTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/EmbeddedRungeKuttaFieldIntegratorAbstractTest.java
@@ -431,7 +431,7 @@ public abstract class
EmbeddedRungeKuttaFieldIntegratorAbstractTest {
integ.integrate(new FieldExpandableODE<>(pb), pb.getInitialState(),
pb.getFinalTime());
}
- private static class KeplerHandler<T extends RealFieldElement<T>>
implements FieldStepHandler<T> {
+ private static final class KeplerHandler<T extends RealFieldElement<T>>
implements FieldStepHandler<T> {
private T maxError;
private final TestFieldProblem3<T> pb;
private final double epsilon;
@@ -515,7 +515,7 @@ public abstract class
EmbeddedRungeKuttaFieldIntegratorAbstractTest {
return y.getPartialDerivative(orders);
}
- private static class SinCos implements
FirstOrderFieldDifferentialEquations<DerivativeStructure> {
+ private static final class SinCos implements
FirstOrderFieldDifferentialEquations<DerivativeStructure> {
private final DerivativeStructure omega;
private DerivativeStructure r;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/EulerStepInterpolatorTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/EulerStepInterpolatorTest.java
index 2e6bc7ff2..0fb9866be 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/EulerStepInterpolatorTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/EulerStepInterpolatorTest.java
@@ -178,7 +178,7 @@ public class EulerStepInterpolatorTest {
Assert.assertTrue(maxError < 0.001);
}
- private static class DummyIntegrator extends RungeKuttaIntegrator {
+ private static final class DummyIntegrator extends RungeKuttaIntegrator {
protected DummyIntegrator(RungeKuttaStepInterpolator prototype) {
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/GillIntegratorTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/GillIntegratorTest.java
index aecdff125..44c16a29f 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/GillIntegratorTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/GillIntegratorTest.java
@@ -183,7 +183,7 @@ public class GillIntegratorTest {
Assert.assertEquals(8.0, y[0], 1.0e-12);
}
- private static class KeplerStepHandler implements StepHandler {
+ private static final class KeplerStepHandler implements StepHandler {
KeplerStepHandler(TestProblem3 pb) {
this.pb = pb;
}
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/GraggBulirschStoerIntegratorTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/GraggBulirschStoerIntegratorTest.java
index ee141dcf2..316efe31c 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/GraggBulirschStoerIntegratorTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/GraggBulirschStoerIntegratorTest.java
@@ -343,7 +343,7 @@ public class GraggBulirschStoerIntegratorTest {
}, t0, y, tend, y);
}
- private static class KeplerStepHandler implements StepHandler {
+ private static final class KeplerStepHandler implements StepHandler {
KeplerStepHandler(TestProblem3 pb) {
this.pb = pb;
}
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/HighamHall54IntegratorTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/HighamHall54IntegratorTest.java
index 8993f2ca9..253dd7750 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/HighamHall54IntegratorTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/HighamHall54IntegratorTest.java
@@ -234,7 +234,7 @@ public class HighamHall54IntegratorTest {
pb.getFinalTime(), new double[pb.getDimension()]);
}
- private static class LocalException extends RuntimeException {
+ private static final class LocalException extends RuntimeException {
private static final long serialVersionUID = 3041292643919807960L;
}
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/LutherIntegratorTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/LutherIntegratorTest.java
index 718cb8efd..9f7ba5fe0 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/LutherIntegratorTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/LutherIntegratorTest.java
@@ -258,7 +258,7 @@ public class LutherIntegratorTest {
pb.getFinalTime(), new double[pb.getDimension()]);
}
- private static class KeplerHandler implements StepHandler {
+ private static final class KeplerHandler implements StepHandler {
KeplerHandler(TestProblem3 pb) {
this.pb = pb;
maxError = 0;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/RungeKuttaFieldIntegratorAbstractTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/RungeKuttaFieldIntegratorAbstractTest.java
index 6364cdf86..2b2442776 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/RungeKuttaFieldIntegratorAbstractTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/RungeKuttaFieldIntegratorAbstractTest.java
@@ -374,7 +374,7 @@ public abstract class RungeKuttaFieldIntegratorAbstractTest
{
integ.integrate(new FieldExpandableODE<>(pb), pb.getInitialState(),
pb.getFinalTime());
}
- private static class KeplerHandler<T extends RealFieldElement<T>>
implements FieldStepHandler<T> {
+ private static final class KeplerHandler<T extends RealFieldElement<T>>
implements FieldStepHandler<T> {
private T maxError;
private final TestFieldProblem3<T> pb;
private final double expectedMaxError;
@@ -580,7 +580,7 @@ public abstract class RungeKuttaFieldIntegratorAbstractTest
{
return y.getPartialDerivative(orders);
}
- private static class SinCos implements
FirstOrderFieldDifferentialEquations<DerivativeStructure> {
+ private static final class SinCos implements
FirstOrderFieldDifferentialEquations<DerivativeStructure> {
private final DerivativeStructure omega;
private DerivativeStructure r;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/RungeKuttaFieldStepInterpolatorAbstractTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/RungeKuttaFieldStepInterpolatorAbstractTest.java
index a95a7132d..e798c6726 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/RungeKuttaFieldStepInterpolatorAbstractTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/RungeKuttaFieldStepInterpolatorAbstractTest.java
@@ -277,7 +277,7 @@ public abstract class
RungeKuttaFieldStepInterpolatorAbstractTest {
return regularInterpolator;
}
- private static class SinCos<T extends RealFieldElement<T>> implements
FirstOrderFieldDifferentialEquations<T> {
+ private static final class SinCos<T extends RealFieldElement<T>>
implements FirstOrderFieldDifferentialEquations<T> {
private final Field<T> field;
protected SinCos(final Field<T> field) {
this.field = field;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/ThreeEighthesIntegratorTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/ThreeEighthesIntegratorTest.java
index 31346d73a..cd34f7bb0 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/ThreeEighthesIntegratorTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/nonstiff/ThreeEighthesIntegratorTest.java
@@ -171,7 +171,7 @@ public class ThreeEighthesIntegratorTest {
pb.getFinalTime(), new double[pb.getDimension()]);
}
- private static class KeplerHandler implements StepHandler {
+ private static final class KeplerHandler implements StepHandler {
KeplerHandler(TestProblem3 pb) {
this.pb = pb;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/sampling/DummyStepInterpolatorTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/sampling/DummyStepInterpolatorTest.java
index d9a933c70..0cf51e731 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/sampling/DummyStepInterpolatorTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ode/sampling/DummyStepInterpolatorTest.java
@@ -116,7 +116,7 @@ public class DummyStepInterpolatorTest {
}
}
- private static class BadStepInterpolator extends DummyStepInterpolator {
+ private static final class BadStepInterpolator extends DummyStepInterpolator
{
BadStepInterpolator(double[] y, boolean forward) {
super(y, new double[y.length], forward);
}
@@ -126,7 +126,7 @@ public class DummyStepInterpolatorTest {
}
}
- private static class LocalException extends RuntimeException {
+ private static final class LocalException extends RuntimeException {
private static final long serialVersionUID = 1L;
}
}
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/MultiStartMultivariateOptimizerTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/MultiStartMultivariateOptimizerTest.java
index 2e1137248..1bb10d1bd 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/MultiStartMultivariateOptimizerTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/MultiStartMultivariateOptimizerTest.java
@@ -113,7 +113,7 @@ public class MultiStartMultivariateOptimizerTest {
Assert.assertTrue("optimum=" + optimum.getValue(), optimum.getValue()
< 5e-5);
}
- private static class Rosenbrock implements MultivariateFunction {
+ private static final class Rosenbrock implements MultivariateFunction {
private int count;
Rosenbrock() {
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/MultivariateFunctionMappingAdapterTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/MultivariateFunctionMappingAdapterTest.java
index b052430d2..a57e9312a 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/MultivariateFunctionMappingAdapterTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/MultivariateFunctionMappingAdapterTest.java
@@ -143,7 +143,7 @@ public class MultivariateFunctionMappingAdapterTest {
Assert.assertEquals(biQuadratic.getBoundedYOptimum(), bounded[1],
1e-7);
}
- private static class BiQuadratic implements MultivariateFunction {
+ private static final class BiQuadratic implements MultivariateFunction {
private final double xOptimum;
private final double yOptimum;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/MultivariateFunctionPenaltyAdapterTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/MultivariateFunctionPenaltyAdapterTest.java
index a37baab43..cb33dac8a 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/MultivariateFunctionPenaltyAdapterTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/MultivariateFunctionPenaltyAdapterTest.java
@@ -147,7 +147,7 @@ public class MultivariateFunctionPenaltyAdapterTest {
Assert.assertEquals(biQuadratic.getBoundedYOptimum(),
optimum.getPoint()[1], 2e-7);
}
- private static class BiQuadratic implements MultivariateFunction {
+ private static final class BiQuadratic implements MultivariateFunction {
private final double xOptimum;
private final double yOptimum;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/gradient/NonLinearConjugateGradientOptimizerTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/gradient/NonLinearConjugateGradientOptimizerTest.java
index 9864fcb3d..dab879ae8 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/gradient/NonLinearConjugateGradientOptimizerTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/gradient/NonLinearConjugateGradientOptimizerTest.java
@@ -430,7 +430,7 @@ public class NonLinearConjugateGradientOptimizerTest {
Assert.assertEquals(48.135167894, center.getY(), 1.0e-6);
}
- private static class LinearProblem {
+ private static final class LinearProblem {
private final RealMatrix factors;
private final double[] target;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/noderiv/OptimTestUtils.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/noderiv/OptimTestUtils.java
index f0962eee6..e1765002a 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/noderiv/OptimTestUtils.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/noderiv/OptimTestUtils.java
@@ -117,7 +117,7 @@ final class OptimTestUtils {
return ThreadLocalRandomSource.current(RandomSource.MWC_256);
}
- private static class Basis {
+ private static final class Basis {
private double[][] basis;
private final MarsagliaNormalizedGaussianSampler rand =
MarsagliaNormalizedGaussianSampler.of(rng()); // use not always the same basis
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/noderiv/SimplexOptimizerMultiDirectionalTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/noderiv/SimplexOptimizerMultiDirectionalTest.java
index cab242d82..66928f0c7 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/noderiv/SimplexOptimizerMultiDirectionalTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/noderiv/SimplexOptimizerMultiDirectionalTest.java
@@ -176,7 +176,7 @@ public class SimplexOptimizerMultiDirectionalTest {
nEval < maxEvaluations);
}
- private static class Gaussian2D implements MultivariateFunction {
+ private static final class Gaussian2D implements MultivariateFunction {
private final double[] maximumPosition;
private final double std;
diff --git
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/univariate/MultiStartUnivariateOptimizerTest.java
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/univariate/MultiStartUnivariateOptimizerTest.java
index 27f2992e3..43cf2951c 100644
---
a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/univariate/MultiStartUnivariateOptimizerTest.java
+++
b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/univariate/MultiStartUnivariateOptimizerTest.java
@@ -121,7 +121,7 @@ public class MultiStartUnivariateOptimizerTest {
Assert.assertNull(optimizer.getOptima()[0]);
}
- private static class LocalException extends RuntimeException {
+ private static final class LocalException extends RuntimeException {
private static final long serialVersionUID = 1194682757034350629L;
}
}
