This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-pool.git
The following commit(s) were added to refs/heads/master by this push: new 1fbad023 Remove extra blank lines 1fbad023 is described below commit 1fbad023f462e04187abc01832916980d2e4413c Author: Gary Gregory <garydgreg...@gmail.com> AuthorDate: Sun Nov 26 14:11:27 2023 -0500 Remove extra blank lines --- .../org/apache/commons/pool3/impl/BaseGenericObjectPool.java | 1 - .../java/org/apache/commons/pool3/impl/BaseObjectPoolConfig.java | 1 - .../java/org/apache/commons/pool3/impl/DefaultPooledObject.java | 1 - .../org/apache/commons/pool3/impl/DefaultPooledObjectInfo.java | 1 - src/main/java/org/apache/commons/pool3/impl/EvictionTimer.java | 2 -- .../org/apache/commons/pool3/impl/GenericKeyedObjectPool.java | 6 ------ .../apache/commons/pool3/impl/GenericKeyedObjectPoolConfig.java | 1 - .../org/apache/commons/pool3/impl/GenericObjectPoolConfig.java | 3 --- .../java/org/apache/commons/pool3/impl/LinkedBlockingDeque.java | 1 - .../org/apache/commons/pool3/impl/SoftReferenceObjectPool.java | 1 - .../java/org/apache/commons/pool3/proxy/BaseProxyHandler.java | 6 ------ .../java/org/apache/commons/pool3/proxy/CglibProxyHandler.java | 1 - .../java/org/apache/commons/pool3/proxy/CglibProxySource.java | 1 - .../java/org/apache/commons/pool3/proxy/JdkProxyHandler.java | 1 - .../org/apache/commons/pool3/proxy/ProxiedKeyedObjectPool.java | 2 -- .../java/org/apache/commons/pool3/proxy/ProxiedObjectPool.java | 8 -------- .../org/apache/commons/pool3/AbstractTestKeyedObjectPool.java | 2 -- .../java/org/apache/commons/pool3/AbstractTestObjectPool.java | 3 --- src/test/java/org/apache/commons/pool3/PoolTest.java | 1 - .../java/org/apache/commons/pool3/impl/AtomicIntegerFactory.java | 5 ----- .../java/org/apache/commons/pool3/impl/TestEvictionTimer.java | 1 - .../apache/commons/pool3/impl/TestGenericKeyedObjectPool.java | 9 --------- .../org/apache/commons/pool3/impl/TestGenericObjectPool.java | 4 ---- .../org/apache/commons/pool3/impl/TestPooledSoftReference.java | 2 -- .../org/apache/commons/pool3/impl/TestSoftRefOutOfMemory.java | 1 - .../apache/commons/pool3/impl/TestSoftReferenceObjectPool.java | 1 - .../java/org/apache/commons/pool3/pool407/KeyedPool407Test.java | 1 - .../commons/pool3/proxy/AbstractTestProxiedKeyedObjectPool.java | 9 --------- .../commons/pool3/proxy/AbstractTestProxiedObjectPool.java | 9 --------- 29 files changed, 85 deletions(-) diff --git a/src/main/java/org/apache/commons/pool3/impl/BaseGenericObjectPool.java b/src/main/java/org/apache/commons/pool3/impl/BaseGenericObjectPool.java index 29572e76..a60216dd 100644 --- a/src/main/java/org/apache/commons/pool3/impl/BaseGenericObjectPool.java +++ b/src/main/java/org/apache/commons/pool3/impl/BaseGenericObjectPool.java @@ -1772,5 +1772,4 @@ public abstract class BaseGenericObjectPool<T, E extends Exception> extends Base activeTimes.add(activeTime); } - } diff --git a/src/main/java/org/apache/commons/pool3/impl/BaseObjectPoolConfig.java b/src/main/java/org/apache/commons/pool3/impl/BaseObjectPoolConfig.java index fe9ad5be..54bc29c1 100644 --- a/src/main/java/org/apache/commons/pool3/impl/BaseObjectPoolConfig.java +++ b/src/main/java/org/apache/commons/pool3/impl/BaseObjectPoolConfig.java @@ -204,7 +204,6 @@ public abstract class BaseObjectPoolConfig<T> extends BaseObject implements Clon private String jmxNameBase = DEFAULT_JMX_NAME_BASE; - /** * Gets the value for the {@code blockWhenExhausted} configuration attribute * for pools created with this configuration instance. diff --git a/src/main/java/org/apache/commons/pool3/impl/DefaultPooledObject.java b/src/main/java/org/apache/commons/pool3/impl/DefaultPooledObject.java index 504401e3..de826805 100644 --- a/src/main/java/org/apache/commons/pool3/impl/DefaultPooledObject.java +++ b/src/main/java/org/apache/commons/pool3/impl/DefaultPooledObject.java @@ -296,5 +296,4 @@ public class DefaultPooledObject<T> implements PooledObject<T> { usedBy.fillInStackTrace(); } - } \ No newline at end of file diff --git a/src/main/java/org/apache/commons/pool3/impl/DefaultPooledObjectInfo.java b/src/main/java/org/apache/commons/pool3/impl/DefaultPooledObjectInfo.java index bc478e63..cf215153 100644 --- a/src/main/java/org/apache/commons/pool3/impl/DefaultPooledObjectInfo.java +++ b/src/main/java/org/apache/commons/pool3/impl/DefaultPooledObjectInfo.java @@ -65,7 +65,6 @@ public class DefaultPooledObjectInfo implements DefaultPooledObjectInfoMBean { return pooledObject.getLastBorrowInstant().toEpochMilli(); } - @Override public String getLastBorrowTimeFormatted() { return getTimeMillisFormatted(getLastBorrowTime()); diff --git a/src/main/java/org/apache/commons/pool3/impl/EvictionTimer.java b/src/main/java/org/apache/commons/pool3/impl/EvictionTimer.java index 7bbfcb3f..ac49f34e 100644 --- a/src/main/java/org/apache/commons/pool3/impl/EvictionTimer.java +++ b/src/main/java/org/apache/commons/pool3/impl/EvictionTimer.java @@ -27,7 +27,6 @@ import java.util.concurrent.ScheduledThreadPoolExecutor; import java.util.concurrent.ThreadFactory; import java.util.concurrent.TimeUnit; - /** * Provides a shared idle object eviction timer for all pools. * <p> @@ -120,7 +119,6 @@ final class EvictionTimer { } } - /** Executor instance */ private static ScheduledThreadPoolExecutor executor; //@GuardedBy("EvictionTimer.class") diff --git a/src/main/java/org/apache/commons/pool3/impl/GenericKeyedObjectPool.java b/src/main/java/org/apache/commons/pool3/impl/GenericKeyedObjectPool.java index 638fb080..2d799ab1 100644 --- a/src/main/java/org/apache/commons/pool3/impl/GenericKeyedObjectPool.java +++ b/src/main/java/org/apache/commons/pool3/impl/GenericKeyedObjectPool.java @@ -201,7 +201,6 @@ public class GenericKeyedObjectPool<K, T, E extends Exception> extends BaseGener private volatile int minIdlePerKey = GenericKeyedObjectPoolConfig.DEFAULT_MIN_IDLE_PER_KEY; - private volatile int maxTotalPerKey = GenericKeyedObjectPoolConfig.DEFAULT_MAX_TOTAL_PER_KEY; @@ -237,7 +236,6 @@ public class GenericKeyedObjectPool<K, T, E extends Exception> extends BaseGener private Iterator<K> evictionKeyIterator; // @GuardedBy("evictionLock") - private K evictionKey; // @GuardedBy("evictionLock") /** @@ -681,7 +679,6 @@ public class GenericKeyedObjectPool<K, T, E extends Exception> extends BaseGener } } - /** * Closes the keyed object pool. Once the pool is closed, * {@link #borrowObject(Object)} will fail with IllegalStateException, but @@ -721,7 +718,6 @@ public class GenericKeyedObjectPool<K, T, E extends Exception> extends BaseGener } } - /** * Creates a new pooled object or null. * @@ -913,7 +909,6 @@ public class GenericKeyedObjectPool<K, T, E extends Exception> extends BaseGener } } - @Override void ensureMinIdle() throws E { final int minIdlePerKeySave = getMinIdlePerKey(); @@ -1114,7 +1109,6 @@ public class GenericKeyedObjectPool<K, T, E extends Exception> extends BaseGener } } - /** * Gets a reference to the factory used to create, destroy and validate * the objects used by this pool. diff --git a/src/main/java/org/apache/commons/pool3/impl/GenericKeyedObjectPoolConfig.java b/src/main/java/org/apache/commons/pool3/impl/GenericKeyedObjectPoolConfig.java index 74b3b84d..76725420 100644 --- a/src/main/java/org/apache/commons/pool3/impl/GenericKeyedObjectPoolConfig.java +++ b/src/main/java/org/apache/commons/pool3/impl/GenericKeyedObjectPoolConfig.java @@ -54,7 +54,6 @@ public class GenericKeyedObjectPoolConfig<T> extends BaseObjectPoolConfig<T> { */ public static final int DEFAULT_MAX_IDLE_PER_KEY = 8; - private int minIdlePerKey = DEFAULT_MIN_IDLE_PER_KEY; private int maxIdlePerKey = DEFAULT_MAX_IDLE_PER_KEY; diff --git a/src/main/java/org/apache/commons/pool3/impl/GenericObjectPoolConfig.java b/src/main/java/org/apache/commons/pool3/impl/GenericObjectPoolConfig.java index 4f4b677d..777b2135 100644 --- a/src/main/java/org/apache/commons/pool3/impl/GenericObjectPoolConfig.java +++ b/src/main/java/org/apache/commons/pool3/impl/GenericObjectPoolConfig.java @@ -48,7 +48,6 @@ public class GenericObjectPoolConfig<T> extends BaseObjectPoolConfig<T> { */ public static final int DEFAULT_MIN_IDLE = 0; - private int maxTotal = DEFAULT_MAX_TOTAL; private int maxIdle = DEFAULT_MAX_IDLE; @@ -78,7 +77,6 @@ public class GenericObjectPoolConfig<T> extends BaseObjectPoolConfig<T> { return maxIdle; } - /** * Gets the value for the {@code maxTotal} configuration attribute * for pools created with this configuration instance. @@ -105,7 +103,6 @@ public class GenericObjectPoolConfig<T> extends BaseObjectPoolConfig<T> { return minIdle; } - /** * Sets the value for the {@code maxIdle} configuration attribute for * pools created with this configuration instance. diff --git a/src/main/java/org/apache/commons/pool3/impl/LinkedBlockingDeque.java b/src/main/java/org/apache/commons/pool3/impl/LinkedBlockingDeque.java index 5cee374b..bcc2ae81 100644 --- a/src/main/java/org/apache/commons/pool3/impl/LinkedBlockingDeque.java +++ b/src/main/java/org/apache/commons/pool3/impl/LinkedBlockingDeque.java @@ -327,7 +327,6 @@ final class LinkedBlockingDeque<E> extends AbstractQueue<E> this(Integer.MAX_VALUE, fairness); } - // Basic linking and unlinking operations, called only while holding lock /** diff --git a/src/main/java/org/apache/commons/pool3/impl/SoftReferenceObjectPool.java b/src/main/java/org/apache/commons/pool3/impl/SoftReferenceObjectPool.java index 5cf8e65b..dc2e11d4 100644 --- a/src/main/java/org/apache/commons/pool3/impl/SoftReferenceObjectPool.java +++ b/src/main/java/org/apache/commons/pool3/impl/SoftReferenceObjectPool.java @@ -61,7 +61,6 @@ public class SoftReferenceObjectPool<T, E extends Exception> extends BaseObjectP /** Total number of instances that have been destroyed */ private long destroyCount; // @GuardedBy("this") - /** Total number of instances that have been created */ private long createCount; // @GuardedBy("this") diff --git a/src/main/java/org/apache/commons/pool3/proxy/BaseProxyHandler.java b/src/main/java/org/apache/commons/pool3/proxy/BaseProxyHandler.java index 612393d8..8af3d809 100644 --- a/src/main/java/org/apache/commons/pool3/proxy/BaseProxyHandler.java +++ b/src/main/java/org/apache/commons/pool3/proxy/BaseProxyHandler.java @@ -33,7 +33,6 @@ class BaseProxyHandler<T> { private volatile T pooledObject; private final UsageTracking<T> usageTracking; - /** * Constructs a new wrapper for the given pooled object. * @@ -47,7 +46,6 @@ class BaseProxyHandler<T> { this.usageTracking = usageTracking; } - /** * Disable the proxy wrapper. Called when the object has been returned to * the pool. Further use of the wrapper should result in an @@ -61,7 +59,6 @@ class BaseProxyHandler<T> { return result; } - /** * Invoke the given method on the wrapped object. * @@ -79,7 +76,6 @@ class BaseProxyHandler<T> { return method.invoke(object, args); } - /** * Gets the wrapped, pooled object. * @@ -89,7 +85,6 @@ class BaseProxyHandler<T> { return pooledObject; } - /** * @since 2.4.3 */ @@ -105,7 +100,6 @@ class BaseProxyHandler<T> { return builder.toString(); } - /** * Check that the proxy is still valid (i.e. that {@link #disableProxy()} * has not been called). diff --git a/src/main/java/org/apache/commons/pool3/proxy/CglibProxyHandler.java b/src/main/java/org/apache/commons/pool3/proxy/CglibProxyHandler.java index 83640696..635a6a7c 100644 --- a/src/main/java/org/apache/commons/pool3/proxy/CglibProxyHandler.java +++ b/src/main/java/org/apache/commons/pool3/proxy/CglibProxyHandler.java @@ -33,7 +33,6 @@ import net.sf.cglib.proxy.MethodProxy; final class CglibProxyHandler<T> extends BaseProxyHandler<T> implements MethodInterceptor { - /** * Constructs a CGLib proxy instance. * diff --git a/src/main/java/org/apache/commons/pool3/proxy/CglibProxySource.java b/src/main/java/org/apache/commons/pool3/proxy/CglibProxySource.java index 46d80b35..bff89b1c 100644 --- a/src/main/java/org/apache/commons/pool3/proxy/CglibProxySource.java +++ b/src/main/java/org/apache/commons/pool3/proxy/CglibProxySource.java @@ -54,7 +54,6 @@ public class CglibProxySource<T> implements ProxySource<T> { return (T) enhancer.create(); } - @Override public T resolveProxy(final T proxy) { @SuppressWarnings("unchecked") diff --git a/src/main/java/org/apache/commons/pool3/proxy/JdkProxyHandler.java b/src/main/java/org/apache/commons/pool3/proxy/JdkProxyHandler.java index 4c71ea01..58d2d614 100644 --- a/src/main/java/org/apache/commons/pool3/proxy/JdkProxyHandler.java +++ b/src/main/java/org/apache/commons/pool3/proxy/JdkProxyHandler.java @@ -43,7 +43,6 @@ final class JdkProxyHandler<T> extends BaseProxyHandler<T> super(pooledObject, usageTracking); } - @Override public Object invoke(final Object proxy, final Method method, final Object[] args) throws Throwable { diff --git a/src/main/java/org/apache/commons/pool3/proxy/ProxiedKeyedObjectPool.java b/src/main/java/org/apache/commons/pool3/proxy/ProxiedKeyedObjectPool.java index b7c53acd..1a3a31e7 100644 --- a/src/main/java/org/apache/commons/pool3/proxy/ProxiedKeyedObjectPool.java +++ b/src/main/java/org/apache/commons/pool3/proxy/ProxiedKeyedObjectPool.java @@ -39,7 +39,6 @@ public class ProxiedKeyedObjectPool<K, V, E extends Exception> implements KeyedO private final KeyedObjectPool<K, V, E> pool; private final ProxySource<V> proxySource; - /** * Constructs a new proxied object pool. * @@ -52,7 +51,6 @@ public class ProxiedKeyedObjectPool<K, V, E extends Exception> implements KeyedO this.proxySource = proxySource; } - @Override public void addObject(final K key) throws E, IllegalStateException, UnsupportedOperationException { diff --git a/src/main/java/org/apache/commons/pool3/proxy/ProxiedObjectPool.java b/src/main/java/org/apache/commons/pool3/proxy/ProxiedObjectPool.java index fbe1a707..24f3fa1d 100644 --- a/src/main/java/org/apache/commons/pool3/proxy/ProxiedObjectPool.java +++ b/src/main/java/org/apache/commons/pool3/proxy/ProxiedObjectPool.java @@ -37,7 +37,6 @@ public class ProxiedObjectPool<T, E extends Exception> implements ObjectPool<T, private final ObjectPool<T, E> pool; private final ProxySource<T> proxySource; - /** * Constructs a new proxied object pool. * @@ -54,7 +53,6 @@ public class ProxiedObjectPool<T, E extends Exception> implements ObjectPool<T, pool.addObject(); } - @SuppressWarnings("unchecked") @Override public T borrowObject() throws E, NoSuchElementException, IllegalStateException { @@ -65,37 +63,31 @@ public class ProxiedObjectPool<T, E extends Exception> implements ObjectPool<T, return proxySource.createProxy(pool.borrowObject(), usageTracking); } - @Override public void clear() throws E, UnsupportedOperationException { pool.clear(); } - @Override public void close() { pool.close(); } - @Override public int getNumActive() { return pool.getNumActive(); } - @Override public int getNumIdle() { return pool.getNumIdle(); } - @Override public void invalidateObject(final T proxy) throws E { pool.invalidateObject(proxySource.resolveProxy(proxy)); } - @Override public void returnObject(final T proxy) throws E { pool.returnObject(proxySource.resolveProxy(proxy)); diff --git a/src/test/java/org/apache/commons/pool3/AbstractTestKeyedObjectPool.java b/src/test/java/org/apache/commons/pool3/AbstractTestKeyedObjectPool.java index b83fbac6..be26c168 100644 --- a/src/test/java/org/apache/commons/pool3/AbstractTestKeyedObjectPool.java +++ b/src/test/java/org/apache/commons/pool3/AbstractTestKeyedObjectPool.java @@ -577,7 +577,6 @@ public abstract class AbstractTestKeyedObjectPool { expectedMethods.add(new MethodCall("makeObject", KEY)); assertEquals(expectedMethods, factory.getMethodCalls()); - // when activateObject fails in borrowObject, a new object should be borrowed/created reset(pool, factory, expectedMethods); pool.addObject(KEY); @@ -637,7 +636,6 @@ public abstract class AbstractTestKeyedObjectPool { pool.close(); } - @Test public void testKPOFCloseUsages() { final FailingKeyedPooledObjectFactory factory = new FailingKeyedPooledObjectFactory(); diff --git a/src/test/java/org/apache/commons/pool3/AbstractTestObjectPool.java b/src/test/java/org/apache/commons/pool3/AbstractTestObjectPool.java index a59fb140..73a703c4 100644 --- a/src/test/java/org/apache/commons/pool3/AbstractTestObjectPool.java +++ b/src/test/java/org/apache/commons/pool3/AbstractTestObjectPool.java @@ -16,7 +16,6 @@ */ package org.apache.commons.pool3; - import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; @@ -198,7 +197,6 @@ public abstract class AbstractTestObjectPool { expectedMethods.add(new MethodCall("makeObject")); assertEquals(expectedMethods, factory.getMethodCalls()); - // when activateObject fails in borrowObject, a new object should be borrowed/created reset(pool, factory, expectedMethods); pool.addObject(); @@ -273,7 +271,6 @@ public abstract class AbstractTestObjectPool { pool.addObjects(5); pool.close(); - // Test exception handling close should swallow failures try { pool = makeEmptyPool(factory); diff --git a/src/test/java/org/apache/commons/pool3/PoolTest.java b/src/test/java/org/apache/commons/pool3/PoolTest.java index a090e28b..f64b7104 100644 --- a/src/test/java/org/apache/commons/pool3/PoolTest.java +++ b/src/test/java/org/apache/commons/pool3/PoolTest.java @@ -17,7 +17,6 @@ package org.apache.commons.pool3; - import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; diff --git a/src/test/java/org/apache/commons/pool3/impl/AtomicIntegerFactory.java b/src/test/java/org/apache/commons/pool3/impl/AtomicIntegerFactory.java index db9dc84a..be8f797b 100644 --- a/src/test/java/org/apache/commons/pool3/impl/AtomicIntegerFactory.java +++ b/src/test/java/org/apache/commons/pool3/impl/AtomicIntegerFactory.java @@ -74,7 +74,6 @@ public class AtomicIntegerFactory this.createLatency = createLatency; } - /** * @param destroyLatency the destroyLatency to set */ @@ -82,7 +81,6 @@ public class AtomicIntegerFactory this.destroyLatency = destroyLatency; } - /** * @param passivateLatency the passivateLatency to set */ @@ -90,7 +88,6 @@ public class AtomicIntegerFactory this.passivateLatency = passivateLatency; } - /** * @param validateLatency the validateLatency to set */ @@ -98,14 +95,12 @@ public class AtomicIntegerFactory this.validateLatency = validateLatency; } - @Override public boolean validateObject(final PooledObject<AtomicInteger> instance) { Waiter.sleepQuietly(validateLatency); return instance.getObject().intValue() == 1; } - @Override public PooledObject<AtomicInteger> wrap(final AtomicInteger integer) { return new DefaultPooledObject<>(integer); diff --git a/src/test/java/org/apache/commons/pool3/impl/TestEvictionTimer.java b/src/test/java/org/apache/commons/pool3/impl/TestEvictionTimer.java index e8fbaf93..38e91568 100644 --- a/src/test/java/org/apache/commons/pool3/impl/TestEvictionTimer.java +++ b/src/test/java/org/apache/commons/pool3/impl/TestEvictionTimer.java @@ -16,7 +16,6 @@ */ package org.apache.commons.pool3.impl; - import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertNull; diff --git a/src/test/java/org/apache/commons/pool3/impl/TestGenericKeyedObjectPool.java b/src/test/java/org/apache/commons/pool3/impl/TestGenericKeyedObjectPool.java index 7d8d0ecf..a30f1745 100644 --- a/src/test/java/org/apache/commons/pool3/impl/TestGenericKeyedObjectPool.java +++ b/src/test/java/org/apache/commons/pool3/impl/TestGenericKeyedObjectPool.java @@ -17,7 +17,6 @@ package org.apache.commons.pool3.impl; - import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertNotEquals; @@ -800,7 +799,6 @@ public class TestGenericKeyedObjectPool extends AbstractTestKeyedObjectPool { return String.valueOf(key) + String.valueOf(n); } - @Override protected boolean isFifo() { return false; @@ -1200,7 +1198,6 @@ public class TestGenericKeyedObjectPool extends AbstractTestKeyedObjectPool { } } - /** * Tests POOL-411, or least tries to reproduce the NPE, but does not. * @@ -1644,7 +1641,6 @@ public class TestGenericKeyedObjectPool extends AbstractTestKeyedObjectPool { assertEquals(0, gkoPool.getNumIdle()); } - @Test @Timeout(value = 60_000, unit = TimeUnit.MILLISECONDS) public void testExceptionOnActivateDuringBorrow() throws Exception { @@ -2122,7 +2118,6 @@ public class TestGenericKeyedObjectPool extends AbstractTestKeyedObjectPool { assertThrows(NoSuchElementException.class, () -> gkoPool.borrowObject("")); } - @Test @Timeout(value = 60_000, unit = TimeUnit.MILLISECONDS) public void testMaxTotalPerKeyZero() { @@ -2132,7 +2127,6 @@ public class TestGenericKeyedObjectPool extends AbstractTestKeyedObjectPool { assertThrows(NoSuchElementException.class, () -> gkoPool.borrowObject("a")); } - /** * Verifies that if a borrow of a new key is blocked because maxTotal has * been reached, that borrow continues once another object is returned. @@ -2346,7 +2340,6 @@ public class TestGenericKeyedObjectPool extends AbstractTestKeyedObjectPool { gkoPool.setDurationBetweenEvictionRuns(Duration.ofMillis(100)); gkoPool.setTestWhileIdle(true); - //Generate a random key final String key = "A"; @@ -2501,7 +2494,6 @@ public class TestGenericKeyedObjectPool extends AbstractTestKeyedObjectPool { } } - @Test public void testReturnObjectWithBlockWhenExhausted() throws Exception { gkoPool.setBlockWhenExhausted(true); @@ -2755,4 +2747,3 @@ public void testValidateOnCreateFailure() throws Exception { } - diff --git a/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPool.java b/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPool.java index dbd1917c..ab23d66c 100644 --- a/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPool.java +++ b/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPool.java @@ -17,7 +17,6 @@ package org.apache.commons.pool3.impl; - import static org.hamcrest.MatcherAssert.assertThat; import static org.hamcrest.Matchers.lessThanOrEqualTo; import static org.junit.jupiter.api.Assertions.assertEquals; @@ -973,7 +972,6 @@ public class TestGenericObjectPool extends TestBaseObjectPool { } } - @Test @Timeout(value = 60000, unit = TimeUnit.MILLISECONDS) public void testAddObject() throws Exception { @@ -1197,7 +1195,6 @@ public class TestGenericObjectPool extends TestBaseObjectPool { genericObjectPool.close(); } - @Test @Timeout(value = 60000, unit = TimeUnit.MILLISECONDS) public void testConcurrentBorrowAndEvict() throws Exception { @@ -2040,7 +2037,6 @@ public class TestGenericObjectPool extends TestBaseObjectPool { } } - /** * Test the following scenario: * Thread 1 borrows an instance diff --git a/src/test/java/org/apache/commons/pool3/impl/TestPooledSoftReference.java b/src/test/java/org/apache/commons/pool3/impl/TestPooledSoftReference.java index a971aa01..40cd3560 100644 --- a/src/test/java/org/apache/commons/pool3/impl/TestPooledSoftReference.java +++ b/src/test/java/org/apache/commons/pool3/impl/TestPooledSoftReference.java @@ -16,7 +16,6 @@ */ package org.apache.commons.pool3.impl; - import static org.junit.jupiter.api.Assertions.assertEquals; import java.lang.ref.SoftReference; @@ -24,7 +23,6 @@ import java.lang.ref.SoftReference; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; - /** * Tests for PooledSoftReference. */ diff --git a/src/test/java/org/apache/commons/pool3/impl/TestSoftRefOutOfMemory.java b/src/test/java/org/apache/commons/pool3/impl/TestSoftRefOutOfMemory.java index 8e0fd697..0499da7c 100644 --- a/src/test/java/org/apache/commons/pool3/impl/TestSoftRefOutOfMemory.java +++ b/src/test/java/org/apache/commons/pool3/impl/TestSoftRefOutOfMemory.java @@ -17,7 +17,6 @@ package org.apache.commons.pool3.impl; - import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; diff --git a/src/test/java/org/apache/commons/pool3/impl/TestSoftReferenceObjectPool.java b/src/test/java/org/apache/commons/pool3/impl/TestSoftReferenceObjectPool.java index 0475bb14..2bf47424 100644 --- a/src/test/java/org/apache/commons/pool3/impl/TestSoftReferenceObjectPool.java +++ b/src/test/java/org/apache/commons/pool3/impl/TestSoftReferenceObjectPool.java @@ -61,7 +61,6 @@ public class TestSoftReferenceObjectPool extends TestBaseObjectPool { return (ObjectPool<String, E>) new SoftReferenceObjectPool<>(new SimpleFactory()); } - @Override protected <E extends Exception> ObjectPool<Object, E> makeEmptyPool(final PooledObjectFactory<Object, E> factory) { return new SoftReferenceObjectPool<>(factory); diff --git a/src/test/java/org/apache/commons/pool3/pool407/KeyedPool407Test.java b/src/test/java/org/apache/commons/pool3/pool407/KeyedPool407Test.java index 8e19ebae..ab3f9a3c 100644 --- a/src/test/java/org/apache/commons/pool3/pool407/KeyedPool407Test.java +++ b/src/test/java/org/apache/commons/pool3/pool407/KeyedPool407Test.java @@ -70,7 +70,6 @@ public class KeyedPool407Test extends AbstractPool407Test { assertShutdown(termination, poolConfigMaxWait, obj, pooledObject); } - private void test(final AbstractKeyedPool407Factory factory, final int poolSize, final Duration poolConfigMaxWait) throws InterruptedException { final ExecutorService executor = Executors.newFixedThreadPool(poolSize); try (final KeyedPool407 pool = new KeyedPool407(factory, poolConfigMaxWait)) { diff --git a/src/test/java/org/apache/commons/pool3/proxy/AbstractTestProxiedKeyedObjectPool.java b/src/test/java/org/apache/commons/pool3/proxy/AbstractTestProxiedKeyedObjectPool.java index 6bfc8d1d..09aefb58 100644 --- a/src/test/java/org/apache/commons/pool3/proxy/AbstractTestProxiedKeyedObjectPool.java +++ b/src/test/java/org/apache/commons/pool3/proxy/AbstractTestProxiedKeyedObjectPool.java @@ -36,8 +36,6 @@ import org.apache.commons.pool3.impl.GenericKeyedObjectPoolConfig; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; - - public abstract class AbstractTestProxiedKeyedObjectPool { private static final class TestKeyedObjectFactory extends BaseKeyedPooledObjectFactory<String, TestObject, RuntimeException> { @@ -75,7 +73,6 @@ public abstract class AbstractTestProxiedKeyedObjectPool { private static final String KEY1 = "key1"; - private static final String DATA1 = "data1"; private static final Duration ABANDONED_TIMEOUT_SECS = Duration.ofSeconds(3); @@ -84,10 +81,8 @@ public abstract class AbstractTestProxiedKeyedObjectPool { private StringWriter log; - protected abstract ProxySource<TestObject> getproxySource(); - @BeforeEach public void setUp() { log = new StringWriter(); @@ -111,7 +106,6 @@ public abstract class AbstractTestProxiedKeyedObjectPool { pool = new ProxiedKeyedObjectPool<>(innerPool, getproxySource()); } - @Test public void testAccessAfterInvalidate() { final TestObject obj = pool.borrowObject(KEY1); @@ -130,7 +124,6 @@ public abstract class AbstractTestProxiedKeyedObjectPool { } - @Test public void testAccessAfterReturn() { final TestObject obj = pool.borrowObject(KEY1); @@ -159,7 +152,6 @@ public abstract class AbstractTestProxiedKeyedObjectPool { pool.returnObject(KEY1, obj); } - @Test public void testPassThroughMethods01() { assertEquals(0, pool.getNumActive()); @@ -176,7 +168,6 @@ public abstract class AbstractTestProxiedKeyedObjectPool { assertEquals(0, pool.getNumIdle()); } - @Test public void testPassThroughMethods02() { pool.close(); diff --git a/src/test/java/org/apache/commons/pool3/proxy/AbstractTestProxiedObjectPool.java b/src/test/java/org/apache/commons/pool3/proxy/AbstractTestProxiedObjectPool.java index f3985e96..c53dbcf2 100644 --- a/src/test/java/org/apache/commons/pool3/proxy/AbstractTestProxiedObjectPool.java +++ b/src/test/java/org/apache/commons/pool3/proxy/AbstractTestProxiedObjectPool.java @@ -36,7 +36,6 @@ import org.apache.commons.pool3.impl.GenericObjectPoolConfig; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; - public abstract class AbstractTestProxiedObjectPool { protected interface TestObject { @@ -74,15 +73,12 @@ public abstract class AbstractTestProxiedObjectPool { private static final Duration ABANDONED_TIMEOUT_SECS = Duration.ofSeconds(3); - private ObjectPool<TestObject, RuntimeException> pool; private StringWriter log; - protected abstract ProxySource<TestObject> getproxySource(); - @BeforeEach public void setUp() { log = new StringWriter(); @@ -106,7 +102,6 @@ public abstract class AbstractTestProxiedObjectPool { pool = new ProxiedObjectPool<>(innerPool, getproxySource()); } - @Test public void testAccessAfterInvalidate() { final TestObject obj = pool.borrowObject(); @@ -125,7 +120,6 @@ public abstract class AbstractTestProxiedObjectPool { } - @Test public void testAccessAfterReturn() { final TestObject obj = pool.borrowObject(); @@ -143,7 +137,6 @@ public abstract class AbstractTestProxiedObjectPool { obj::getData); } - @Test public void testBorrowObject() { final TestObject obj = pool.borrowObject(); @@ -172,7 +165,6 @@ public abstract class AbstractTestProxiedObjectPool { assertEquals(0, pool.getNumIdle()); } - @Test public void testPassThroughMethods02() { pool.close(); @@ -181,7 +173,6 @@ public abstract class AbstractTestProxiedObjectPool { () -> pool.addObject()); } - @Test public void testUsageTracking() throws InterruptedException { final TestObject obj = pool.borrowObject();