This is an automated email from the ASF dual-hosted git repository. ggregory pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-imaging.git
from a6a9a9d5 Avoid NullPointerException in TiffImageParser.checkForSubImage(TiffImagingParameters) #304 new 90dcacfa Sort members new 8c44dfd7 Format consistently new 886fde3e Manage SpotBugs configuration new 1b63210b Remove obsolete SpotBugs exclusions new 181b526f Better use of Objects.requireNonNull() new 2fb3075d Javadoc new fc286853 Remove obsolete SpotBugs exclusions new cf67360e Remove obsolete SpotBugs exclusions The 8 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: pom.xml | 10 +- src/conf/spotbugs-exclude-filter.xml | 18 - .../commons/imaging/AbstractImageParser.java | 671 ++++++++------------- .../org/apache/commons/imaging/ColorTools.java | 71 +-- .../apache/commons/imaging/FormatCompliance.java | 31 +- .../org/apache/commons/imaging/ImageFormats.java | 26 +- .../java/org/apache/commons/imaging/ImageInfo.java | 77 +-- .../java/org/apache/commons/imaging/Imaging.java | 421 ++++++------- .../apache/commons/imaging/ImagingConstants.java | 7 +- .../commons/imaging/ImagingFormatException.java | 11 +- .../apache/commons/imaging/ImagingParameters.java | 18 +- .../commons/imaging/ImagingRuntimeException.java | 14 +- .../org/apache/commons/imaging/PixelDensity.java | 8 +- .../imaging/bytesource/InputStreamByteSource.java | 4 +- .../commons/imaging/bytesource/package-info.java | 1 - .../apache/commons/imaging/color/ColorCieLab.java | 19 +- .../apache/commons/imaging/color/ColorCieLch.java | 14 +- .../apache/commons/imaging/color/ColorCieLuv.java | 16 +- .../org/apache/commons/imaging/color/ColorCmy.java | 19 +- .../apache/commons/imaging/color/ColorCmyk.java | 21 +- .../commons/imaging/color/ColorConversions.java | 146 +++-- .../commons/imaging/color/ColorDin99Lab.java | 5 +- .../org/apache/commons/imaging/color/ColorHsl.java | 16 +- .../org/apache/commons/imaging/color/ColorHsv.java | 16 +- .../commons/imaging/color/ColorHunterLab.java | 16 +- .../org/apache/commons/imaging/color/ColorXyz.java | 19 +- .../apache/commons/imaging/common/Allocator.java | 13 +- .../commons/imaging/common/BasicCParser.java | 95 ++- .../common/BigEndianBinaryOutputStream.java | 12 +- .../commons/imaging/common/BinaryFileParser.java | 3 +- .../commons/imaging/common/BinaryFunctions.java | 149 ++--- .../imaging/common/BufferedImageFactory.java | 6 +- .../commons/imaging/common/ByteConversions.java | 177 +++--- .../commons/imaging/common/ImageBuilder.java | 168 ++---- .../common/LittleEndianBinaryOutputStream.java | 12 +- .../apache/commons/imaging/common/PackBits.java | 17 +- .../commons/imaging/common/RationalNumber.java | 87 ++- .../imaging/common/RgbBufferedImageFactory.java | 6 +- .../imaging/common/SimpleBufferedImageFactory.java | 6 +- .../commons/imaging/common/XmpEmbeddable.java | 19 +- .../apache/commons/imaging/common/ZlibDeflate.java | 8 +- .../commons/imaging/common/package-info.java | 4 +- .../commons/imaging/formats/bmp/BmpHeaderInfo.java | 14 +- .../imaging/formats/bmp/BmpImageParser.java | 102 ++-- .../imaging/formats/bmp/BmpWriterPalette.java | 12 +- .../commons/imaging/formats/bmp/BmpWriterRgb.java | 8 +- .../imaging/formats/bmp/PixelParserBitFields.java | 26 +- .../imaging/formats/bmp/PixelParserRgb.java | 26 +- .../imaging/formats/bmp/PixelParserRle.java | 26 +- .../commons/imaging/formats/bmp/package-info.java | 1 - .../imaging/formats/dcx/DcxImageParser.java | 34 +- .../commons/imaging/formats/dcx/package-info.java | 1 - .../imaging/formats/gif/DisposalMethod.java | 4 +- .../commons/imaging/formats/gif/GifHeaderInfo.java | 9 +- .../imaging/formats/gif/GifImageContents.java | 3 +- .../imaging/formats/gif/GifImageParser.java | 343 ++++------- .../formats/gif/GraphicControlExtension.java | 4 +- .../imaging/formats/gif/ImageDescriptor.java | 9 +- .../commons/imaging/formats/gif/package-info.java | 1 - .../commons/imaging/formats/icns/IcnsDecoder.java | 158 ++--- .../imaging/formats/icns/IcnsImageParser.java | 59 +- .../commons/imaging/formats/icns/IcnsType.java | 130 ++-- .../imaging/formats/icns/Rle24Compression.java | 4 +- .../commons/imaging/formats/icns/package-info.java | 1 - .../imaging/formats/ico/IcoImageParser.java | 234 ++++--- .../commons/imaging/formats/ico/package-info.java | 1 - .../imaging/formats/jpeg/JpegConstants.java | 163 +++-- .../imaging/formats/jpeg/JpegImageMetadata.java | 19 +- .../imaging/formats/jpeg/JpegImageParser.java | 196 ++---- .../commons/imaging/formats/jpeg/JpegUtils.java | 27 +- .../commons/imaging/formats/jpeg/decoder/Dct.java | 95 +-- .../imaging/formats/jpeg/decoder/JpegDecoder.java | 147 ++--- .../formats/jpeg/decoder/JpegInputStream.java | 10 +- .../formats/jpeg/decoder/YCbCrConverter.java | 25 +- .../imaging/formats/jpeg/decoder/ZigZag.java | 12 +- .../imaging/formats/jpeg/exif/ExifRewriter.java | 332 ++++------ .../imaging/formats/jpeg/iptc/IptcBlock.java | 10 +- .../imaging/formats/jpeg/iptc/IptcParser.java | 91 +-- .../imaging/formats/jpeg/iptc/IptcTypes.java | 133 +--- .../formats/jpeg/iptc/JpegIptcRewriter.java | 278 +++------ .../formats/jpeg/iptc/PhotoshopApp13Data.java | 3 +- .../commons/imaging/formats/jpeg/package-info.java | 1 - .../formats/jpeg/segments/AbstractSegment.java | 18 +- .../formats/jpeg/segments/App13Segment.java | 14 +- .../imaging/formats/jpeg/segments/App2Segment.java | 14 +- .../imaging/formats/jpeg/segments/DhtSegment.java | 14 +- .../imaging/formats/jpeg/segments/DqtSegment.java | 25 +- .../formats/jpeg/segments/GenericSegment.java | 13 +- .../imaging/formats/jpeg/segments/JfifSegment.java | 21 +- .../imaging/formats/jpeg/segments/SofnSegment.java | 29 +- .../imaging/formats/jpeg/segments/SosSegment.java | 29 +- .../imaging/formats/jpeg/xmp/JpegRewriter.java | 48 +- .../imaging/formats/jpeg/xmp/JpegXmpParser.java | 3 +- .../imaging/formats/jpeg/xmp/JpegXmpRewriter.java | 131 ++-- .../imaging/formats/pcx/PcxImageParser.java | 174 ++---- .../imaging/formats/pcx/PcxImagingParameters.java | 1 + .../commons/imaging/formats/pcx/PcxWriter.java | 46 +- .../commons/imaging/formats/pcx/RleReader.java | 3 +- .../commons/imaging/formats/pcx/RleWriter.java | 19 +- .../commons/imaging/formats/pcx/package-info.java | 1 - .../imaging/formats/png/AbstractPngText.java | 13 +- .../imaging/formats/png/AbstractScanExpediter.java | 39 +- .../commons/imaging/formats/png/BitParser.java | 10 +- .../commons/imaging/formats/png/ChunkType.java | 2 +- .../commons/imaging/formats/png/FilterType.java | 6 +- .../imaging/formats/png/GammaCorrection.java | 12 +- .../imaging/formats/png/InterlaceMethod.java | 3 +- .../commons/imaging/formats/png/PhysicalScale.java | 77 +-- .../commons/imaging/formats/png/PngColorType.java | 10 +- .../commons/imaging/formats/png/PngConstants.java | 36 +- .../apache/commons/imaging/formats/png/PngCrc.java | 11 +- .../commons/imaging/formats/png/PngImageInfo.java | 20 +- .../imaging/formats/png/PngImageParser.java | 181 +++--- .../imaging/formats/png/PngImagingParameters.java | 27 +- .../commons/imaging/formats/png/PngWriter.java | 240 +++----- .../formats/png/ScanExpediterInterlaced.java | 17 +- .../imaging/formats/png/ScanExpediterSimple.java | 11 +- .../imaging/formats/png/chunks/PngChunk.java | 15 +- .../imaging/formats/png/chunks/PngChunkGama.java | 3 +- .../imaging/formats/png/chunks/PngChunkIccp.java | 13 +- .../imaging/formats/png/chunks/PngChunkItxt.java | 14 +- .../imaging/formats/png/chunks/PngChunkPlte.java | 22 +- .../commons/imaging/formats/png/package-info.java | 1 - .../png/scanlinefilters/ScanlineFilter.java | 3 +- .../png/scanlinefilters/ScanlineFilterAverage.java | 3 +- .../png/scanlinefilters/ScanlineFilterNone.java | 3 +- .../png/scanlinefilters/ScanlineFilterPaeth.java | 7 +- .../png/scanlinefilters/ScanlineFilterSub.java | 5 +- .../png/scanlinefilters/ScanlineFilterUp.java | 3 +- .../formats/png/scanlinefilters/package-info.java | 1 - .../TransparencyFilterIndexedColor.java | 7 +- .../TransparencyFilterTrueColor.java | 7 +- .../png/transparencyfilters/package-info.java | 1 - .../imaging/formats/pnm/AbstractFileInfo.java | 5 +- .../commons/imaging/formats/pnm/PamFileInfo.java | 50 +- .../commons/imaging/formats/pnm/PamWriter.java | 19 +- .../commons/imaging/formats/pnm/PbmFileInfo.java | 2 +- .../commons/imaging/formats/pnm/PbmWriter.java | 19 +- .../commons/imaging/formats/pnm/PgmFileInfo.java | 16 +- .../commons/imaging/formats/pnm/PgmWriter.java | 9 +- .../commons/imaging/formats/pnm/PnmConstants.java | 2 +- .../imaging/formats/pnm/PnmImageParser.java | 70 +-- .../imaging/formats/pnm/PnmImagingParameters.java | 1 + .../commons/imaging/formats/pnm/PnmWriter.java | 3 +- .../commons/imaging/formats/pnm/PpmFileInfo.java | 10 +- .../commons/imaging/formats/pnm/PpmWriter.java | 17 +- .../imaging/formats/pnm/WhiteSpaceReader.java | 4 +- .../commons/imaging/formats/pnm/package-info.java | 1 - .../imaging/formats/psd/ImageResourceType.java | 111 ++-- .../commons/imaging/formats/psd/PsdHeaderInfo.java | 3 +- .../imaging/formats/psd/PsdImageContents.java | 18 +- .../imaging/formats/psd/PsdImageParser.java | 178 ++---- .../formats/psd/dataparsers/DataParser.java | 3 +- .../formats/psd/dataparsers/DataParserBitmap.java | 8 +- .../formats/psd/dataparsers/DataParserCmyk.java | 3 +- .../psd/dataparsers/DataParserGrayscale.java | 8 +- .../formats/psd/dataparsers/DataParserIndexed.java | 3 +- .../formats/psd/dataparsers/DataParserRgb.java | 8 +- .../formats/psd/dataparsers/DataParserStub.java | 3 +- .../formats/psd/dataparsers/package-info.java | 1 - .../psd/datareaders/CompressedDataReader.java | 10 +- .../formats/psd/datareaders/DataReader.java | 6 +- .../psd/datareaders/UncompressedDataReader.java | 6 +- .../formats/psd/datareaders/package-info.java | 1 - .../commons/imaging/formats/psd/package-info.java | 1 - .../imaging/formats/rgbe/RgbeImageParser.java | 40 +- .../commons/imaging/formats/rgbe/RgbeInfo.java | 16 +- .../commons/imaging/formats/rgbe/package-info.java | 1 - .../imaging/formats/tiff/AbstractTiffElement.java | 5 +- .../formats/tiff/AbstractTiffImageData.java | 58 +- .../commons/imaging/formats/tiff/TiffContents.java | 4 +- .../imaging/formats/tiff/TiffDirectory.java | 407 +++++-------- .../commons/imaging/formats/tiff/TiffField.java | 119 ++-- .../imaging/formats/tiff/TiffImageMetadata.java | 86 +-- .../imaging/formats/tiff/TiffImageParser.java | 474 ++++++--------- .../formats/tiff/TiffImagingParameters.java | 93 ++- .../imaging/formats/tiff/TiffRasterData.java | 119 ++-- .../imaging/formats/tiff/TiffRasterDataFloat.java | 124 ++-- .../imaging/formats/tiff/TiffRasterDataInt.java | 116 ++-- .../imaging/formats/tiff/TiffRasterDataType.java | 11 +- .../imaging/formats/tiff/TiffRasterStatistics.java | 20 +- .../commons/imaging/formats/tiff/TiffReader.java | 131 ++-- .../commons/imaging/formats/tiff/TiffTags.java | 10 +- .../constants/AdobePageMaker6TagConstants.java | 42 +- .../tiff/constants/AdobePhotoshopTagConstants.java | 17 +- .../constants/AliasSketchbookProTagConstants.java | 7 +- .../formats/tiff/constants/DcfTagConstants.java | 23 +- .../formats/tiff/constants/DngTagConstants.java | 372 +++--------- .../formats/tiff/constants/ExifTagConstants.java | 618 ++++++------------- .../tiff/constants/GdalLibraryTagConstants.java | 6 +- .../tiff/constants/GeoTiffTagConstants.java | 33 +- .../formats/tiff/constants/GpsTagConstants.java | 150 ++--- .../tiff/constants/HylaFaxTagConstants.java | 32 +- .../constants/MicrosoftHdPhotoTagConstants.java | 259 +++----- .../tiff/constants/MicrosoftTagConstants.java | 34 +- .../MolecularDynamicsGelTagConstants.java | 45 +- .../tiff/constants/OceScanjobTagConstants.java | 20 +- .../tiff/constants/Rfc2301TagConstants.java | 67 +- .../formats/tiff/constants/Tiff4TagConstants.java | 8 +- .../formats/tiff/constants/TiffConstants.java | 15 +- .../formats/tiff/constants/TiffDirectoryType.java | 28 +- .../formats/tiff/constants/TiffEpTagConstants.java | 94 +-- .../tiff/constants/TiffPlanarConfiguration.java | 25 +- .../formats/tiff/constants/TiffTagConstants.java | 350 +++-------- .../formats/tiff/constants/WangTagConstants.java | 11 +- .../formats/tiff/constants/package-info.java | 1 - .../formats/tiff/datareaders/BitInputStream.java | 20 +- .../tiff/datareaders/DataInterpreterJpeg.java | 70 +-- .../formats/tiff/datareaders/DataReaderStrips.java | 177 ++---- .../formats/tiff/datareaders/DataReaderTiled.java | 128 ++-- .../formats/tiff/datareaders/ImageDataReader.java | 451 +++++--------- .../formats/tiff/datareaders/package-info.java | 1 - .../formats/tiff/fieldtypes/AbstractFieldType.java | 54 +- .../formats/tiff/fieldtypes/FieldTypeAscii.java | 10 +- .../formats/tiff/fieldtypes/FieldTypeLong.java | 3 +- .../formats/tiff/fieldtypes/FieldTypeLong8.java | 10 +- .../formats/tiff/fieldtypes/FieldTypeRational.java | 11 +- .../formats/tiff/fieldtypes/package-info.java | 1 - .../formats/tiff/itu_t4/BitArrayOutputStream.java | 3 +- .../tiff/itu_t4/BitInputStreamFlexible.java | 15 +- .../imaging/formats/tiff/itu_t4/HuffmanTree.java | 7 +- .../formats/tiff/itu_t4/T4AndT6Compression.java | 106 ++-- .../imaging/formats/tiff/itu_t4/T4_T6_Tables.java | 245 ++------ .../imaging/formats/tiff/itu_t4/package-info.java | 1 - .../commons/imaging/formats/tiff/package-info.java | 5 +- .../PhotometricInterpreter.java | 13 +- .../PhotometricInterpreterBiLevel.java | 10 +- .../PhotometricInterpreterCieLab.java | 6 +- .../PhotometricInterpreterCmyk.java | 6 +- .../PhotometricInterpreterLogLuv.java | 27 +- .../PhotometricInterpreterPalette.java | 34 +- .../PhotometricInterpreterRgb.java | 8 +- .../PhotometricInterpreterYCbCr.java | 37 +- .../floatingpoint/PaletteEntry.java | 25 +- .../floatingpoint/PaletteEntryForRange.java | 51 +- .../floatingpoint/PaletteEntryForValue.java | 8 +- .../floatingpoint/PhotometricInterpreterFloat.java | 137 ++--- .../floatingpoint/package-info.java | 3 +- .../tiff/photometricinterpreters/package-info.java | 4 +- .../imaging/formats/tiff/taginfos/TagInfo.java | 32 +- .../imaging/formats/tiff/taginfos/TagInfoAny.java | 3 +- .../formats/tiff/taginfos/TagInfoAscii.java | 12 +- .../formats/tiff/taginfos/TagInfoAsciiOrByte.java | 6 +- .../tiff/taginfos/TagInfoAsciiOrRational.java | 6 +- .../imaging/formats/tiff/taginfos/TagInfoByte.java | 6 +- .../formats/tiff/taginfos/TagInfoBytes.java | 7 +- .../formats/tiff/taginfos/TagInfoDirectory.java | 7 +- .../formats/tiff/taginfos/TagInfoGpsText.java | 51 +- .../imaging/formats/tiff/taginfos/TagInfoLong.java | 4 +- .../formats/tiff/taginfos/TagInfoXpString.java | 6 +- .../formats/tiff/taginfos/package-info.java | 1 - .../tiff/write/AbstractTiffImageWriter.java | 130 ++-- .../formats/tiff/write/AbstractTiffOutputItem.java | 9 +- .../tiff/write/TiffImageWriterLossless.java | 44 +- .../formats/tiff/write/TiffImageWriterLossy.java | 7 +- .../formats/tiff/write/TiffOutputDirectory.java | 384 ++++-------- .../formats/tiff/write/TiffOutputField.java | 23 +- .../imaging/formats/tiff/write/TiffOutputSet.java | 61 +- .../formats/tiff/write/TiffOutputSummary.java | 14 +- .../imaging/formats/tiff/write/package-info.java | 1 - .../imaging/formats/wbmp/WbmpImageParser.java | 84 +-- .../commons/imaging/formats/wbmp/package-info.java | 1 - .../imaging/formats/webp/WebPChunkType.java | 19 +- .../imaging/formats/webp/WebPConstants.java | 10 +- .../imaging/formats/webp/WebPImageMetadata.java | 8 +- .../imaging/formats/webp/WebPImageParser.java | 91 ++- .../imaging/formats/webp/chunks/WebPChunk.java | 24 +- .../imaging/formats/webp/chunks/WebPChunkAlph.java | 2 +- .../imaging/formats/webp/chunks/WebPChunkAnim.java | 2 +- .../imaging/formats/webp/chunks/WebPChunkAnmf.java | 2 +- .../imaging/formats/webp/chunks/WebPChunkExif.java | 8 +- .../imaging/formats/webp/chunks/WebPChunkIccp.java | 2 +- .../imaging/formats/webp/chunks/WebPChunkVp8.java | 40 +- .../imaging/formats/webp/chunks/WebPChunkVp8l.java | 14 +- .../imaging/formats/webp/chunks/WebPChunkVp8x.java | 9 +- .../imaging/formats/webp/chunks/WebPChunkXml.java | 2 +- .../imaging/formats/webp/chunks/WebPChunkXyzw.java | 2 +- .../commons/imaging/formats/webp/package-info.java | 6 +- .../imaging/formats/xbm/XbmImageParser.java | 110 ++-- .../commons/imaging/formats/xbm/package-info.java | 1 - .../imaging/formats/xpm/XpmImageParser.java | 40 +- .../apache/commons/imaging/icc/IccConstants.java | 6 +- .../apache/commons/imaging/icc/IccProfileInfo.java | 19 +- .../commons/imaging/icc/IccProfileParser.java | 26 +- .../org/apache/commons/imaging/icc/IccTag.java | 33 +- .../commons/imaging/icc/IccTagDataTypes.java | 46 +- .../apache/commons/imaging/icc/IccTagTypes.java | 398 ++++++------ .../org/apache/commons/imaging/internal/Debug.java | 39 +- .../imaging/internal/ImageParserFactory.java | 7 +- .../commons/imaging/internal/SafeOperations.java | 2 +- .../imaging/mylzw/BitsToByteInputStream.java | 4 +- .../commons/imaging/mylzw/MyBitInputStream.java | 8 +- .../commons/imaging/mylzw/MyBitOutputStream.java | 17 +- .../commons/imaging/mylzw/MyLzwCompressor.java | 27 +- .../commons/imaging/mylzw/MyLzwDecompressor.java | 15 +- .../apache/commons/imaging/mylzw/package-info.java | 1 - .../org/apache/commons/imaging/package-info.java | 1 - .../commons/imaging/palette/ColorComponent.java | 7 +- .../apache/commons/imaging/palette/ColorCount.java | 8 +- .../imaging/palette/ColorCountComparator.java | 13 +- .../apache/commons/imaging/palette/ColorGroup.java | 19 +- .../commons/imaging/palette/ColorSpaceSubset.java | 53 +- .../apache/commons/imaging/palette/Dithering.java | 25 +- .../imaging/palette/LongestAxisMedianCut.java | 49 +- .../apache/commons/imaging/palette/MedianCut.java | 3 +- .../imaging/palette/MedianCutQuantizer.java | 17 +- .../palette/MostPopulatedBoxesMedianCut.java | 45 +- .../commons/imaging/palette/PaletteFactory.java | 87 ++- .../commons/imaging/palette/QuantizedPalette.java | 11 +- .../commons/imaging/AbstractImagingTest.java | 18 +- .../commons/imaging/ImagingGuessFormatTest.java | 16 +- .../org/apache/commons/imaging/TestImageInfo.java | 74 +-- .../imaging/bytesource/AbstractByteSourceTest.java | 9 +- .../imaging/bytesource/ByteSourceDataTest.java | 3 +- .../imaging/bytesource/ByteSourceImageTest.java | 30 +- .../bytesource/ByteSourceInputStreamTest.java | 2 +- .../apache/commons/imaging/color/ColorCmyTest.java | 6 +- .../imaging/color/ColorConversionsTest.java | 10 +- .../apache/commons/imaging/color/ColorHslTest.java | 4 +- .../commons/imaging/common/RationalNumberTest.java | 9 +- .../examples/ApacheImagingSpeedAndMemoryTest.java | 25 +- .../commons/imaging/examples/ImageReadExample.java | 15 +- .../imaging/examples/ImageWriteExample.java | 3 +- .../commons/imaging/examples/MetadataExample.java | 68 +-- .../imaging/examples/WriteExifMetadataExample.java | 48 +- .../tiff/ExampleReadFloatingPointData.java | 64 +- .../examples/tiff/ReadAndRenderFloatingPoint.java | 61 +- .../imaging/examples/tiff/ReadTagsAndImages.java | 502 +++++++-------- .../imaging/examples/tiff/SurveyTiffFile.java | 184 +++--- .../imaging/examples/tiff/SurveyTiffFolder.java | 19 +- .../imaging/examples/tiff/package-info.java | 3 +- .../imaging/formats/bmp/BmpImageParserTest.java | 3 + .../commons/imaging/formats/bmp/BmpReadTest.java | 6 +- .../imaging/formats/bmp/BmpRoundtripTest.java | 10 +- .../imaging/formats/bmp/BmpWriterRgbTest.java | 4 +- .../commons/imaging/formats/gif/GifReadTest.java | 27 +- .../commons/imaging/formats/icns/IcnsReadTest.java | 23 +- .../imaging/formats/icns/IcnsRoundTripTest.java | 68 +-- .../imaging/formats/ico/AbstractIcoTest.java | 3 +- .../imaging/formats/ico/IcoRoundtripTest.java | 149 ++--- .../commons/imaging/formats/jpeg/JpegReadTest.java | 19 +- .../jpeg/JpegWithInvalidDhtSegmentTest.java | 3 +- .../imaging/formats/jpeg/decoder/DctTest.java | 25 +- .../formats/jpeg/decoder/JpegInputStreamTest.java | 29 +- .../formats/jpeg/exif/AbstractExifTest.java | 6 +- .../jpeg/exif/AbstractSpecificExifTagTest.java | 6 +- .../imaging/formats/jpeg/exif/AsciiFieldTest.java | 15 +- .../imaging/formats/jpeg/exif/ExifRewriteTest.java | 35 +- .../jpeg/exif/ExifRewriterRoundtripTest.java | 21 +- .../formats/jpeg/exif/MakerNoteFieldTest.java | 3 +- .../formats/jpeg/exif/MicrosoftTagTest.java | 4 +- .../imaging/formats/jpeg/exif/TextFieldTest.java | 9 +- .../jpeg/exif/WriteExifMetadataExampleTest.java | 1 + .../imaging/formats/jpeg/iptc/IptcAddTest.java | 11 +- .../imaging/formats/jpeg/iptc/IptcBaseTest.java | 21 +- .../imaging/formats/jpeg/iptc/IptcDumpTest.java | 4 +- .../imaging/formats/jpeg/iptc/IptcParserTest.java | 32 +- .../formats/jpeg/iptc/IptcTypeLookupTest.java | 2 +- .../imaging/formats/jpeg/iptc/IptcUpdateTest.java | 39 +- .../formats/jpeg/segments/App2SegmentTest.java | 33 +- .../formats/jpeg/segments/AppnSegmentTest.java | 14 +- .../formats/jpeg/segments/JfifSegmentTest.java | 24 +- .../formats/jpeg/segments/SosSegmentTest.java | 34 +- .../formats/jpeg/specific/JpegImageParserTest.java | 1 + .../formats/jpeg/xmp/AbstractJpegXmpTest.java | 15 +- .../formats/jpeg/xmp/JpegXmpParserTest.java | 2 +- .../formats/jpeg/xmp/JpegXmpRewriteTest.java | 12 +- .../commons/imaging/formats/pcx/RleReaderTest.java | 4 +- .../imaging/formats/png/ConvertPngToGifTest.java | 3 +- .../imaging/formats/png/PhysicalScaleTest.java | 34 +- .../commons/imaging/formats/png/PngCrcTest.java | 4 +- .../imaging/formats/png/PngImageParserTest.java | 13 +- .../commons/imaging/formats/png/PngReadTest.java | 42 +- .../commons/imaging/formats/png/PngTextTest.java | 6 +- .../png/PngWithInvalidPngChunkSizeTest.java | 6 +- .../imaging/formats/png/PngWritePredictorTest.java | 9 +- .../imaging/formats/png/PngWriteReadTest.java | 22 +- .../commons/imaging/formats/png/PngWriterTest.java | 30 +- .../formats/png/chunks/PngChunkScalTest.java | 74 ++- .../formats/png/chunks/PngChunkTextTest.java | 2 +- .../scanlinefilters/ScanlineFilterAverageTest.java | 16 +- .../scanlinefilters/ScanlineFilterPaethTest.java | 16 +- .../png/scanlinefilters/ScanlineFilterUpTest.java | 14 +- .../TransparencyFilterIndexedColorTest.java | 4 +- .../imaging/formats/pnm/PbmFileInfoTest.java | 30 +- .../imaging/formats/pnm/PnmImageParserTest.java | 6 +- .../imaging/formats/pnm/PpmFileInfoTest.java | 17 +- .../imaging/formats/pnm/WhiteSpaceReaderTest.java | 20 +- .../formats/psd/ImageResourceBlockTest.java | 4 +- .../imaging/formats/psd/ImageResourceTypeTest.java | 2 +- .../psd/dataparsers/DataParserGrayscaleTest.java | 12 +- .../psd/dataparsers/DataParserIndexedTest.java | 24 +- .../formats/psd/dataparsers/DataParserLabTest.java | 12 +- .../imaging/formats/tiff/JpegImageDataTest.java | 4 +- .../formats/tiff/TiffAlphaRoundTripTest.java | 73 +-- .../imaging/formats/tiff/TiffBigTiffTest.java | 83 ++- .../imaging/formats/tiff/TiffCcittTest.java | 57 +- .../tiff/TiffFloatingPointMultivariableTest.java | 195 +++--- .../formats/tiff/TiffFloatingPointReadTest.java | 55 +- .../tiff/TiffFloatingPointRoundTripTest.java | 161 ++--- .../commons/imaging/formats/tiff/TiffJpegTest.java | 136 ++--- .../commons/imaging/formats/tiff/TiffLzwTest.java | 55 +- .../formats/tiff/TiffRasterDataIntTest.java | 15 +- .../imaging/formats/tiff/TiffRasterDataTest.java | 4 +- .../formats/tiff/TiffRasterStatisticsTest.java | 3 +- .../imaging/formats/tiff/TiffReadAlphaTest.java | 21 +- .../formats/tiff/TiffReadImageInfoTest.java | 41 +- .../commons/imaging/formats/tiff/TiffReadTest.java | 8 +- .../formats/tiff/TiffRoundTripInt32Test.java | 81 +-- .../imaging/formats/tiff/TiffRoundtripTest.java | 8 +- .../formats/tiff/TiffShortIntRoundTripTest.java | 73 +-- .../imaging/formats/tiff/TiffSubImageTest.java | 34 +- .../imaging/formats/tiff/TiffTagIntegrityTest.java | 34 +- .../commons/imaging/formats/tiff/TiffTagsTest.java | 8 +- .../tiff/datareaders/DataReaderStripsTest.java | 12 +- .../tiff/fieldtypes/FieldTypeAsciiTest.java | 35 +- .../formats/tiff/fieldtypes/FieldTypeByteTest.java | 14 +- .../tiff/fieldtypes/FieldTypeRationalTest.java | 31 +- .../formats/tiff/fieldtypes/FieldTypeTest.java | 22 +- .../tiff/itu_t4/HuffmanTreeExceptionTest.java | 2 +- .../PhotometricInterpreterLogLuvTest.java | 9 +- .../PhotometricInterpreterRgbTest.java | 9 +- .../floatingpoint/PaletteEntryForRangeTest.java | 15 +- .../floatingpoint/PaletteEntryForValueTest.java | 3 +- .../PhotometricInterpreterFloatTest.java | 9 +- .../tiff/taginfos/TagInfoByteOrShortTest.java | 2 +- .../formats/tiff/taginfos/TagInfoByteTest.java | 2 +- .../formats/tiff/taginfos/TagInfoSByteTest.java | 18 +- .../formats/tiff/taginfos/TagInfoSBytesTest.java | 20 +- .../formats/tiff/taginfos/TagInfoSLongTest.java | 16 +- .../formats/tiff/taginfos/TagInfoSShortTest.java | 16 +- .../formats/tiff/taginfos/TagInfoSShortsTest.java | 18 +- .../formats/tiff/taginfos/TagInfoUnknownTest.java | 14 +- .../commons/imaging/formats/webp/WebPBaseTest.java | 11 +- .../commons/imaging/formats/webp/WebPDumpTest.java | 14 +- .../imaging/formats/webp/WebPMetadataTest.java | 24 +- .../commons/imaging/formats/webp/WebPReadTest.java | 14 +- .../commons/imaging/formats/xmp/XmpUpdateTest.java | 6 +- .../commons/imaging/palette/DitheringTest.java | 58 +- .../imaging/palette/PaletteQuantizationTest.java | 11 +- .../commons/imaging/palette/SimplePaletteTest.java | 6 +- .../imaging/roundtrip/BitmapRoundtripTest.java | 3 +- .../commons/imaging/roundtrip/FormatInfo.java | 132 ++-- .../imaging/roundtrip/FullColorRoundtrip.java | 3 +- .../imaging/roundtrip/GrayscaleRountripTest.java | 7 +- .../commons/imaging/roundtrip/ImageAsserts.java | 19 +- .../roundtrip/LimitedColorRoundtripTest.java | 21 +- .../imaging/roundtrip/PixelDensityRoundtrip.java | 6 +- .../commons/imaging/roundtrip/RoundtripBase.java | 5 +- .../commons/imaging/roundtrip/TestImages.java | 40 +- .../commons/imaging/test/FileSystemTraversal.java | 26 +- .../imaging/test/PrintShallowObjectSizes.java | 6 +- .../apache/commons/imaging/test/TestResources.java | 10 +- 453 files changed, 7273 insertions(+), 12186 deletions(-)