This is an automated email from the ASF dual-hosted git repository. aherbert pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit 609e767434689e458498161d5cf8df1e78fd81b8 Author: Alex Herbert <aherb...@apache.org> AuthorDate: Fri Jul 5 13:31:03 2024 +0100 Remove unreachable code in conversion to floating-point value --- .../main/java/org/apache/commons/numbers/fraction/BigFraction.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java index e1720340..67b11a9d 100644 --- a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java +++ b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java @@ -1275,12 +1275,10 @@ public final class BigFraction * @param hasFractionalBits whether the number should be treated as though * it contained a non-zero fractional part * @return a {@code BigInteger} as described above - * @throws IllegalArgumentException if {@code bits <= 0} */ private static BigInteger roundAndRightShift(BigInteger value, int bits, boolean hasFractionalBits) { - if (bits <= 0) { - throw new IllegalArgumentException("bits: " + bits); - } + // Assumptions: + // assert bits > 0 BigInteger result = value.shiftRight(bits); if (value.testBit(bits - 1) &&