This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git
commit 49d47c3ca6a3ccd96bdff9e24646a7237690028f
Author: Alex Herbert <aherb...@apache.org>
AuthorDate: Fri Jul 5 17:51:58 2024 +0100
PMD fix: Use final
---
.../apache/commons/statistics/inference/BinomialTest.java | 2 +-
.../apache/commons/statistics/inference/BracketFinder.java | 2 +-
.../commons/statistics/inference/BrentOptimizer.java | 2 +-
.../commons/statistics/inference/FisherExactTest.java | 2 +-
.../inference/KolmogorovSmirnovDistribution.java | 4 ++--
.../statistics/inference/KolmogorovSmirnovTest.java | 8 ++++----
.../org/apache/commons/statistics/inference/TTest.java | 4 ++--
.../statistics/inference/UnconditionedExactTest.java | 14 +++++++-------
.../statistics/inference/WilcoxonSignedRankTest.java | 2 +-
9 files changed, 20 insertions(+), 20 deletions(-)
diff --git
a/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/BinomialTest.java
b/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/BinomialTest.java
index ecad162..e1e9ca3 100644
---
a/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/BinomialTest.java
+++
b/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/BinomialTest.java
@@ -117,7 +117,7 @@ public final class BinomialTest {
}
final BinomialDistribution distribution =
BinomialDistribution.of(numberOfTrials, probability);
- double p;
+ final double p;
if (alternative == AlternativeHypothesis.GREATER_THAN) {
p = distribution.survivalProbability(numberOfSuccesses - 1);
} else if (alternative == AlternativeHypothesis.LESS_THAN) {
diff --git
a/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/BracketFinder.java
b/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/BracketFinder.java
index b55042f..ff97829 100644
---
a/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/BracketFinder.java
+++
b/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/BracketFinder.java
@@ -109,7 +109,7 @@ class BracketFinder {
evaluations = 0;
// Limit the range of x
- DoubleUnaryOperator range;
+ final DoubleUnaryOperator range;
if (min < max) {
// Limit: min <= x <= max
range = x -> {
diff --git
a/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/BrentOptimizer.java
b/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/BrentOptimizer.java
index 27bc7c5..0b04598 100644
---
a/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/BrentOptimizer.java
+++
b/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/BrentOptimizer.java
@@ -252,7 +252,7 @@ final class BrentOptimizer {
// Update by at least "tol1".
// Here d is never NaN so the evaluation point u is always finite.
- double u;
+ final double u;
if (Math.abs(d) < tol1) {
if (d >= 0) {
u = x + tol1;
diff --git
a/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/FisherExactTest.java
b/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/FisherExactTest.java
index 85ce3e9..de4bce0 100644
---
a/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/FisherExactTest.java
+++
b/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/FisherExactTest.java
@@ -149,7 +149,7 @@ public final class FisherExactTest {
// Note: The distribution validates the population size is > 0
final HypergeometricDistribution distribution =
HypergeometricDistribution.of(nn, k, n);
- double p;
+ final double p;
if (alternative == AlternativeHypothesis.GREATER_THAN) {
p = distribution.survivalProbability(a - 1);
} else if (alternative == AlternativeHypothesis.LESS_THAN) {
diff --git
a/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/KolmogorovSmirnovDistribution.java
b/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/KolmogorovSmirnovDistribution.java
index cb75e3c..9de9b7a 100644
---
a/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/KolmogorovSmirnovDistribution.java
+++
b/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/KolmogorovSmirnovDistribution.java
@@ -380,7 +380,7 @@ final class KolmogorovSmirnovDistribution {
Arrays.fill(vc, 0);
// Select (A[i] - A[i-1]) factor
- double[] p;
+ final double[] p;
if (i == 2 || i == 2 * n + 2) {
// First or last
p = ap[0];
@@ -884,7 +884,7 @@ final class KolmogorovSmirnovDistribution {
// fastPow error is around 2^-52, pow error is ~ 2^-70 or lower.
// Smirnoff-Dwass has a sum of terms that cancel and requires
higher precision.
// The power can optionally be specified.
- ScaledPower fpow;
+ final ScaledPower fpow;
if (power == POWER_DEFAULT) {
// SD has only a few terms. Use a high accuracy power.
fpow = sd ? DDMath::pow : DD::pow;
diff --git
a/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/KolmogorovSmirnovTest.java
b/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/KolmogorovSmirnovTest.java
index 953e4b4..e0f1a46 100644
---
a/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/KolmogorovSmirnovTest.java
+++
b/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/KolmogorovSmirnovTest.java
@@ -488,7 +488,7 @@ public final class KolmogorovSmirnovTest {
public OneResult test(double[] x, DoubleUnaryOperator cdf) {
final int[] sign = {0};
final double d = computeStatistic(x, cdf, sign);
- double p;
+ final double p;
if (alternative == AlternativeHypothesis.TWO_SIDED) {
PValueMethod method = pValueMethod;
if (method == PValueMethod.AUTO) {
@@ -597,7 +597,7 @@ public final class KolmogorovSmirnovTest {
final boolean significantTies = tiesD[1] > dnm;
final double d2 = significantTies ? computeD(tiesD[1], n, m, gcd) : d;
- double p;
+ final double p;
double p2;
// Allow bootstrap estimation of the p-value
@@ -649,8 +649,8 @@ public final class KolmogorovSmirnovTest {
// Test if the random statistic is greater (strict), or greater or
equal to d
final long d = strictInequality ? dnm : dnm - 1;
- long plus;
- long minus;
+ final long plus;
+ final long minus;
if (alternative == AlternativeHypothesis.GREATER_THAN) {
plus = d;
minus = Long.MIN_VALUE;
diff --git
a/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/TTest.java
b/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/TTest.java
index 25c654d..7d2eb01 100644
---
a/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/TTest.java
+++
b/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/TTest.java
@@ -402,8 +402,8 @@ public final class TTest {
final DoubleStatistics s2 = b.build(y);
final double m2 = s2.getAsDouble(Statistic.MEAN);
final double v2 = s2.getAsDouble(Statistic.VARIANCE);
- double t;
- double df;
+ final double t;
+ final double df;
if (equalVariances) {
t = computeHomoscedasticT(mu, m1, v1, n1, m2, v2, n2);
df = -2.0 + n1 + n2;
diff --git
a/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/UnconditionedExactTest.java
b/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/UnconditionedExactTest.java
index 31a02a5..51e63ca 100644
---
a/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/UnconditionedExactTest.java
+++
b/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/UnconditionedExactTest.java
@@ -736,7 +736,7 @@ public final class UnconditionedExactTest {
final double p1 = (double) b / n;
// Avoid NaN generation 0 / 0 when the variance is 0
if (p0 != p1) {
- double variance;
+ final double variance;
if (pooled) {
// Integer sums will not overflow
final double p = (double) (a + b) / (m + n);
@@ -763,7 +763,7 @@ public final class UnconditionedExactTest {
private double findExtremeTablesZ(int a, int b, int m, int n, boolean
pooled, XYList tableList) {
final double statistic = statisticZ(a, b, m, n, pooled);
// Identify more extreme tables using the alternate hypothesis
- DoublePredicate test;
+ final DoublePredicate test;
if (alternative == AlternativeHypothesis.GREATER_THAN) {
test = z -> z >= statistic;
} else if (alternative == AlternativeHypothesis.LESS_THAN) {
@@ -791,7 +791,7 @@ public final class UnconditionedExactTest {
if (p0 == p1) {
z = 0;
} else {
- double variance;
+ final double variance;
if (pooled) {
// Integer sums will not overflow
final double p = (i + j) / mn;
@@ -889,7 +889,7 @@ public final class UnconditionedExactTest {
final double statistic = statisticBoschloo(a, b, m, n);
// Function to compute the statistic
- BoschlooStatistic func;
+ final BoschlooStatistic func;
if (alternative == AlternativeHypothesis.GREATER_THAN) {
func = (dist, x) -> dist.sf(x - 1);
} else if (alternative == AlternativeHypothesis.LESS_THAN) {
@@ -966,7 +966,7 @@ public final class UnconditionedExactTest {
final BracketFinder bf = new BracketFinder();
minima.forEach(candidate -> {
double a = candidate[0];
- double fa;
+ final double fa;
// Attempt to bracket the minima. Use an initial second point
placed relative to
// the size of the interval: [x - increment, x + increment].
// if a < 0.5 then add a small delta ; otherwise subtract the
delta.
@@ -1013,8 +1013,8 @@ public final class UnconditionedExactTest {
final int width = tableList.getWidth();
// Compute the log binomial dynamically for a small number of values
- IntToDoubleFunction binomM;
- IntToDoubleFunction binomN;
+ final IntToDoubleFunction binomM;
+ final IntToDoubleFunction binomN;
if (tableList.size() < mn) {
binomM = k -> LogBinomialCoefficient.value(m, k);
binomN = k -> LogBinomialCoefficient.value(n, k);
diff --git
a/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/WilcoxonSignedRankTest.java
b/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/WilcoxonSignedRankTest.java
index 699464f..d794b89 100644
---
a/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/WilcoxonSignedRankTest.java
+++
b/commons-statistics-inference/src/main/java/org/apache/commons/statistics/inference/WilcoxonSignedRankTest.java
@@ -349,7 +349,7 @@ public final class WilcoxonSignedRankTest {
final int n = z.length;
// Exact p requires no ties and no zeros
- double p;
+ final double p;
if (selectMethod(pValueMethod, n) == PValueMethod.EXACT && n <=
EXACT_LIMIT && !tiedValues && zeros == 0) {
p = calculateExactPValue((int) wPlus, n, alternative);
} else {
