This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-email.git
The following commit(s) were added to refs/heads/master by this push:
new 6e93e43
org.apache.commons.mail2.jakarta.util.MimeMessageUtils.createMimeMessage(Session,
File) now uses NIO
6e93e43 is described below
commit 6e93e43d938be83331fc874ce79339279b065593
Author: Gary D. Gregory <[email protected]>
AuthorDate: Sat Mar 15 17:45:11 2025 -0400
org.apache.commons.mail2.jakarta.util.MimeMessageUtils.createMimeMessage(Session,
File) now uses NIO
org.apache.commons.mail2.javax.util.MimeMessageUtils.createMimeMessage(Session,
File) now uses NIO
---
.../java/org/apache/commons/mail2/jakarta/util/MimeMessageUtils.java | 5 +----
.../java/org/apache/commons/mail2/javax/util/MimeMessageUtils.java | 5 +----
src/changes/changes.xml | 2 ++
3 files changed, 4 insertions(+), 8 deletions(-)
diff --git
a/commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/util/MimeMessageUtils.java
b/commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/util/MimeMessageUtils.java
index ac42385..ab7b05e 100644
---
a/commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/util/MimeMessageUtils.java
+++
b/commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/util/MimeMessageUtils.java
@@ -17,7 +17,6 @@
package org.apache.commons.mail2.jakarta.util;
import java.io.File;
-import java.io.FileInputStream;
import java.io.FileOutputStream;
import java.io.IOException;
import java.io.InputStream;
@@ -64,9 +63,7 @@ public final class MimeMessageUtils {
* @throws IOException creating the MimeMessage failed.
*/
public static MimeMessage createMimeMessage(final Session session, final
File source) throws MessagingException, IOException {
- try (InputStream inputStream = new FileInputStream(source)) {
- return createMimeMessage(session, inputStream);
- }
+ return createMimeMessage(session, source.toPath());
}
/**
diff --git
a/commons-email2-javax/src/main/java/org/apache/commons/mail2/javax/util/MimeMessageUtils.java
b/commons-email2-javax/src/main/java/org/apache/commons/mail2/javax/util/MimeMessageUtils.java
index 1dc6155..bed9c29 100644
---
a/commons-email2-javax/src/main/java/org/apache/commons/mail2/javax/util/MimeMessageUtils.java
+++
b/commons-email2-javax/src/main/java/org/apache/commons/mail2/javax/util/MimeMessageUtils.java
@@ -17,7 +17,6 @@
package org.apache.commons.mail2.javax.util;
import java.io.File;
-import java.io.FileInputStream;
import java.io.FileOutputStream;
import java.io.IOException;
import java.io.InputStream;
@@ -64,9 +63,7 @@ public final class MimeMessageUtils {
* @throws IOException creating the MimeMessage failed.
*/
public static MimeMessage createMimeMessage(final Session session, final
File source) throws MessagingException, IOException {
- try (InputStream inputStream = new FileInputStream(source)) {
- return createMimeMessage(session, inputStream);
- }
+ return createMimeMessage(session, source.toPath());
}
/**
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 0b3b1dd..e0319d1 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -37,6 +37,8 @@
<action type="update" due-to="Gary Gregory"
dev="ggregory">EmailException doesn't need to override
printStackTrace().</action>
<action type="update" due-to="Gary Gregory"
dev="ggregory">EmailException doesn't need to override
printStackTrace(PrintStream).</action>
<action type="update" due-to="Gary Gregory"
dev="ggregory">EmailException doesn't need to override
printStackTrace(PrintWriter).</action>
+ <action type="update" due-to="Gary Gregory"
dev="ggregory">org.apache.commons.mail2.jakarta.util.MimeMessageUtils.createMimeMessage(Session,
File) now uses NIO.</action>
+ <action type="update" due-to="Gary Gregory"
dev="ggregory">org.apache.commons.mail2.javax.util.MimeMessageUtils.createMimeMessage(Session,
File) now uses NIO.</action>
</release>
<release version="2.0.0-M1" date="2024-06-15" description="Feature release
(Java 8 or above).">
<!-- ADD -->
