This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-jxpath.git
commit b4b3ba97c5d7ca0cf440325bab79c5924c269a7b Author: Gary D. Gregory <[email protected]> AuthorDate: Sun Mar 16 14:59:34 2025 -0400 Use streams API internally --- src/main/java/org/apache/commons/jxpath/BasicNodeSet.java | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/src/main/java/org/apache/commons/jxpath/BasicNodeSet.java b/src/main/java/org/apache/commons/jxpath/BasicNodeSet.java index d40fbd9..883c0bf 100644 --- a/src/main/java/org/apache/commons/jxpath/BasicNodeSet.java +++ b/src/main/java/org/apache/commons/jxpath/BasicNodeSet.java @@ -20,6 +20,7 @@ package org.apache.commons.jxpath; import java.util.ArrayList; import java.util.Collections; import java.util.List; +import java.util.stream.Collectors; /** * A simple implementation of {@link NodeSet} that behaves as a collection of pointers. @@ -65,12 +66,7 @@ public class BasicNodeSet implements NodeSet { @Override public synchronized List getNodes() { if (nodes == null) { - nodes = new ArrayList<>(); - for (int i = 0; i < pointers.size(); i++) { - final Pointer pointer = pointers.get(i); - nodes.add(pointer.getNode()); - } - nodes = Collections.unmodifiableList(nodes); + nodes = Collections.unmodifiableList(pointers.stream().map(Pointer::getNode).collect(Collectors.toList())); } return nodes; } @@ -86,12 +82,7 @@ public class BasicNodeSet implements NodeSet { @Override public synchronized List getValues() { if (values == null) { - values = new ArrayList<>(); - for (int i = 0; i < pointers.size(); i++) { - final Pointer pointer = pointers.get(i); - values.add(pointer.getValue()); - } - values = Collections.unmodifiableList(values); + values = Collections.unmodifiableList(pointers.stream().map(Pointer::getValue).collect(Collectors.toList())); } return values; }
