This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git
The following commit(s) were added to refs/heads/master by this push:
new e25640fcc Revert "Normalize test class names to *Test"
e25640fcc is described below
commit e25640fcc3f9ab42302986eb1e9189c563677c61
Author: Gary D. Gregory <[email protected]>
AuthorDate: Mon Jun 9 09:55:29 2025 -0400
Revert "Normalize test class names to *Test"
This reverts commit 61d0b3251cedfc4d837b846d72ca6c26c1e5bfc1.
---
.../java/org/apache/commons/lang3/time/CalendarUtilsTest.java | 8 --------
.../org/apache/commons/lang3/time/DateFormatUtilsTest.java | 6 ------
.../org/apache/commons/lang3/time/DateUtilsFragmentTest.java | 10 +---------
.../org/apache/commons/lang3/time/DateUtilsRoundingTest.java | 8 --------
.../org/apache/commons/lang3/time/DurationFormatUtilsTest.java | 7 -------
.../commons/lang3/time/FastDateParser_MoreOrLessTest.java | 10 +---------
.../org/apache/commons/lang3/time/FastDatePrinterTest.java | 6 ------
.../commons/lang3/time/FastDatePrinterTimeZonesTest.java | 10 +---------
.../apache/commons/lang3/time/Java15BugFastDateParserTest.java | 8 --------
9 files changed, 3 insertions(+), 70 deletions(-)
diff --git a/src/test/java/org/apache/commons/lang3/time/CalendarUtilsTest.java
b/src/test/java/org/apache/commons/lang3/time/CalendarUtilsTest.java
index 40cf27e7d..f5bf4fcd4 100644
--- a/src/test/java/org/apache/commons/lang3/time/CalendarUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/time/CalendarUtilsTest.java
@@ -34,15 +34,7 @@
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.MethodSource;
-import org.junitpioneer.jupiter.DefaultLocale;
-import org.junitpioneer.jupiter.DefaultTimeZone;
-import org.junitpioneer.jupiter.ReadsDefaultLocale;
-import org.junitpioneer.jupiter.ReadsDefaultTimeZone;
-/* Make test reproducible */ @DefaultLocale(language = "en")
-/* Make test reproducible */ @DefaultTimeZone(TimeZones.GMT_ID)
-/* Make test reproducible */ @ReadsDefaultLocale
-/* Make test reproducible */ @ReadsDefaultTimeZone
class CalendarUtilsTest extends AbstractLangTest {
@Test
diff --git
a/src/test/java/org/apache/commons/lang3/time/DateFormatUtilsTest.java
b/src/test/java/org/apache/commons/lang3/time/DateFormatUtilsTest.java
index f899652bb..e6e442cde 100644
--- a/src/test/java/org/apache/commons/lang3/time/DateFormatUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/time/DateFormatUtilsTest.java
@@ -33,17 +33,11 @@
import org.junit.jupiter.api.Test;
import org.junitpioneer.jupiter.DefaultLocale;
import org.junitpioneer.jupiter.DefaultTimeZone;
-import org.junitpioneer.jupiter.ReadsDefaultLocale;
-import org.junitpioneer.jupiter.ReadsDefaultTimeZone;
/**
* TestCase for DateFormatUtils.
*/
@SuppressWarnings("deprecation") // tests lots of deprecated items
-/* Make test reproducible */ @DefaultLocale(language = "en")
-/* Make test reproducible */ @DefaultTimeZone(TimeZones.GMT_ID)
-/* Make test reproducible */ @ReadsDefaultLocale
-/* Make test reproducible */ @ReadsDefaultTimeZone
class DateFormatUtilsTest extends AbstractLangTest {
private void assertFormats(final String expectedValue, final String
pattern, final TimeZone timeZone, final Calendar cal) {
assertEquals(expectedValue, DateFormatUtils.format(cal.getTime(),
pattern, timeZone));
diff --git
a/src/test/java/org/apache/commons/lang3/time/DateUtilsFragmentTest.java
b/src/test/java/org/apache/commons/lang3/time/DateUtilsFragmentTest.java
index e38c9cf82..fe46c5893 100644
--- a/src/test/java/org/apache/commons/lang3/time/DateUtilsFragmentTest.java
+++ b/src/test/java/org/apache/commons/lang3/time/DateUtilsFragmentTest.java
@@ -25,15 +25,7 @@
import org.apache.commons.lang3.AbstractLangTest;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-import org.junitpioneer.jupiter.DefaultLocale;
-import org.junitpioneer.jupiter.DefaultTimeZone;
-import org.junitpioneer.jupiter.ReadsDefaultLocale;
-import org.junitpioneer.jupiter.ReadsDefaultTimeZone;
-
-/* Make test reproducible */ @DefaultLocale(language = "en")
-/* Make test reproducible */ @DefaultTimeZone(TimeZones.GMT_ID)
-/* Make test reproducible */ @ReadsDefaultLocale
-/* Make test reproducible */ @ReadsDefaultTimeZone
+
class DateUtilsFragmentTest extends AbstractLangTest {
private static final int months = 7; // second final prime before 12
diff --git
a/src/test/java/org/apache/commons/lang3/time/DateUtilsRoundingTest.java
b/src/test/java/org/apache/commons/lang3/time/DateUtilsRoundingTest.java
index bf018ba8b..fb6b7e0e3 100644
--- a/src/test/java/org/apache/commons/lang3/time/DateUtilsRoundingTest.java
+++ b/src/test/java/org/apache/commons/lang3/time/DateUtilsRoundingTest.java
@@ -28,10 +28,6 @@
import org.apache.commons.lang3.AbstractLangTest;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-import org.junitpioneer.jupiter.DefaultLocale;
-import org.junitpioneer.jupiter.DefaultTimeZone;
-import org.junitpioneer.jupiter.ReadsDefaultLocale;
-import org.junitpioneer.jupiter.ReadsDefaultTimeZone;
/**
* These Unit-tests will check all possible extremes when using some
rounding-methods of DateUtils.
@@ -43,10 +39,6 @@
* A month with 29 or 30 days will be rounded up from the 16th
* A month with 31 days will be rounded up from the 17th
*/
-/* Make test reproducible */ @DefaultLocale(language = "en")
-/* Make test reproducible */ @DefaultTimeZone(TimeZones.GMT_ID)
-/* Make test reproducible */ @ReadsDefaultLocale
-/* Make test reproducible */ @ReadsDefaultTimeZone
class DateUtilsRoundingTest extends AbstractLangTest {
DateFormat dateTimeParser;
diff --git
a/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java
b/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java
index 9db56b985..139453bfb 100644
--- a/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java
@@ -34,10 +34,7 @@
import org.apache.commons.lang3.AbstractLangTest;
import org.apache.commons.lang3.time.DurationFormatUtils.Token;
import org.junit.jupiter.api.Test;
-import org.junitpioneer.jupiter.DefaultLocale;
import org.junitpioneer.jupiter.DefaultTimeZone;
-import org.junitpioneer.jupiter.ReadsDefaultLocale;
-import org.junitpioneer.jupiter.ReadsDefaultTimeZone;
/**
* Tests {@link DurationFormatUtils}.
@@ -45,10 +42,6 @@
* NOT THREAD-SAFE.
* </p>
*/
-/* Make test reproducible */ @DefaultLocale(language = "en")
-/* Make test reproducible */ @DefaultTimeZone(TimeZones.GMT_ID)
-/* Make test reproducible */ @ReadsDefaultLocale
-/* Make test reproducible */ @ReadsDefaultTimeZone
class DurationFormatUtilsTest extends AbstractLangTest {
private static final int FOUR_YEARS = 365 * 3 + 366;
diff --git
a/src/test/java/org/apache/commons/lang3/time/FastDateParser_MoreOrLessTest.java
b/src/test/java/org/apache/commons/lang3/time/FastDateParser_MoreOrLessTest.java
index dc1329a20..79e31aa96 100644
---
a/src/test/java/org/apache/commons/lang3/time/FastDateParser_MoreOrLessTest.java
+++
b/src/test/java/org/apache/commons/lang3/time/FastDateParser_MoreOrLessTest.java
@@ -28,15 +28,7 @@
import org.apache.commons.lang3.AbstractLangTest;
import org.junit.jupiter.api.Test;
-import org.junitpioneer.jupiter.DefaultLocale;
-import org.junitpioneer.jupiter.DefaultTimeZone;
-import org.junitpioneer.jupiter.ReadsDefaultLocale;
-import org.junitpioneer.jupiter.ReadsDefaultTimeZone;
-
-/* Make test reproducible */ @DefaultLocale(language = "en")
-/* Make test reproducible */ @DefaultTimeZone(TimeZones.GMT_ID)
-/* Make test reproducible */ @ReadsDefaultLocale
-/* Make test reproducible */ @ReadsDefaultTimeZone
+
class FastDateParser_MoreOrLessTest extends AbstractLangTest {
private static final TimeZone NEW_YORK =
TimeZone.getTimeZone("America/New_York");
diff --git
a/src/test/java/org/apache/commons/lang3/time/FastDatePrinterTest.java
b/src/test/java/org/apache/commons/lang3/time/FastDatePrinterTest.java
index f634c3f24..0593f14c1 100644
--- a/src/test/java/org/apache/commons/lang3/time/FastDatePrinterTest.java
+++ b/src/test/java/org/apache/commons/lang3/time/FastDatePrinterTest.java
@@ -35,16 +35,10 @@
import org.junit.jupiter.api.Test;
import org.junitpioneer.jupiter.DefaultLocale;
import org.junitpioneer.jupiter.DefaultTimeZone;
-import org.junitpioneer.jupiter.ReadsDefaultLocale;
-import org.junitpioneer.jupiter.ReadsDefaultTimeZone;
/**
* Tests {@link org.apache.commons.lang3.time.FastDatePrinter}.
*/
-/* Make test reproducible */ @DefaultLocale(language = "en")
-/* Make test reproducible */ @DefaultTimeZone(TimeZones.GMT_ID)
-/* Make test reproducible */ @ReadsDefaultLocale
-/* Make test reproducible */ @ReadsDefaultTimeZone
class FastDatePrinterTest extends AbstractLangTest {
private enum Expected1806 {
diff --git
a/src/test/java/org/apache/commons/lang3/time/FastDatePrinterTimeZonesTest.java
b/src/test/java/org/apache/commons/lang3/time/FastDatePrinterTimeZonesTest.java
index ec6c55089..fd046d053 100644
---
a/src/test/java/org/apache/commons/lang3/time/FastDatePrinterTimeZonesTest.java
+++
b/src/test/java/org/apache/commons/lang3/time/FastDatePrinterTimeZonesTest.java
@@ -26,15 +26,7 @@
import org.apache.commons.lang3.AbstractLangTest;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.MethodSource;
-import org.junitpioneer.jupiter.DefaultLocale;
-import org.junitpioneer.jupiter.DefaultTimeZone;
-import org.junitpioneer.jupiter.ReadsDefaultLocale;
-import org.junitpioneer.jupiter.ReadsDefaultTimeZone;
-
-/* Make test reproducible */ @DefaultLocale(language = "en")
-/* Make test reproducible */ @DefaultTimeZone(TimeZones.GMT_ID)
-/* Make test reproducible */ @ReadsDefaultLocale
-/* Make test reproducible */ @ReadsDefaultTimeZone
+
class FastDatePrinterTimeZonesTest extends AbstractLangTest {
private static final String PATTERN = "h:mma z";
diff --git
a/src/test/java/org/apache/commons/lang3/time/Java15BugFastDateParserTest.java
b/src/test/java/org/apache/commons/lang3/time/Java15BugFastDateParserTest.java
index 35c72b738..45ac0513d 100644
---
a/src/test/java/org/apache/commons/lang3/time/Java15BugFastDateParserTest.java
+++
b/src/test/java/org/apache/commons/lang3/time/Java15BugFastDateParserTest.java
@@ -29,10 +29,6 @@
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.MethodSource;
-import org.junitpioneer.jupiter.DefaultLocale;
-import org.junitpioneer.jupiter.DefaultTimeZone;
-import org.junitpioneer.jupiter.ReadsDefaultLocale;
-import org.junitpioneer.jupiter.ReadsDefaultTimeZone;
/**
* These tests fail on Java 15 due to a bug which was only fixed for Java 16.
@@ -41,10 +37,6 @@
* <li>https://bugs.openjdk.java.net/browse/JDK-8248655</li>
* </ul>
*/
-/* Make test reproducible */ @DefaultLocale(language = "en")
-/* Make test reproducible */ @DefaultTimeZone(TimeZones.GMT_ID)
-/* Make test reproducible */ @ReadsDefaultLocale
-/* Make test reproducible */ @ReadsDefaultTimeZone
class Java15BugFastDateParserTest extends AbstractLangTest {
/** @see
org.apache.commons.lang3.time.FastDateParserTest#dateParserParameters() */
