(commons-fileupload) branch 1.x updated: Use SystemProperties

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch 1.x
in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git


The following commit(s) were added to refs/heads/1.x by this push:
     new 23a9ece5 Use SystemProperties
23a9ece5 is described below

commit 23a9ece596bf989c0093f0244eb991470e4299cf
Author: Gary D. Gregory <garydgreg...@gmail.com>
AuthorDate: Sun Jul 20 14:52:24 2025 -0400

    Use SystemProperties
---
 pom.xml                                                            | 6 ++++++
 .../java/org/apache/commons/fileupload/DefaultFileItemTest.java    | 4 +++-
 .../org/apache/commons/fileupload/DiskFileItemSerializeTest.java   | 7 ++++---
 3 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/pom.xml b/pom.xml
index a1a9125f..94c7f013 100644
--- a/pom.xml
+++ b/pom.xml
@@ -116,6 +116,12 @@
       <artifactId>commons-io</artifactId>
       <version>2.20.0</version>
     </dependency>
+    <dependency>
+      <groupId>org.apache.commons</groupId>
+      <artifactId>commons-lang3</artifactId>
+      <version>3.18.0</version>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
   <build>
     <defaultGoal>clean verify javadoc:javadoc japicmp:cmp apache-rat:check 
checkstyle:check</defaultGoal>
diff --git 
a/src/test/java/org/apache/commons/fileupload/DefaultFileItemTest.java 
b/src/test/java/org/apache/commons/fileupload/DefaultFileItemTest.java
index 2342303f..1793cead 100644
--- a/src/test/java/org/apache/commons/fileupload/DefaultFileItemTest.java
+++ b/src/test/java/org/apache/commons/fileupload/DefaultFileItemTest.java
@@ -30,6 +30,7 @@ import java.nio.charset.StandardCharsets;
 import java.util.Arrays;
 
 import org.apache.commons.io.FileUtils;
+import org.apache.commons.lang3.SystemProperties;
 import org.junit.Test;
 
 /**
@@ -154,7 +155,8 @@ public class DefaultFileItemTest {
      */
     @Test
     public void testAboveThresholdSpecifiedRepository() throws IOException {
-        final String tempPath = System.getProperty("java.io.tmpdir");
+        final String tempPath = SystemProperties.getJavaIoTmpdir();
+        SystemProperties.getJavaIoTmpdir();
         final String tempDirName = "testAboveThresholdSpecifiedRepository";
         final File tempDir = new File(tempPath, tempDirName);
         FileUtils.forceMkdir(tempDir);
diff --git 
a/src/test/java/org/apache/commons/fileupload/DiskFileItemSerializeTest.java 
b/src/test/java/org/apache/commons/fileupload/DiskFileItemSerializeTest.java
index ce4c9a9d..a1790d7b 100644
--- a/src/test/java/org/apache/commons/fileupload/DiskFileItemSerializeTest.java
+++ b/src/test/java/org/apache/commons/fileupload/DiskFileItemSerializeTest.java
@@ -33,6 +33,7 @@ import java.nio.file.InvalidPathException;
 
 import org.apache.commons.fileupload.disk.DiskFileItemFactory;
 import org.apache.commons.io.FileUtils;
+import org.apache.commons.lang3.SystemProperties;
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
@@ -43,7 +44,7 @@ import org.junit.Test;
 public class DiskFileItemSerializeTest {
 
     // Use a private repo to catch any files left over by tests
-    private static final File REPO = new 
File(System.getProperty("java.io.tmpdir"), "diskfileitemrepo");
+    private static final File REPO = new 
File(SystemProperties.getJavaIoTmpdir(), "diskfileitemrepo");
 
     /**
      * Content type for regular form items.
@@ -206,7 +207,7 @@ public class DiskFileItemSerializeTest {
     public void testInvalidRepository() throws Exception {
         // Create the FileItem
         final byte[] testFieldValueBytes = createContentBytes(THRESHOLD);
-        final File repository = new File(System.getProperty("java.io.tmpdir"), 
"file");
+        final File repository = new File(SystemProperties.getJavaIoTmpdir(), 
"file");
         final FileItem item = createFileItem(testFieldValueBytes, repository);
         deserialize(serialize(item));
     }
@@ -218,7 +219,7 @@ public class DiskFileItemSerializeTest {
     public void testInvalidRepositoryWithNullChar() throws Exception {
         // Create the FileItem
         final byte[] testFieldValueBytes = createContentBytes(THRESHOLD);
-        final File repository = new File(System.getProperty("java.io.tmpdir"), 
"\0");
+        final File repository = new File(SystemProperties.getJavaIoTmpdir(), 
"\0");
         final FileItem item = createFileItem(testFieldValueBytes, repository);
         deserialize(serialize(item));
     }