This is an automated email from the ASF dual-hosted git repository. aherbert pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-geometry.git
commit 5ebbfb70142e3358c619561503a7a489935c9328 Author: Alex Herbert <[email protected]> AuthorDate: Mon Sep 22 14:55:04 2025 +0100 pmd fix: remove unnecessary scope qualifier --- .../geometry/euclidean/threed/rotation/QuaternionRotation.java | 2 +- .../main/java/org/apache/commons/geometry/euclidean/twod/Lines.java | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/rotation/QuaternionRotation.java b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/rotation/QuaternionRotation.java index 9dc1ee4d..ba62ac0b 100644 --- a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/rotation/QuaternionRotation.java +++ b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/rotation/QuaternionRotation.java @@ -276,7 +276,7 @@ public final class QuaternionRotation implements Rotation3D { */ public DoubleFunction<QuaternionRotation> slerp(final QuaternionRotation end) { final Slerp s = new Slerp(getQuaternion(), end.getQuaternion()); - return t -> QuaternionRotation.of(s.apply(t)); + return t -> of(s.apply(t)); } /** Get a sequence of axis-angle rotations that produce an overall rotation equivalent to this instance. diff --git a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/Lines.java b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/Lines.java index 25549c6b..5a89152c 100644 --- a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/Lines.java +++ b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/Lines.java @@ -88,7 +88,7 @@ public final class Lines { */ public static Ray rayFromPointAndDirection(final Vector2D startPoint, final Vector2D direction, final Precision.DoubleEquivalence precision) { - final Line line = Lines.fromPointAndDirection(startPoint, direction, precision); + final Line line = fromPointAndDirection(startPoint, direction, precision); return new Ray(line, startPoint); } @@ -134,7 +134,7 @@ public final class Lines { */ public static ReverseRay reverseRayFromPointAndDirection(final Vector2D endPoint, final Vector2D lineDirection, final Precision.DoubleEquivalence precision) { - final Line line = Lines.fromPointAndDirection(endPoint, lineDirection, precision); + final Line line = fromPointAndDirection(endPoint, lineDirection, precision); return new ReverseRay(line, endPoint); } @@ -180,7 +180,7 @@ public final class Lines { */ public static Segment segmentFromPoints(final Vector2D startPoint, final Vector2D endPoint, final Precision.DoubleEquivalence precision) { - final Line line = Lines.fromPoints(startPoint, endPoint, precision); + final Line line = fromPoints(startPoint, endPoint, precision); // we know that the points lie on the line and are in increasing abscissa order // since they were used to create the line
